From d4dcfcdbc66b09678dcb15292479b4abf0da6d47 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 25 Jul 2023 18:06:25 +0530 Subject: [PATCH 1/3] chore: remove dev dependencies --- package.json | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/package.json b/package.json index 7f3e41ff..efae27f8 100644 --- a/package.json +++ b/package.json @@ -14,17 +14,5 @@ "bugs": { "url": "https://github.com/frappe/lms/issues" }, - "homepage": "https://github.com/frappe/lms#readme", - "devDependencies": { - "cypress": "^10" - }, - "dependencies": { - "@4tw/cypress-drag-drop": "^2", - "@cypress/code-coverage": "^3", - "@editorjs/header": "^2.7.0", - "@editorjs/list": "^1.8.0", - "@testing-library/cypress": "^8", - "@testing-library/dom": "8.17.1", - "cypress-real-events": "^1.7.6" - } + "homepage": "https://github.com/frappe/lms#readme" } From 2412ef0260bd2e4b7b804c5a81a27d0c0618975a Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 25 Jul 2023 18:48:31 +0530 Subject: [PATCH 2/3] fix: dependencies --- package.json | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index efae27f8..021b0ad1 100644 --- a/package.json +++ b/package.json @@ -14,5 +14,14 @@ "bugs": { "url": "https://github.com/frappe/lms/issues" }, - "homepage": "https://github.com/frappe/lms#readme" + "homepage": "https://github.com/frappe/lms#readme", + "dependencies": { + "@4tw/cypress-drag-drop": "^2", + "@cypress/code-coverage": "^3", + "@editorjs/header": "^2.7.0", + "@editorjs/list": "^1.8.0", + "@testing-library/cypress": "^8", + "@testing-library/dom": "8.17.1", + "cypress-real-events": "^1.7.6" + } } From 3c374f48b39bda1169f4691d97bcae07d7527abf Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 25 Jul 2023 19:20:55 +0530 Subject: [PATCH 3/3] ci: manually installing cypress --- .github/workflows/ui-tests.yml | 5 +++++ package.json | 11 +---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index d59e5acc..b9aa4614 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -100,6 +100,11 @@ jobs: bench --site lms.test execute frappe.utils.install.complete_setup_wizard bench --site lms.test execute frappe.tests.ui_test_helpers.create_test_user + - name: cypress pre-requisites + run: | + cd ~/frappe-bench/apps/lms + yarn add cypress@^10 --no-lockfile + - name: UI Tests run: cd ~/frappe-bench/ && bench --site lms.test run-ui-tests lms --headless env: diff --git a/package.json b/package.json index 021b0ad1..efae27f8 100644 --- a/package.json +++ b/package.json @@ -14,14 +14,5 @@ "bugs": { "url": "https://github.com/frappe/lms/issues" }, - "homepage": "https://github.com/frappe/lms#readme", - "dependencies": { - "@4tw/cypress-drag-drop": "^2", - "@cypress/code-coverage": "^3", - "@editorjs/header": "^2.7.0", - "@editorjs/list": "^1.8.0", - "@testing-library/cypress": "^8", - "@testing-library/dom": "8.17.1", - "cypress-real-events": "^1.7.6" - } + "homepage": "https://github.com/frappe/lms#readme" }