diff --git a/community/lms/doctype/lms_batch_membership/lms_batch_membership.json b/community/lms/doctype/lms_batch_membership/lms_batch_membership.json index f7f1f2dc..3a0bfa0c 100644 --- a/community/lms/doctype/lms_batch_membership/lms_batch_membership.json +++ b/community/lms/doctype/lms_batch_membership/lms_batch_membership.json @@ -37,6 +37,7 @@ "fieldname": "member_type", "fieldtype": "Select", "in_list_view": 1, + "in_standard_filter": 1, "label": "Member Type", "options": "\nStudent\nMentor\nStaff" }, @@ -44,7 +45,6 @@ "default": "Member", "fieldname": "role", "fieldtype": "Select", - "in_standard_filter": 1, "label": "Role", "options": "\nMember\nAdmin" }, @@ -63,9 +63,10 @@ { "fetch_from": "batch.course", "fieldname": "course", - "fieldtype": "Data", + "fieldtype": "Link", "in_list_view": 1, - "label": "Course" + "label": "Course", + "options": "LMS Course" }, { "fieldname": "current_lesson", @@ -83,7 +84,7 @@ ], "index_web_pages_for_search": 1, "links": [], - "modified": "2021-07-06 20:50:46.885325", + "modified": "2021-08-04 17:10:42.708479", "modified_by": "Administrator", "module": "LMS", "name": "LMS Batch Membership", diff --git a/community/lms/doctype/lms_course/lms_course.py b/community/lms/doctype/lms_course/lms_course.py index 5ec7a17f..867dda3b 100644 --- a/community/lms/doctype/lms_course/lms_course.py +++ b/community/lms/doctype/lms_course/lms_course.py @@ -74,8 +74,11 @@ class LMSCourse(Document): mentors = frappe.get_all("LMS Course Mentor Mapping", {"course": self.name}, ["mentor"]) for mentor in mentors: member = frappe.get_doc("User", mentor.mentor) - # TODO: change this to count query - member.batch_count = len(frappe.get_all("LMS Batch Membership", {"member": member.name, "member_type": "Mentor"})) + member.batch_count = frappe.db.count("LMS Batch Membership", + { + "member": member.name, + "member_type": "Mentor" + }) course_mentors.append(member) return course_mentors @@ -238,21 +241,6 @@ class LMSCourse(Document): membership.batch_title = frappe.db.get_value("LMS Batch", membership.batch, "title") return all_memberships - def get_mentors(self, batch=None): - filters = { - "course": self.name, - "member_type": "Mentor" - } - if batch: - filters["batch"] = batch - - memberships = frappe.get_all( - "LMS Batch Membership", - filters, - ["member"]) - member_names = [m['member'] for m in memberships] - return find_all("User", name=["IN", member_names]) - def get_students(self, batch=None): """Returns (email, full_name, username) of all the students of this batch as a list of dict. """ diff --git a/community/lms/widgets/RenderBatch.html b/community/lms/widgets/RenderBatch.html deleted file mode 100644 index bb70c2c5..00000000 --- a/community/lms/widgets/RenderBatch.html +++ /dev/null @@ -1,30 +0,0 @@ -