From 659b35f03e8da781cb9c1d64360def6c4c784818 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 5 Jun 2023 16:17:43 +0530 Subject: [PATCH 1/6] fix: embed video with spaces in name --- lms/plugins.py | 5 ++++- lms/www/batch/edit.js | 12 ++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lms/plugins.py b/lms/plugins.py index cc4fb359..cecef2f1 100644 --- a/lms/plugins.py +++ b/lms/plugins.py @@ -15,6 +15,7 @@ be loaded in a webpage. """ import frappe +from urllib.parse import quote class PageExtension: @@ -138,7 +139,9 @@ def youtube_video_renderer(video_id): def video_renderer(src): - return f"" + return ( + f"" + ) def assignment_renderer(detail): diff --git a/lms/www/batch/edit.js b/lms/www/batch/edit.js index 306b9580..2e9145a1 100644 --- a/lms/www/batch/edit.js +++ b/lms/www/batch/edit.js @@ -263,6 +263,10 @@ class YouTubeVideo { `; } + validate(savedData) { + return !savedData.youtube || !savedData.youtube.trim() ? false : true; + } + save(block_content) { return { youtube: this.data.youtube || this.youtube, @@ -329,6 +333,10 @@ class Quiz { `; } + validate(savedData) { + return !savedData.quiz || !savedData.quiz.trim() ? false : true; + } + save(block_content) { return { quiz: this.data.quiz || this.quiz, @@ -385,6 +393,10 @@ class Upload { } } + validate(savedData) { + return !savedData.file_url || !savedData.file_url.trim() ? false : true; + } + save(block_content) { return { file_url: this.data.file_url || this.file_url, From 8474d1c8c42b544f1e3776684033e816bfb5f00d Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Tue, 6 Jun 2023 12:55:32 +0530 Subject: [PATCH 2/6] docs: PH embed on readme --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 6fcc5f36..59653a2c 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,14 @@

- Frappe LMS + Frappe LMS

Easy to use, open source, learning management system.

+

+ Frappe LMS - Easy to Use, 100% Open Source, Learning Management System | Product Hunt +

+

cypress From 6574b554405fdbe523ba49b9a98bd06c33dd82bd Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Tue, 6 Jun 2023 12:57:06 +0530 Subject: [PATCH 3/6] docs: fix logo in readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 59653a2c..011aad36 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@

- Frappe LMS + Frappe LMS

Easy to use, open source, learning management system.

From 9800c24939f086be03471fa3a7998b6a5fbe0aae Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 6 Jun 2023 22:08:24 +0530 Subject: [PATCH 4/6] docs: FC signup button on readme --- .github/try-on-f-cloud.svg | 32 ++++++++++++++++++++++++++++++++ README.md | 6 ++++++ 2 files changed, 38 insertions(+) create mode 100644 .github/try-on-f-cloud.svg diff --git a/.github/try-on-f-cloud.svg b/.github/try-on-f-cloud.svg new file mode 100644 index 00000000..6a7119bd --- /dev/null +++ b/.github/try-on-f-cloud.svg @@ -0,0 +1,32 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/README.md b/README.md index 011aad36..257a36f1 100644 --- a/README.md +++ b/README.md @@ -9,6 +9,12 @@ Frappe LMS - Easy to Use, 100% Open Source, Learning Management System | Product Hunt

+
+ + + +
+

cypress From f5e7934906bc99404f605f67cd3436ef88fd9814 Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Tue, 6 Jun 2023 22:09:41 +0530 Subject: [PATCH 5/6] docs: fixed FC signup button --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 257a36f1..47dd49b2 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@

- +
From 5a32109d5d8c53b08e370653b8ea3ffe2ff3b45f Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Tue, 6 Jun 2023 22:20:27 +0530 Subject: [PATCH 6/6] docs: updated FC link in readme --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 47dd49b2..2b0e12d5 100644 --- a/README.md +++ b/README.md @@ -5,16 +5,22 @@

Easy to use, open source, learning management system.

+ +  +

Frappe LMS - Easy to Use, 100% Open Source, Learning Management System | Product Hunt

+
+  +

cypress