From 1a1cbd6ea135923b7c0b08b3a634e3a423ceeb47 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 5 Jun 2025 12:58:12 +0530
Subject: [PATCH] fix: batch instructor should be linked to evaluator

---
 .../src/components/Controls/MultiSelect.vue   |  3 ++-
 .../src/components/Settings/Evaluators.vue    |  1 +
 frontend/src/pages/BatchForm.vue              |  4 ++--
 .../course_evaluator/course_evaluator.json    |  7 +++---
 lms/patches.txt                               |  3 ++-
 .../move_batch_instructors_to_evaluators.py   | 22 +++++++++++++++++++
 6 files changed, 33 insertions(+), 7 deletions(-)
 create mode 100644 lms/patches/v2_0/move_batch_instructors_to_evaluators.py

diff --git a/frontend/src/components/Controls/MultiSelect.vue b/frontend/src/components/Controls/MultiSelect.vue
index 678dfb28..dd36d07d 100644
--- a/frontend/src/components/Controls/MultiSelect.vue
+++ b/frontend/src/components/Controls/MultiSelect.vue
@@ -55,9 +55,10 @@
 											</div>
 										</li>
 									</ComboboxOption>
+									<div class="h-10"></div>
 									<div
 										v-if="attrs.onCreate"
-										class="absolute bottom-2 left-1 w-[98%] pt-2 bg-white border-t"
+										class="absolute bottom-2 left-1 w-[99%] pt-2 bg-white border-t"
 									>
 										<Button
 											variant="ghost"
diff --git a/frontend/src/components/Settings/Evaluators.vue b/frontend/src/components/Settings/Evaluators.vue
index 7bb90820..7d4b6d9f 100644
--- a/frontend/src/components/Settings/Evaluators.vue
+++ b/frontend/src/components/Settings/Evaluators.vue
@@ -33,6 +33,7 @@
 				:placeholder="__('Email')"
 				type="email"
 				class="w-full"
+				@keydown.enter="addEvaluator"
 			/>
 			<Button @click="addEvaluator()" variant="subtle">
 				{{ __('Add') }}
diff --git a/frontend/src/pages/BatchForm.vue b/frontend/src/pages/BatchForm.vue
index 6c8f984e..b90ff811 100644
--- a/frontend/src/pages/BatchForm.vue
+++ b/frontend/src/pages/BatchForm.vue
@@ -23,10 +23,10 @@
 						/>
 						<MultiSelect
 							v-model="instructors"
-							doctype="User"
+							doctype="Course Evaluator"
 							:label="__('Instructors')"
 							:required="true"
-							:onCreate="(close) => openSettings('Members', close)"
+							:onCreate="(close) => openSettings('Evaluators', close)"
 							:filters="{ ignore_user_type: 1 }"
 						/>
 					</div>
diff --git a/lms/lms/doctype/course_evaluator/course_evaluator.json b/lms/lms/doctype/course_evaluator/course_evaluator.json
index 702aabc8..3d466684 100644
--- a/lms/lms/doctype/course_evaluator/course_evaluator.json
+++ b/lms/lms/doctype/course_evaluator/course_evaluator.json
@@ -86,8 +86,8 @@
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2025-03-26 14:02:46.588721",
- "modified_by": "Administrator",
+ "modified": "2025-06-05 11:04:32.475711",
+ "modified_by": "sayali@frappe.io",
  "module": "LMS",
  "name": "Course Evaluator",
  "naming_rule": "By fieldname",
@@ -133,5 +133,6 @@
  "row_format": "Dynamic",
  "sort_field": "modified",
  "sort_order": "DESC",
- "states": []
+ "states": [],
+ "title_field": "full_name"
 }
diff --git a/lms/patches.txt b/lms/patches.txt
index 705b09e2..237166cd 100644
--- a/lms/patches.txt
+++ b/lms/patches.txt
@@ -107,4 +107,5 @@ lms.patches.v2_0.update_course_evaluator_data
 lms.patches.v2_0.move_zoom_settings #20-05-2025
 lms.patches.v2_0.link_zoom_account_to_live_class
 lms.patches.v2_0.link_zoom_account_to_batch
-lms.patches.v2_0.sidebar_for_certified_members
\ No newline at end of file
+lms.patches.v2_0.sidebar_for_certified_members
+lms.patches.v2_0.move_batch_instructors_to_evaluators
\ No newline at end of file
diff --git a/lms/patches/v2_0/move_batch_instructors_to_evaluators.py b/lms/patches/v2_0/move_batch_instructors_to_evaluators.py
new file mode 100644
index 00000000..a7866798
--- /dev/null
+++ b/lms/patches/v2_0/move_batch_instructors_to_evaluators.py
@@ -0,0 +1,22 @@
+import frappe
+
+
+def execute():
+	batch_instructors = frappe.get_all(
+		"Course Instructor",
+		{
+			"parenttype": "LMS Batch",
+		},
+		["name", "instructor", "parent"],
+	)
+
+	for instructor in batch_instructors:
+		if not frappe.db.exists(
+			"Course Evaluator",
+			{
+				"evaluator": instructor.instructor,
+			},
+		):
+			doc = frappe.new_doc("Course Evaluator")
+			doc.evaluator = instructor.instructor
+			doc.insert()