From 1f18ef4362a5fc4ad5ece7f69d96f86f4f2b9e74 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Fri, 19 Jan 2024 17:44:47 +0530
Subject: [PATCH] feat: discussions in batches

---
 frontend/src/components/DiscussionReplies.vue | 12 +++--
 frontend/src/components/Discussions.vue       | 16 +++++--
 frontend/src/pages/Batch.vue                  | 46 ++++++++++++++-----
 frontend/src/pages/BatchDetail.vue            | 13 ++++++
 frontend/src/pages/Lesson.vue                 |  4 +-
 frontend/src/pages/Statistics.vue             |  1 -
 lms/lms/utils.py                              | 24 +++++++++-
 lms/patches.txt                               |  3 +-
 .../v1_0/custom_perm_for_discussions.py       | 42 +++++++++++++++++
 9 files changed, 137 insertions(+), 24 deletions(-)
 create mode 100644 lms/patches/v1_0/custom_perm_for_discussions.py

diff --git a/frontend/src/components/DiscussionReplies.vue b/frontend/src/components/DiscussionReplies.vue
index 8c863f0c..e6c7fc81 100644
--- a/frontend/src/components/DiscussionReplies.vue
+++ b/frontend/src/components/DiscussionReplies.vue
@@ -1,6 +1,6 @@
 <template>
 	<div class="mt-6">
-		<div class="flex items-center mb-5">
+		<div v-if="!singleThread" class="flex items-center mb-5">
 			<Button variant="outline" @click="showTopics = true">
 				<template #icon>
 					<ChevronLeft class="w-5 h-5 stroke-1.5 text-gray-700" />
@@ -63,7 +63,7 @@
 					:fixedMenu="reply.editable || false"
 					:editorClass="
 						reply.editable
-							? 'prose-sm max-w-none border-b border-x rounded-b-md py-1 px-2 min-h-[4rem]'
+							? 'ProseMirror prose prose-table:table-fixed prose-td:p-2 prose-th:p-2 prose-td:border prose-th:border prose-td:border-gray-300 prose-th:border-gray-300 prose-td:relative prose-th:relative prose-th:bg-gray-100 prose-sm max-w-none'
 							: 'prose-sm'
 					"
 				/>
@@ -75,7 +75,7 @@
 			@change="(val) => (newReply = val)"
 			placeholder="Type your reply here..."
 			:fixedMenu="true"
-			editorClass="prose-sm max-w-none min-h-[7rem] border-b border-x rounded-b-md py-1 px-2"
+			editorClass="ProseMirror prose prose-table:table-fixed prose-td:p-2 prose-th:p-2 prose-td:border prose-th:border prose-td:border-gray-300 prose-th:border-gray-300 prose-td:relative prose-th:relative prose-th:bg-gray-100 prose-sm max-w-none border border-gray-300 rounded-b-md min-h-[7rem] py-1 px-2"
 		/>
 		<div class="flex justify-between mt-2">
 			<span> </span>
@@ -105,6 +105,10 @@ const props = defineProps({
 		type: Object,
 		required: true,
 	},
+	singleThread: {
+		type: Boolean,
+		default: false,
+	},
 })
 
 onMounted(() => {
@@ -156,7 +160,7 @@ const postReply = () => {
 				newReply.value = ''
 				replies.reload()
 			},
-			onError() {
+			onError(err) {
 				createToast({
 					title: 'Error',
 					text: err.messages?.[0] || err,
diff --git a/frontend/src/components/Discussions.vue b/frontend/src/components/Discussions.vue
index c0faa673..69b4c5e0 100644
--- a/frontend/src/components/Discussions.vue
+++ b/frontend/src/components/Discussions.vue
@@ -1,13 +1,13 @@
 <template>
 	<div>
-		<Button class="float-right" @click="openTopicModal()">
+		<Button v-if="!singleThread" class="float-right" @click="openTopicModal()">
 			{{ __('New {0}').format(title) }}
 		</Button>
 		<div class="text-xl font-semibold">
 			{{ __(title) }}
 		</div>
 	</div>
-	<div v-if="topics.data?.length">
+	<div v-if="topics.data?.length && !singleThread">
 		<div v-if="showTopics" v-for="(topic, index) in topics.data">
 			<div
 				@click="showReplies(topic)"
@@ -37,6 +37,9 @@
 			/>
 		</div>
 	</div>
+	<div v-else-if="singleThread && topics.data">
+		<DiscussionReplies :topic="topics.data" :singleThread="singleThread" />
+	</div>
 	<div v-else class="flex justify-center border mt-5 p-5 rounded-md">
 		<MessageSquareIcon class="w-10 h-10 stroke-1.5 text-gray-800 mr-2" />
 		<div>
@@ -57,13 +60,13 @@
 	/>
 </template>
 <script setup>
-import { createResource, Button } from 'frappe-ui'
+import { createResource, Button, TextEditor } from 'frappe-ui'
 import UserAvatar from '@/components/UserAvatar.vue'
 import { timeAgo } from '../utils'
 import { ref, onMounted, inject } from 'vue'
 import DiscussionReplies from '@/components/DiscussionReplies.vue'
 import DiscussionModal from '@/components/Modals/DiscussionModal.vue'
-import { MessageSquareIcon, MessagesSquare } from 'lucide-vue-next'
+import { MessageSquareIcon } from 'lucide-vue-next'
 
 const showTopics = ref(true)
 const currentTopic = ref(null)
@@ -91,6 +94,10 @@ const props = defineProps({
 		type: String,
 		default: 'Be the first to start a discussion',
 	},
+	singleThread: {
+		type: Boolean,
+		default: false,
+	},
 })
 
 onMounted(() => {
@@ -106,6 +113,7 @@ const topics = createResource({
 		return {
 			doctype: props.doctype,
 			docname: props.docname,
+			single_thread: props.singleThread,
 		}
 	},
 	auto: true,
diff --git a/frontend/src/pages/Batch.vue b/frontend/src/pages/Batch.vue
index b730378a..add4a62b 100644
--- a/frontend/src/pages/Batch.vue
+++ b/frontend/src/pages/Batch.vue
@@ -16,7 +16,7 @@
 		<div v-if="batch.data" class="grid grid-cols-[70%,30%] h-full">
 			<div class="border-r-2">
 				<Tabs class="overflow-hidden" v-model="tabIndex" :tabs="tabs">
-					<template #tab="{ tab, selected }">
+					<template #tab="{ tab, selected }" class="overflow-x-hidden">
 						<div>
 							<button
 								class="group -mb-px flex items-center gap-1 border-b border-transparent py-2.5 text-base text-gray-600 duration-300 ease-in-out hover:border-gray-400 hover:text-gray-900"
@@ -80,6 +80,15 @@
 							<div v-else-if="tab.label == 'Announcements'">
 								<Announcements :batch="batch.data.name" />
 							</div>
+							<div v-else-if="tab.label == 'Discussions'">
+								<Discussions
+									doctype="LMS Batch"
+									:docname="batch.data.name"
+									title="Discussions"
+									:key="batch.data.name"
+									:singleThread="true"
+								/>
+							</div>
 						</div>
 					</template>
 				</Tabs>
@@ -168,6 +177,7 @@ import {
 	Contact2,
 	Mail,
 	SendIcon,
+	MessageCircle,
 } from 'lucide-vue-next'
 import { formatTime } from '@/utils'
 import CourseCard from '@/components/CourseCard.vue'
@@ -177,6 +187,7 @@ import BatchStudents from '@/components/BatchStudents.vue'
 import Assessments from '@/components/Assessments.vue'
 import Announcements from '@/components/Annoucements.vue'
 import AnnouncementModal from '@/components/Modals/AnnouncementModal.vue'
+import Discussions from '@/components/Discussions.vue'
 
 const dayjs = inject('$dayjs')
 const user = inject('$user')
@@ -199,17 +210,23 @@ const batch = createResource({
 })
 
 const breadcrumbs = computed(() => {
-	return [
-		{ label: 'All Batches', route: { name: 'Batches' } },
-		{
-			label: 'Batch Details',
-			route: { name: 'BatchDetail', params: { batchName: props.batchName } },
-		},
-		{
-			label: batch?.data?.title,
-			route: { name: 'Batch', params: { batchName: props.batchName } },
-		},
-	]
+	let crumbs = [{ label: 'All Batches', route: { name: 'Batches' } }]
+	if (!isStudent.value) {
+		crumbs.push({
+			label: batch.data?.title,
+			route: {
+				name: 'BatchDetail',
+				params: {
+					batchName: batch.data?.name,
+				},
+			},
+		})
+	}
+	crumbs.push({
+		label: batch?.data?.title,
+		route: { name: 'Batch', params: { batchName: props.batchName } },
+	})
+	return crumbs
 })
 
 const isStudent = computed(() => {
@@ -256,6 +273,11 @@ tabs.push({
 	icon: Mail,
 })
 
+tabs.push({
+	label: 'Discussions',
+	icon: MessageCircle,
+})
+
 const courses = createResource({
 	url: 'lms.lms.utils.get_batch_courses',
 	params: {
diff --git a/frontend/src/pages/BatchDetail.vue b/frontend/src/pages/BatchDetail.vue
index d1e7832c..58aa3329 100644
--- a/frontend/src/pages/BatchDetail.vue
+++ b/frontend/src/pages/BatchDetail.vue
@@ -89,8 +89,11 @@ import { formatTime } from '../utils'
 import { computed, inject } from 'vue'
 import BatchOverlay from '@/components/BatchOverlay.vue'
 import CourseCard from '@/components/CourseCard.vue'
+import { useRouter } from 'vue-router'
 
 const dayjs = inject('$dayjs')
+const user = inject('$user')
+const router = useRouter()
 
 const props = defineProps({
 	batchName: {
@@ -106,6 +109,16 @@ const batch = createResource({
 		batch: props.batchName,
 	},
 	auto: true,
+	onSuccess(data) {
+		if (data.students?.includes(user.data.name)) {
+			router.push({
+				name: 'Batch',
+				params: {
+					batchName: props.batchName,
+				},
+			})
+		}
+	},
 })
 
 const courses = createResource({
diff --git a/frontend/src/pages/Lesson.vue b/frontend/src/pages/Lesson.vue
index 7db6826e..68859559 100644
--- a/frontend/src/pages/Lesson.vue
+++ b/frontend/src/pages/Lesson.vue
@@ -85,7 +85,9 @@
 						{{ course.data.instructors.length - 1 }} others
 					</span>
 				</div>
-				<div class="lesson-content mt-6">
+				<div
+					class="ProseMirror prose prose-table:table-fixed prose-td:p-2 prose-th:p-2 prose-td:border prose-th:border prose-td:border-gray-300 prose-th:border-gray-300 prose-td:relative prose-th:relative prose-th:bg-gray-100 prose-sm max-w-none !whitespace-normal mt-6"
+				>
 					<div v-if="lesson.data.youtube">
 						<iframe
 							class="youtube-video"
diff --git a/frontend/src/pages/Statistics.vue b/frontend/src/pages/Statistics.vue
index 53065e03..3575d959 100644
--- a/frontend/src/pages/Statistics.vue
+++ b/frontend/src/pages/Statistics.vue
@@ -79,7 +79,6 @@
 <script setup>
 import { createResource, Breadcrumbs } from 'frappe-ui'
 import { computed, inject } from 'vue'
-import { Line } from 'vue-chartjs'
 import {
 	BookOpen,
 	LogIn,
diff --git a/lms/lms/utils.py b/lms/lms/utils.py
index 1db1d675..fd4b27e5 100644
--- a/lms/lms/utils.py
+++ b/lms/lms/utils.py
@@ -1619,7 +1619,17 @@ def get_batch_students(batch):
 
 
 @frappe.whitelist()
-def get_discussion_topics(doctype, docname):
+def get_discussion_topics(doctype, docname, single_thread):
+	if single_thread:
+		filters = {
+			"reference_doctype": doctype,
+			"reference_docname": docname,
+		}
+		topic = frappe.db.exists("Discussion Topic", filters)
+		if topic:
+			return frappe.db.get_value("Discussion Topic", topic, ["name"], as_dict=1)
+		else:
+			return create_discussion_topic(doctype, docname)
 	topics = frappe.get_all(
 		"Discussion Topic",
 		{
@@ -1638,6 +1648,18 @@ def get_discussion_topics(doctype, docname):
 	return topics
 
 
+def create_discussion_topic(doctype, docname):
+	doc = frappe.new_doc("Discussion Topic")
+	doc.update(
+		{
+			"reference_doctype": doctype,
+			"reference_docname": docname,
+		}
+	)
+	doc.insert()
+	return doc
+
+
 @frappe.whitelist()
 def get_discussion_replies(topic):
 	replies = frappe.get_all(
diff --git a/lms/patches.txt b/lms/patches.txt
index 85d1485c..e0b2caf6 100644
--- a/lms/patches.txt
+++ b/lms/patches.txt
@@ -82,4 +82,5 @@ lms.patches.v1_0.create_batch_source
 [post_model_sync]
 lms.patches.v1_0.batch_tabs_settings
 execute:frappe.delete_doc("Notification", "Assignment Submission Notification")
-lms.patches.v1_0.change_jobs_url #17-01-2024
\ No newline at end of file
+lms.patches.v1_0.change_jobs_url #17-01-2024
+lms.patches.v1_0.custom_perm_for_discussions #14-01-2024
\ No newline at end of file
diff --git a/lms/patches/v1_0/custom_perm_for_discussions.py b/lms/patches/v1_0/custom_perm_for_discussions.py
new file mode 100644
index 00000000..29efadce
--- /dev/null
+++ b/lms/patches/v1_0/custom_perm_for_discussions.py
@@ -0,0 +1,42 @@
+import frappe
+
+
+def execute():
+	roles = ["LMS Student", "Moderator", "Course Creator", "Class Evaluator"]
+	for role in roles:
+		add_perm_for_discussion_topic(role)
+		add_perm_for_discussion_reply(role)
+
+
+def add_perm_for_discussion_topic(role):
+	topic_roles = frappe.permissions.get_doctype_roles("Discussion Topic")
+	if role in topic_roles:
+		return
+
+	topic_perm = frappe.new_doc("Custom DocPerm")
+	topic_perm.parent = "Discussion Topic"
+	topic_perm.role = role
+	topic_perm.if_owner = 1
+	topic_perm.read = 1
+	topic_perm.write = 1
+	topic_perm.create = 1
+	topic_perm.delete = 1
+	topic_perm.insert()
+	frappe.db.commit()
+
+
+def add_perm_for_discussion_reply(role):
+	reply_roles = frappe.permissions.get_doctype_roles("Discussion Reply")
+	if role in reply_roles:
+		return
+
+	reply_perm = frappe.new_doc("Custom DocPerm")
+	reply_perm.parent = "Discussion Reply"
+	reply_perm.role = role
+	reply_perm.if_owner = 1
+	reply_perm.read = 1
+	reply_perm.write = 1
+	reply_perm.create = 1
+	reply_perm.delete = 1
+	reply_perm.insert()
+	frappe.db.commit()