From 242ba89b95f899d2f5d7f4876693f36c4eefe5ab Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Wed, 4 May 2022 19:10:40 +0530
Subject: [PATCH] fix: course card cleanup

---
 lms/lms/widgets/Reviews.html | 18 +++++++++---------
 lms/www/courses/course.html  |  9 ++++-----
 2 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/lms/lms/widgets/Reviews.html b/lms/lms/widgets/Reviews.html
index 9b9cb430..b91ce99f 100644
--- a/lms/lms/widgets/Reviews.html
+++ b/lms/lms/widgets/Reviews.html
@@ -60,21 +60,21 @@
 
         <div>
           <div class="d-flex align-items-center">
-            <a class="button-links mr-2" href="{{get_profile_url(review.owner_details.username) }}">
+            <a class="button-links mr-4" href="{{get_profile_url(review.owner_details.username) }}">
               <span class="bold-heading">
                 {{ review.owner_details.full_name }}
               </span>
             </a>
-            <div class="rating">
-              {% for i in [1, 2, 3, 4, 5] %}
-              <svg class="icon icon-md {% if i <= review.rating %} star-click {% endif %}" data-rating="{{ i }}">
-                <use href="#icon-star"></use>
-              </svg>
-              {% endfor %}
-            </div>
+          <div class="frappe-timestamp course-meta" data-timestamp="{{ review.creation }}"> frappe.utils.pretty_date(review.creation) </div>
           </div>
 
-          <div class="frappe-timestamp course-meta" data-timestamp="{{ review.creation }}"> frappe.utils.pretty_date(review.creation) </div>
+          <div class="rating">
+            {% for i in [1, 2, 3, 4, 5] %}
+            <svg class="icon icon-md {% if i <= review.rating %} star-click {% endif %}" data-rating="{{ i }}">
+              <use href="#icon-star"></use>
+            </svg>
+            {% endfor %}
+          </div>
         </div>
       </div>
 
diff --git a/lms/www/courses/course.html b/lms/www/courses/course.html
index 25d48373..f67ebe93 100644
--- a/lms/www/courses/course.html
+++ b/lms/www/courses/course.html
@@ -49,7 +49,7 @@
 
 {% macro CourseCardWide(course) %}
 <div class="">
-  <div class="d-flex align-items-center">
+  <div class="d-flex align-items-center mt-2">
     {% for tag in get_tags(course.name) %}
     <div class="course-card-pills">{{ tag }}</div>
     {% endfor %}
@@ -70,7 +70,7 @@
   </div>
   {% endif %}
 
-  <div class="mt-3">
+  <div class="mt-6">
     <div class="bold-heading">Instructors:</div>
     {% for instructor in get_instructors(course.name) %}
       <div class="mt-1">
@@ -94,7 +94,7 @@
   {% endif %}
 
   <div class="course-overlay-content">
-    <div class="course-home-headings"> {{ course.title }} </div>
+    <div class="course-card-wide-title mb-4"> {{ course.title }} </div>
 
     <div id="interest-alert" class="{% if not is_user_interested %} hide {% endif %}">
         {{ _("You have opted to be notified for this course. You will receive an email when the course becomes available.") }}
@@ -111,8 +111,7 @@
         {{ _("Your course is currently under review. Once the review is complete, the System Admins will publish it on the website.") }}
     </div>
     {% endif %}
-
-    {% if no_of_attempts >= course.max_attempts %}
+    {% if no_of_attempts and no_of_attempts >= course.max_attempts %}
     <p> {{ _("You have exceeded the maximum number of attempts allowed to appear for evaluations of this course.") }} </p>
     {% endif %}