fix: course is no longer mandatory to generate a certificate

This commit is contained in:
Jannat Patel
2025-01-16 12:35:13 +05:30
parent b4c7338b76
commit 27ae014fcb
5 changed files with 57 additions and 52 deletions

View File

@@ -407,17 +407,6 @@ def get_assigned_badges(member):
return assigned_badges
@frappe.whitelist()
def get_certificates(member):
"""Get certificates for a member."""
return frappe.get_all(
"LMS Certificate",
filters={"member": member},
fields=["name", "course", "course_title", "issue_date", "template"],
order_by="creation desc",
)
@frappe.whitelist()
def get_all_users():
users = frappe.get_all(

View File

@@ -1,25 +1,27 @@
{
"actions": [],
"allow_import": 1,
"autoname": "hash",
"creation": "2021-08-16 15:47:19.494055",
"doctype": "DocType",
"editable_grid": 1,
"engine": "InnoDB",
"field_order": [
"course",
"course_title",
"member",
"member_name",
"column_break_vwbn",
"issue_date",
"template",
"published",
"section_break_scyf",
"evaluator",
"evaluator_name",
"column_break_slaw",
"column_break_vwbn",
"issue_date",
"expiry_date",
"batch_name"
"template",
"published",
"section_break_unwn",
"course",
"course_title",
"column_break_ywee",
"batch_name",
"batch_title"
],
"fields": [
{
@@ -32,7 +34,6 @@
{
"fieldname": "course",
"fieldtype": "Link",
"in_list_view": 1,
"in_standard_filter": 1,
"label": "Course",
"options": "LMS Course"
@@ -45,7 +46,6 @@
{
"fieldname": "member",
"fieldtype": "Link",
"in_list_view": 1,
"in_standard_filter": 1,
"label": "Member",
"options": "User",
@@ -55,6 +55,8 @@
"fetch_from": "member.full_name",
"fieldname": "member_name",
"fieldtype": "Data",
"in_list_view": 1,
"in_standard_filter": 1,
"label": "Member Name",
"read_only": 1
},
@@ -89,14 +91,6 @@
"fieldname": "column_break_vwbn",
"fieldtype": "Column Break"
},
{
"fieldname": "section_break_scyf",
"fieldtype": "Section Break"
},
{
"fieldname": "column_break_slaw",
"fieldtype": "Column Break"
},
{
"fieldname": "evaluator",
"fieldtype": "Link",
@@ -107,16 +101,33 @@
"fetch_from": "evaluator.full_name",
"fieldname": "evaluator_name",
"fieldtype": "Data",
"in_list_view": 1,
"label": "Evaluator Name",
"read_only": 1
},
{
"fieldname": "section_break_unwn",
"fieldtype": "Section Break"
},
{
"fieldname": "column_break_ywee",
"fieldtype": "Column Break"
},
{
"fetch_from": "batch_name.title",
"fieldname": "batch_title",
"fieldtype": "Data",
"label": "Batch Title",
"read_only": 1
}
],
"index_web_pages_for_search": 1,
"links": [],
"modified": "2025-01-16 11:42:51.449506",
"modified": "2025-01-16 12:12:49.998114",
"modified_by": "Administrator",
"module": "LMS",
"name": "LMS Certificate",
"naming_rule": "Random",
"owner": "Administrator",
"permissions": [
{

View File

@@ -1889,7 +1889,6 @@ def get_batches(filters=None, start=0, page_length=20, order_by="start_date"):
page_length=page_length,
)
print(batches)
batchType = get_batch_type(filters)
if batchType == "upcoming":
batches_to_remove = list(
@@ -1899,7 +1898,6 @@ def get_batches(filters=None, start=0, page_length=20, order_by="start_date"):
batches,
)
)
print(batches_to_remove)
batches = [batch for batch in batches if batch not in batches_to_remove]
elif batchType == "archived":
batches_to_remove = list(