From 17b59ce4e56968adbdf7e65bd5d9441f5f082bd5 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 16 Jan 2025 16:39:48 +0530
Subject: [PATCH 1/2] refactor: improved ui and performance for certified
 participants page

---
 frontend/src/pages/Batches.vue               |   4 +-
 frontend/src/pages/CertifiedParticipants.vue | 208 +++++++++++++------
 lms/lms/api.py                               |  67 ++++--
 3 files changed, 192 insertions(+), 87 deletions(-)

diff --git a/frontend/src/pages/Batches.vue b/frontend/src/pages/Batches.vue
index e68e6179..bd8291d7 100644
--- a/frontend/src/pages/Batches.vue
+++ b/frontend/src/pages/Batches.vue
@@ -68,8 +68,8 @@
 			v-else-if="!batches.list.loading"
 			class="flex flex-col items-center justify-center text-sm text-gray-600 italic mt-48"
 		>
-			<BookOpen class="size-10 mx-auto stroke-1.5 text-gray-500" />
-			<div class="text-xl font-medium mb-2">
+			<BookOpen class="size-10 mx-auto stroke-1 text-gray-500" />
+			<div class="text-lg font-medium mb-1">
 				{{ __('No batches found') }}
 			</div>
 			<div class="leading-5 w-2/5 text-center">
diff --git a/frontend/src/pages/CertifiedParticipants.vue b/frontend/src/pages/CertifiedParticipants.vue
index 8351eb20..61c87ff5 100644
--- a/frontend/src/pages/CertifiedParticipants.vue
+++ b/frontend/src/pages/CertifiedParticipants.vue
@@ -1,93 +1,173 @@
 <template>
 	<header
-		class="sticky top-0 z-10 flex items-center justify-between border-b bg-white px-3 py-2.5 sm:px-5"
+		class="sticky flex items-center justify-between top-0 z-10 border-b bg-white px-3 py-2.5 sm:px-5"
 	>
 		<Breadcrumbs :items="breadcrumbs" />
-		<div>
-			<FormControl
-				type="text"
-				placeholder="Search"
-				v-model="searchQuery"
-				@input="participants.reload()"
-				class="w-40"
-			>
-				<template #prefix>
-					<Search class="w-4 stroke-1.5 text-gray-600" name="search" />
-				</template>
-			</FormControl>
-		</div>
 	</header>
-
-	<div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-4 m-5">
-		<div
-			v-if="participants.data?.length"
-			v-for="participant in participantsList"
-		>
-			<router-link
-				:to="{
-					name: 'Profile',
-					params: { username: participant.username },
-				}"
-			>
-				<div class="flex shadow rounded-md h-full p-2">
-					<UserAvatar :user="participant" size="3xl" class="mr-2" />
-					<div>
-						<router-link
-							:to="{
-								name: 'Profile',
-								params: { username: participant.username },
-							}"
-						>
-							<div class="text-lg font-semibold mb-2">
+	<div class="px-5 py-10 w-3/4 mx-auto">
+		<div class="flex items-center justify-between mb-5">
+			<div class="text-lg font-semibold">
+				{{ __('All Certified Participants') }}
+			</div>
+			<div class="flex items-center space-x-2">
+				<FormControl
+					v-model="nameFilter"
+					:placeholder="__('Search by Name')"
+					type="text"
+					class="min-w-40 lg:min-w-0 lg:w-32 xl:w-40"
+					@input="updateParticipants()"
+				/>
+				<div
+					v-if="categories.data?.length"
+					class="min-w-40 lg:min-w-0 lg:w-32 xl:w-40"
+				>
+					<Select
+						v-model="currentCategory"
+						:options="categories.data"
+						:placeholder="__('Category')"
+						@change="updateParticipants()"
+					/>
+				</div>
+			</div>
+		</div>
+		<div v-if="participants.data?.length">
+			<div class="grid grid-cols-3 gap-5">
+				<router-link
+					v-for="participant in participants.data"
+					:to="{
+						name: 'ProfileCertificates',
+						params: { username: participant.username },
+					}"
+				>
+					<div
+						class="flex items-center space-x-2 border rounded-md hover:bg-gray-50 p-2"
+					>
+						<Avatar
+							:image="participant.user_image"
+							:label="participant.full_name"
+							size="2xl"
+						/>
+						<div class="flex flex-col space-y-2">
+							<div class="font-medium">
 								{{ participant.full_name }}
 							</div>
-						</router-link>
-						<div class="leading-5" v-for="course in participant.courses">
-							{{ course }}
+							<div
+								v-if="participant.headline"
+								class="headline text-sm text-gray-700"
+							>
+								{{ participant.headline }}
+							</div>
 						</div>
 					</div>
-				</div>
-			</router-link>
+				</router-link>
+			</div>
+			<div
+				v-if="!participants.list.loading && participants.hasNextPage"
+				class="flex justify-center mt-5"
+			>
+				<Button @click="participants.next()">
+					{{ __('Load More') }}
+				</Button>
+			</div>
+		</div>
+		<div
+			v-else-if="!participants.list.loading"
+			class="flex flex-col items-center justify-center text-sm text-gray-600 italic mt-48"
+		>
+			<BookOpen class="size-10 mx-auto stroke-1 text-gray-500" />
+			<div class="text-lg font-medium mb-1">
+				{{ __('No participants found') }}
+			</div>
+			<div class="leading-5 w-2/5 text-center">
+				{{ __('There are no participants matching this criteria.') }}
+			</div>
 		</div>
 	</div>
 </template>
 <script setup>
-import { Breadcrumbs, FormControl, createResource } from 'frappe-ui'
-import { ref, computed } from 'vue'
-import UserAvatar from '@/components/UserAvatar.vue'
-import { Search } from 'lucide-vue-next'
+import {
+	Avatar,
+	Breadcrumbs,
+	Button,
+	createListResource,
+	FormControl,
+	Select,
+} from 'frappe-ui'
+import { computed, onMounted, ref } from 'vue'
 import { updateDocumentTitle } from '@/utils'
+import { BookOpen } from 'lucide-vue-next'
 
-const searchQuery = ref('')
+const currentCategory = ref('')
+const filters = ref({})
+const nameFilter = ref('')
 
-const participants = createResource({
+onMounted(() => {
+	updateParticipants()
+})
+
+const participants = createListResource({
+	doctype: 'LMS Certificate',
 	url: 'lms.lms.api.get_certified_participants',
-	method: 'GET',
-	cache: 'certified-participants',
-	auto: true,
+	cache: ['certified_participants'],
+	start: 0,
+	pageLength: 30,
 })
 
-const breadcrumbs = computed(() => {
-	return [{ label: 'Certified Participants', to: '/certified-participants' }]
+const categories = createListResource({
+	doctype: 'LMS Certificate',
+	url: 'lms.lms.api.get_certification_categories',
+	cache: ['certification_categories'],
+	auto: true,
+	transform(data) {
+		data.unshift({ label: __(''), value: '' })
+		return data
+	},
 })
 
+const updateParticipants = () => {
+	updateFilters()
+	participants.update({
+		filters: filters.value,
+	})
+	participants.reload()
+}
+
+const updateFilters = () => {
+	if (currentCategory.value) {
+		filters.value.category = currentCategory.value
+	} else {
+		delete filters.value.category
+	}
+
+	if (nameFilter.value) {
+		filters.value.member_name = ['like', `%${nameFilter.value}%`]
+	} else {
+		delete filters.value.member_name
+	}
+}
+
+const breadcrumbs = computed(() => [
+	{
+		label: __('Certified Participants'),
+		route: { name: 'CertifiedParticipants' },
+	},
+])
+
 const pageMeta = computed(() => {
 	return {
 		title: 'Certified Participants',
 		description: 'All participants that have been certified.',
 	}
 })
-
-const participantsList = computed(() => {
-	if (searchQuery.value) {
-		return participants.data.filter((participant) => {
-			return participant.full_name
-				.toLowerCase()
-				.includes(searchQuery.value.toLowerCase())
-		})
-	}
-	return participants.data
-})
-
 updateDocumentTitle(pageMeta)
 </script>
+<style>
+.headline {
+	display: -webkit-box;
+	-webkit-line-clamp: 1;
+	-webkit-box-orient: vertical;
+	text-overflow: ellipsis;
+	width: 100%;
+	overflow: hidden;
+}
+</style>
diff --git a/lms/lms/api.py b/lms/lms/api.py
index b989981a..ff51a652 100644
--- a/lms/lms/api.py
+++ b/lms/lms/api.py
@@ -361,34 +361,59 @@ def get_evaluator_details(evaluator):
 
 
 @frappe.whitelist(allow_guest=True)
-def get_certified_participants():
-	LMSCertificate = DocType("LMS Certificate")
-	participants = (
-		frappe.qb.from_(LMSCertificate)
-		.select(LMSCertificate.member)
-		.distinct()
-		.where(LMSCertificate.published == 1)
-		.orderby(LMSCertificate.creation, order=frappe.qb.desc)
-		.run(as_dict=1)
+def get_certified_participants(filters=None, start=0, page_length=30, search=None):
+	or_filters = {}
+	if not filters:
+		filters = {}
+
+	filters.update({"published": 1})
+
+	category = filters.get("category")
+	if category:
+		del filters["category"]
+		or_filters["course_title"] = ["like", f"%{category}%"]
+		or_filters["batch_title"] = ["like", f"%{category}%"]
+
+	participants = frappe.get_all(
+		"LMS Certificate",
+		filters=filters,
+		or_filters=or_filters,
+		fields=["member"],
+		group_by="member",
+		order_by="creation desc",
+		start=start,
+		page_length=page_length,
 	)
 
-	participant_details = []
 	for participant in participants:
 		details = frappe.db.get_value(
 			"User",
 			participant.member,
-			["name", "full_name", "username", "user_image"],
-			as_dict=True,
+			["full_name", "user_image", "username", "country", "headline"],
+			as_dict=1,
 		)
-		course_names = frappe.get_all(
-			"LMS Certificate", {"member": participant.member}, pluck="course"
-		)
-		courses = []
-		for course in course_names:
-			courses.append(frappe.db.get_value("LMS Course", course, "title"))
-		details["courses"] = courses
-		participant_details.append(details)
-	return participant_details
+		participant.update(details)
+
+	return participants
+
+
+@frappe.whitelist()
+def get_certification_categories():
+	categories = []
+	docs = frappe.get_all(
+		"LMS Certificate",
+		filters={
+			"published": 1,
+		},
+		fields=["course_title", "batch_title"],
+	)
+
+	for doc in docs:
+		category = doc.course_title if doc.course_title else doc.batch_title
+		if category not in categories:
+			categories.append(category)
+
+	return categories
 
 
 @frappe.whitelist()

From bd43ed0e887e9d4601d8fed79b98c8fbc0ae4504 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 16 Jan 2025 16:49:03 +0530
Subject: [PATCH 2/2] fix: responsive design for certified participants page

---
 frontend/src/pages/CertifiedParticipants.vue | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/frontend/src/pages/CertifiedParticipants.vue b/frontend/src/pages/CertifiedParticipants.vue
index 61c87ff5..78c18a7a 100644
--- a/frontend/src/pages/CertifiedParticipants.vue
+++ b/frontend/src/pages/CertifiedParticipants.vue
@@ -4,12 +4,14 @@
 	>
 		<Breadcrumbs :items="breadcrumbs" />
 	</header>
-	<div class="px-5 py-10 w-3/4 mx-auto">
-		<div class="flex items-center justify-between mb-5">
+	<div class="p-5 lg:w-3/4 mx-auto">
+		<div
+			class="flex flex-col lg:flex-row lg:items-center space-y-4 lg:space-y-0 justify-between mb-5"
+		>
 			<div class="text-lg font-semibold">
 				{{ __('All Certified Participants') }}
 			</div>
-			<div class="flex items-center space-x-2">
+			<div class="grid grid-cols-2 gap-2">
 				<FormControl
 					v-model="nameFilter"
 					:placeholder="__('Search by Name')"
@@ -31,7 +33,7 @@
 			</div>
 		</div>
 		<div v-if="participants.data?.length">
-			<div class="grid grid-cols-3 gap-5">
+			<div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-5">
 				<router-link
 					v-for="participant in participants.data"
 					:to="{