From 29fe75d807dde411ad4ab9e2e3c4b887e20ea541 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 20 Sep 2021 15:12:23 +0530 Subject: [PATCH] fix: regex in page renderer --- community/page_renderers.py | 5 ++--- community/www/profiles/profile.py | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/community/page_renderers.py b/community/page_renderers.py index 4567d106..226501ae 100644 --- a/community/page_renderers.py +++ b/community/page_renderers.py @@ -31,7 +31,7 @@ def get_profile_url_prefix(): hooks = frappe.get_hooks("profile_url_prefix") or ["/users/"] return hooks[-1] -RE_USERNAME = re.compile("[a-zA-Z0-9_]{4,}") +RE_INVALID_USERNAME = re.compile("[@!#$%^&*()<>?/\\|}{~:-]") class ProfileRedirectPage(BaseRenderer): """Renderer to redirect /profile_/foo to /foo. @@ -63,9 +63,8 @@ class ProfilePage(BaseRenderer): # not a userpage? username = self.get_username() - if not RE_USERNAME.match(username): + if RE_INVALID_USERNAME.search(username): return False - # if there is prefix then we can allow all usernames if prefix: return True diff --git a/community/www/profiles/profile.py b/community/www/profiles/profile.py index 25d8254a..65b1bbca 100644 --- a/community/www/profiles/profile.py +++ b/community/www/profiles/profile.py @@ -10,7 +10,6 @@ def get_context(context): except KeyError: username = frappe.db.get_value("User", frappe.session.user, ["username"]) if username: - print(username) frappe.local.flags.redirect_location = get_profile_url_prefix() + urlencode({"username": username}) raise frappe.Redirect try: @@ -18,7 +17,6 @@ def get_context(context): except: context.template = "www/404.html" return - print(context.member) context.profile_tabs = get_profile_tabs(context.member) def get_profile_tabs(user):