diff --git a/frontend/src/components/Modals/EvaluationModal.vue b/frontend/src/components/Modals/EvaluationModal.vue index 201e4d94..cfef41ea 100644 --- a/frontend/src/components/Modals/EvaluationModal.vue +++ b/frontend/src/components/Modals/EvaluationModal.vue @@ -154,10 +154,12 @@ function submitEvaluation(close) { const getCourses = () => { let courses = [] for (const course of props.courses) { - courses.push({ - label: course.title, - value: course.course, - }) + if (course.evaluator) { + courses.push({ + label: course.title, + value: course.course, + }) + } } return courses } diff --git a/lms/lms/utils.py b/lms/lms/utils.py index 89ceda48..d43e90af 100644 --- a/lms/lms/utils.py +++ b/lms/lms/utils.py @@ -1103,7 +1103,7 @@ def get_categorized_courses(courses): categories = [live, enrolled, created] for category in categories: - category.sort(key=lambda x: x.enrollments, reverse=True) + category.sort(key=lambda x: cint(x.enrollments), reverse=True) live.sort(key=lambda x: x.featured, reverse=True) @@ -1265,7 +1265,7 @@ def get_batch_details(batch): batch_details.instructors = get_instructors(batch) batch_details.courses = frappe.get_all( - "Batch Course", filters={"parent": batch}, fields=["course", "title"] + "Batch Course", filters={"parent": batch}, fields=["course", "title", "evaluator"] ) batch_details.students = frappe.get_all( "Batch Student", {"parent": batch}, pluck="student"