From 2ecb93e925f692bf9f2313c0693e79fb4f7f16a2 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Fri, 10 Jan 2025 19:05:59 +0530
Subject: [PATCH] feat: show submitted feedback as readonly

---
 frontend/src/components/BatchFeedback.vue     | 94 +++++++++++++++----
 frontend/src/components/JobCard.vue           |  2 +-
 .../lms_batch_feedback.json                   | 14 ++-
 3 files changed, 92 insertions(+), 18 deletions(-)

diff --git a/frontend/src/components/BatchFeedback.vue b/frontend/src/components/BatchFeedback.vue
index 94d45447..93eca9e6 100644
--- a/frontend/src/components/BatchFeedback.vue
+++ b/frontend/src/components/BatchFeedback.vue
@@ -1,25 +1,59 @@
 <template>
-	<div v-if="feedbackList.data"></div>
-	<div v-else class="space-y-8">
-		<div class="grid grid-cols-4 gap-5">
-			<Rating v-model="feedback.content" :label="__('Content')" />
-			<Rating v-model="feedback.delivery" :label="__('Delivery')" />
-			<Rating v-model="feedback.instructors" :label="__('Instructors')" />
-			<Rating v-model="feedback.value" :label="__('Value')" />
+	<div>
+		<div
+			v-if="feedbackList.data?.length"
+			class="bg-blue-100 text-blue-700 p-2 rounded-md mb-5"
+		>
+			{{ __('Thank you for providing your feedback!') }}
+		</div>
+		<div v-else class="flex justify-between items-center mb-5">
+			<div class="text-lg font-semibold">
+				{{ __('Help Us Improve') }}
+			</div>
+			<Button @click="submitFeedback()">
+				{{ __('Submit') }}
+			</Button>
+		</div>
+		<div class="space-y-8">
+			<div class="grid grid-cols-4 gap-5">
+				<Rating
+					v-model="feedback.content"
+					:label="__('Content')"
+					:readonly="readOnly"
+				/>
+				<Rating
+					v-model="feedback.delivery"
+					:label="__('Delivery')"
+					:readonly="readOnly"
+				/>
+				<Rating
+					v-model="feedback.instructors"
+					:label="__('Instructors')"
+					:readonly="readOnly"
+				/>
+				<Rating
+					v-model="feedback.value"
+					:label="__('Value')"
+					:readonly="readOnly"
+				/>
+			</div>
+			<FormControl
+				v-model="feedback.feedback"
+				type="textarea"
+				:label="__('Feedback')"
+				:rows="7"
+				:readonly="readOnly"
+			/>
 		</div>
-		<FormControl
-			v-model="feedback.feedback"
-			type="textarea"
-			:label="__('Feedback')"
-			rows="7"
-		/>
 	</div>
 </template>
-<script setup lang="ts">
-import { inject, reactive } from 'vue'
-import { createListResource, FormControl, Rating } from 'frappe-ui'
+<script setup>
+import { inject, reactive, ref } from 'vue'
+import { Button, createListResource, FormControl, Rating } from 'frappe-ui'
 
 const user = inject('$user')
+const ratingKeys = ['content', 'delivery', 'instructors', 'value']
+const readOnly = ref(false)
 const feedback = reactive({
 	content: 0,
 	delivery: 0,
@@ -41,7 +75,35 @@ const feedbackList = createListResource({
 		batch: props.batch,
 		member: user.data?.name,
 	},
+	fields: ['content', 'delivery', 'instructors', 'value', 'feedback', 'name'],
 	cache: ['feedbackList', props.batch, user.data?.name],
 	auto: true,
+	onSuccess(data) {
+		if (data.length) {
+			readOnly.value = true
+			Object.keys(feedback).forEach((key) => {
+				if (ratingKeys.includes(key)) feedback[key] = data[0][key] * 5
+				else feedback[key] = data[0][key]
+			})
+		}
+	},
 })
+
+const submitFeedback = () => {
+	ratingKeys.forEach((key) => {
+		feedback[key] = feedback[key] / 5
+	})
+	feedbackList.insert.submit(
+		{
+			member: user.data?.name,
+			batch: props.batch,
+			...feedback,
+		},
+		{
+			onSuccess: () => {
+				feedbackList.reload()
+			},
+		}
+	)
+}
 </script>
diff --git a/frontend/src/components/JobCard.vue b/frontend/src/components/JobCard.vue
index e59978f8..a67e69cf 100644
--- a/frontend/src/components/JobCard.vue
+++ b/frontend/src/components/JobCard.vue
@@ -1,5 +1,5 @@
 <template>
-	<div class="flex rounded p-1 lg:px-2 lg:py-2.5 hover:bg-gray-100">
+	<div class="flex rounded p-1 lg:px-2 lg:py-4 hover:bg-gray-100">
 		<div class="flex w-3/5 md:w-2/5">
 			<img
 				:src="job.company_logo"
diff --git a/lms/lms/doctype/lms_batch_feedback/lms_batch_feedback.json b/lms/lms/doctype/lms_batch_feedback/lms_batch_feedback.json
index 4609fc2f..5703eae4 100644
--- a/lms/lms/doctype/lms_batch_feedback/lms_batch_feedback.json
+++ b/lms/lms/doctype/lms_batch_feedback/lms_batch_feedback.json
@@ -65,7 +65,7 @@
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2025-01-07 18:56:38.800575",
+ "modified": "2025-01-10 17:25:25.482724",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Batch Feedback",
@@ -82,6 +82,18 @@
    "role": "System Manager",
    "share": 1,
    "write": 1
+  },
+  {
+   "create": 1,
+   "email": 1,
+   "export": 1,
+   "if_owner": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "LMS Student",
+   "share": 1,
+   "write": 1
   }
  ],
  "sort_field": "creation",