eduvia/lms
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: show students/mentors on subgroup page alphabetically

Browse Source 
Issue #271
This commit is contained in:
Anand Chitipothu
2021-12-05 01:33:33 +05:30
parent f68fc02e57
commit 2f994628c3
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
school/lms/doctype/cohort_subgroup/cohort_subgroup.py
View File

@@ -47,7 +47,7 @@ class CohortSubgroup(Document):
def get_mentors(self): def get_mentors(self):
emails = frappe.get_all("Cohort Mentor", filters={"subgroup": self.name}, fields=["email"], pluck='email') emails = frappe.get_all("Cohort Mentor", filters={"subgroup": self.name}, fields=["email"], pluck='email')
return [frappe.get_cached_doc("User", email) for email in emails] return self._get_users(emails)
def get_students(self): def get_students(self):
emails = frappe.get_all("LMS Batch Membership", emails = frappe.get_all("LMS Batch Membership",
@@ -55,8 +55,11 @@ class CohortSubgroup(Document):
fields=["member"], fields=["member"],
pluck='member', pluck='member',
page_length=1000) page_length=1000)
return self._get_users(emails)
return [frappe.get_cached_doc("User", email) for email in emails] def _get_users(self, emails):
users = [frappe.get_cached_doc("User", email) for email in emails]
return sorted(users, key=lambda user: user.full_name)
def is_mentor(self, email): def is_mentor(self, email):
q = { q = {