fix: batch switch with query parameters

community/lms/doctype/lms_batch/lms_batch.py

@@ -19,7 +19,7 @@ class LMSBatch(Document):
            frappe.throw(_("You are not a mentor of the course {0}").format(course.title))
 
     def after_insert(self):
-        create_membership(batch=self.name, member_type="Mentor")
+        create_membership(batch=self.name, course=self.course, member_type="Mentor")
 
     def is_member(self, email, member_type=None):
         """Checks if a person is part of a batch.

community/lms/doctype/lms_batch_membership/lms_batch_membership.json

@@ -13,8 +13,7 @@
   "course",
   "member_type",
   "role",
-  "current_lesson",
-  "is_current"
+  "current_lesson"
  ],
  "fields": [
   {
@@ -81,19 +80,11 @@
    "fieldtype": "Data",
    "label": "Memeber Username",
    "read_only": 1
-  },
-  {
-   "default": "0",
-   "fieldname": "is_current",
-   "fieldtype": "Check",
-   "hidden": 1,
-   "label": "Is Currently Being Used",
-   "read_only": 1
   }
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2021-06-14 10:24:35.425498",
+ "modified": "2021-06-21 12:10:28.808803",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Batch Membership",

community/lms/doctype/lms_batch_membership/lms_batch_membership.py

@@ -14,18 +14,22 @@ class LMSBatchMembership(Document):
         self.validate_membership_in_different_batch_same_course()
 
     def validate_membership_in_same_batch(self):
+        filters={
+            "member": self.member,
+            "course": self.course,
+            "name": ["!=", self.name]
+        }
+        if self.batch:
+            filters["batch"] = self.batch
         previous_membership = frappe.db.get_value("LMS Batch Membership",
-            filters={
-                "member": self.member,
-                "batch": self.batch,
-                "name": ["!=", self.name]
-            },
+            filters,
             fieldname=["member_type","member"],
             as_dict=1)
 
         if previous_membership:
             member_name = frappe.db.get_value("User", self.member, "full_name")
-            frappe.throw(_("{0} is already a {1} of {2}").format(member_name, previous_membership.member_type, self.batch))
+            course_title = frappe.db.get_value("LMS Course", self.course, "title")
+            frappe.throw(_("{0} is already a {1} of the course {2}").format(member_name, previous_membership.member_type, course_title))
 
     def validate_membership_in_different_batch_same_course(self):
         course = frappe.db.get_value("LMS Batch", self.batch, "course")

community/lms/doctype/lms_course/lms_course.json

@@ -22,6 +22,7 @@
  "field_order": [
   "title",
   "is_published",
+  "disable_self_learning",
   "column_break_3",
   "short_code",
   "video_link",
@@ -73,6 +74,12 @@
    "fieldtype": "Small Text",
    "label": "Short Introduction",
    "reqd": 1
+  },
+  {
+   "default": "0",
+   "fieldname": "disable_self_learning",
+   "fieldtype": "Check",
+   "label": "Disable Self Learning"
   }
  ],
  "index_web_pages_for_search": 1,
@@ -99,7 +106,7 @@
    "link_fieldname": "course"
   }
  ],
- "modified": "2021-06-01 04:36:45.696776",
+ "modified": "2021-06-21 11:34:04.552376",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Course",

community/lms/doctype/lms_course/lms_course.py

@@ -192,16 +192,17 @@ class LMSCourse(Document):
             return
         return f"/courses/{self.name}/learn/{lesson_number}"
 
-    def get_current_membership(self, member):
-        current_membership = frappe.get_all("LMS Batch Membership", {"member": member, "course": self.name, "is_current": 1}, ["name", "batch"])
-        if len(current_membership):
-            return current_membership[0]
-        return frappe.db.get_value("LMS Batch Membership", {"member": member, "course": self.name}, ["name","batch"], as_dict=True)
+    def get_membership(self, member, batch):
+        filters = {
+            "member": member,
+            "course": self.name
+        }
+        if batch:
+            filters["batch"] = batch
+        return frappe.db.get_value("LMS Batch Membership", filters, ["name","batch", "current_lesson"], as_dict=True)
 
     def get_all_memberships(self, member=frappe.session.user):
-        print(member, frappe.session.user)
-        all_memberships = frappe.get_all("LMS Batch Membership", {"member": member, "course": self.name}, ["batch", "is_current"])
-        print(all_memberships)
+        all_memberships = frappe.get_all("LMS Batch Membership", {"member": member, "course": self.name}, ["batch"])
         for membership in all_memberships:
             membership.batch_title = frappe.db.get_value("LMS Batch", membership.batch, "title")
         return all_memberships
@@ -214,7 +215,6 @@ class LMSCourse(Document):
         if batch:
             filters["batch"] = batch
 
-        print(filters)
         memberships = frappe.get_all(
                     "LMS Batch Membership",
                     filters,

community/lms/widgets/BatchTabs.html

@@ -4,14 +4,14 @@
     {{ course.title }}</span> {% endif %}
   {% set all_memberships = course.get_all_memberships() %}
   {% if all_memberships | length > 1 %}
-    <a class="nav-link pull-right" href="#" id="navbarDropdown" role="button" data-toggle="dropdown" aria-haspopup="true"
+  <a class="nav-link pull-right" href="#" id="navbarDropdown" role="button" data-toggle="dropdown" aria-haspopup="true"
     aria-expanded="false">
     Switch Batch
   </a>
   <div class="dropdown-menu" aria-labelledby="navbarDropdown">
-    {% for membership in all_memberships %}
-    {% if not membership.is_current %}
-    <a class="dropdown-item switch-batch" href="#" data-batch="{{ membership.batch | urlencode }}" data-course="{{ course.name | urlencode }}">{{ membership.batch_title }}</a>
+    {% for data in all_memberships %}
+    {% if data.batch != membership.batch %}
+    <a class="dropdown-item switch-batch" href="/courses/{{ course.name }}/home?batch={{ data.batch }}">{{ data.batch_title }}</a>
     {% endif %}
     {% endfor %}
   </div>
@@ -22,18 +22,21 @@
 {% else %}
 {% set display_class = "" %}
 {% endif %}
+
 <ul class="nav nav-tabs mt-4">
   <li class="nav-item">
-    <a class="nav-link" id="home" href="/courses/{{course.name}}/home">Home</a>
+    <a class="nav-link" id="home" href="/courses/{{course.name}}/home{{ course.query_parameter }}">Home</a>
   </li>
   <li class="nav-item">
-    <a class="nav-link" id="learn" href="/courses/{{course.name}}/learn">Lessons</a>
+    {% set lesson_index = course.get_lesson_index(membership.current_lesson) if membership.current_lesson else '1.1' %}
+    <a class="nav-link" id="learn"
+      href="{{ course.get_learn_url(lesson_index) }}{{ course.query_parameter }}">Lessons</a>
   </li>
   <!-- <li class="nav-item">
     <a class="nav-link" id="schedule" href="/courses/{{course.name}}/schedule">Schedule</a>
   </li> -->
   <li class="nav-item {{ display_class }}">
-    <a class="nav-link" id="members" href="/courses/{{course.name}}/members">Members</a>
+    <a class="nav-link" id="members" href="/courses/{{course.name}}/members{{ course.query_parameter }}">Members</a>
   </li>
   <!-- <li class="nav-item {{ display_class }}">
     <a class="nav-link" id="discussion" href="/courses/{{course.name}}/discuss">Discussion</a>
@@ -41,37 +44,22 @@
   <!-- <li class="nav-item">
     <a class="nav-link" id="about" href="/courses/{{course.name}}/about">About</a>
   </li> -->
-  {% if batch and batch.is_member(frappe.session.user, member_type="Mentor") %}
+  {% if membership.batch and course.is_mentor(frappe.session.user) %}
   <li class="nav-item">
-    <a class="nav-link" id="progress" href="/courses/{{course.name}}/progress">Progress</a>
+    <a class="nav-link" id="progress" href="/courses/{{course.name}}/progress{{ course.query_parameter }}">Progress</a>
   </li>
   {% endif %}
 </ul>
+{% block script %}
 <script>
   frappe.ready(() => {
-    var selector = document.querySelector(`a[href="${decodeURIComponent(window.location.pathname)}"]`)
+    var selector = document.querySelector(`a[href="${decodeURIComponent(window.location.pathname)}{{ course.query_parameter }}"]`)
     if (selector) {
       selector.classList.add('active');
     }
     else {
       $("#learn").addClass('active')
     }
-
-    $(".switch-batch").click((e) => {
-      e.preventDefault();
-      var batch = decodeURIComponent($(e.currentTarget).attr("data-batch"));
-      var course = decodeURIComponent($(e.currentTarget).attr("data-course"));
-      frappe.call({
-        method: "community.lms.doctype.lms_batch_membership.lms_batch_membership.update_current_membership",
-        args: {
-          batch: batch,
-          course: course,
-          member: frappe.session.user
-        },
-        callback: (data) => {
-          window.location.reload();
-        }
-      })
-    })
   })
 </script>
+{% endblock %}

community/lms/widgets/ChapterTeaser.html

@@ -8,7 +8,7 @@
       {% for lesson in chapter.get_lessons() %}
       <div class="lesson-teaser">
         <a {% if show_link or lesson.include_in_preview %}
-          href="{{ course.get_learn_url(course.get_lesson_index(lesson.name)) }}" {% else %} href="" class="no-preview"
+          href="{{ course.get_learn_url(course.get_lesson_index(lesson.name)) }}{{course.query_parameter}}" {% else %} href="" class="no-preview"
           {% endif %} data-course="{{ course.name }}">{{ lesson.title }}</a>
         {% if show_progress and not course.is_mentor(frappe.session.user) and lesson.get_progress() %}
         <span class="ml-5 badge p-2 {{ lesson.get_slugified_class() }}"> {{ lesson.get_progress() }}</span>

community/lms/widgets/RenderBatch.html

@@ -18,7 +18,7 @@
   <div class="cta">
     <div class="">
       {% if can_manage %}
-      <a href="" class="btn btn-primary manage-batch" data-batch="{{ batch.name | urlencode }}"
+      <a href="/courses/{{ course.name }}/home?batch={{ batch.name }}" class="btn btn-primary manage-batch" data-batch="{{ batch.name | urlencode }}"
         data-course="{{ course.name | urlencode }}">Manage</a>
       {% elif can_join %}
       <button class="join-batch btn btn-secondary" data-batch="{{ batch.name | urlencode }}"