From 279bb89ca94226c1d0f531208c7da98eb8f5b314 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Fri, 28 Jun 2024 15:58:35 +0530
Subject: [PATCH 1/2] feat: search courses

---
 frontend/src/components/CourseReviews.vue    |  2 +-
 frontend/src/pages/CertifiedParticipants.vue |  2 +-
 frontend/src/pages/Courses.vue               | 37 ++++++++++++++++----
 lms/lms/utils.py                             |  6 ++--
 4 files changed, 36 insertions(+), 11 deletions(-)

diff --git a/frontend/src/components/CourseReviews.vue b/frontend/src/components/CourseReviews.vue
index 7a386ada..2537531a 100644
--- a/frontend/src/components/CourseReviews.vue
+++ b/frontend/src/components/CourseReviews.vue
@@ -1,5 +1,5 @@
 <template>
-	<div v-if="reviews.data" class="mt-20 mb-10">
+	<div v-if="reviews.data?.length || membership" class="mt-20 mb-10">
 		<Button
 			v-if="membership && !hasReviewed.data"
 			@click="openReviewModal()"
diff --git a/frontend/src/pages/CertifiedParticipants.vue b/frontend/src/pages/CertifiedParticipants.vue
index 3784ef55..77ebcb00 100644
--- a/frontend/src/pages/CertifiedParticipants.vue
+++ b/frontend/src/pages/CertifiedParticipants.vue
@@ -11,7 +11,7 @@
 				@input="participants.reload()"
 			>
 				<template #prefix>
-					<Search class="w-4" name="search" />
+					<Search class="w-4 stroke-1.5 text-gray-600" name="search" />
 				</template>
 			</FormControl>
 		</div>
diff --git a/frontend/src/pages/Courses.vue b/frontend/src/pages/Courses.vue
index ee8f8527..538670f3 100644
--- a/frontend/src/pages/Courses.vue
+++ b/frontend/src/pages/Courses.vue
@@ -7,7 +7,17 @@
 				class="h-7"
 				:items="[{ label: __('All Courses'), route: { name: 'Courses' } }]"
 			/>
-			<div class="flex">
+			<div class="flex space-x-2">
+				<FormControl
+					type="text"
+					placeholder="Search Course"
+					v-model="searchQuery"
+					@input="courses.reload()"
+				>
+					<template #prefix>
+						<Search class="w-4 stroke-1.5 text-gray-600" name="search" />
+					</template>
+				</FormControl>
 				<router-link
 					:to="{
 						name: 'CreateCourse',
@@ -97,17 +107,30 @@
 </template>
 
 <script setup>
-import { createListResource, Breadcrumbs, Tabs, Badge, Button } from 'frappe-ui'
+import {
+	Breadcrumbs,
+	Tabs,
+	Badge,
+	Button,
+	FormControl,
+	createResource,
+} from 'frappe-ui'
 import CourseCard from '@/components/CourseCard.vue'
-import { Plus } from 'lucide-vue-next'
+import { Plus, Search } from 'lucide-vue-next'
 import { ref, computed, inject } from 'vue'
 import { updateDocumentTitle } from '@/utils'
 
 const user = inject('$user')
-const courses = createListResource({
-	type: 'list',
-	doctype: 'LMS Course',
-	cache: ['courses', user?.data?.email],
+const searchQuery = ref('')
+
+const courses = createResource({
+	debounce: 300,
+	makeParams() {
+		return {
+			search_query: searchQuery.value,
+		}
+	},
+	cache: ['courses', searchQuery.value, user?.data?.email],
 	url: 'lms.lms.utils.get_courses',
 	auto: true,
 })
diff --git a/lms/lms/utils.py b/lms/lms/utils.py
index 066f1133..04b9f09c 100644
--- a/lms/lms/utils.py
+++ b/lms/lms/utils.py
@@ -1251,10 +1251,12 @@ def change_currency(amount, currency, country=None):
 
 
 @frappe.whitelist(allow_guest=True)
-def get_courses():
+def get_courses(search_query=""):
 	"""Returns the list of courses."""
 	courses = []
-	course_list = frappe.get_all("LMS Course", pluck="name")
+	course_list = frappe.get_all(
+		"LMS Course", {"title": ["like", f"%{search_query}%"]}, pluck="name"
+	)
 	for course in course_list:
 		courses.append(get_course_details(course))
 

From 4ef694a2ed9463f039e72be36562ab3a7289af55 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Fri, 28 Jun 2024 18:51:47 +0530
Subject: [PATCH 2/2] fix: search cache issue

---
 frontend/src/pages/CertifiedParticipants.vue | 5 ++---
 frontend/src/pages/Courses.vue               | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/frontend/src/pages/CertifiedParticipants.vue b/frontend/src/pages/CertifiedParticipants.vue
index 77ebcb00..ee580773 100644
--- a/frontend/src/pages/CertifiedParticipants.vue
+++ b/frontend/src/pages/CertifiedParticipants.vue
@@ -48,7 +48,7 @@
 	</div>
 </template>
 <script setup>
-import { Breadcrumbs, FormControl, createResource, debounce } from 'frappe-ui'
+import { Breadcrumbs, FormControl, createResource } from 'frappe-ui'
 import { ref, computed } from 'vue'
 import UserAvatar from '@/components/UserAvatar.vue'
 import { Search } from 'lucide-vue-next'
@@ -59,8 +59,7 @@ const participants = createResource({
 	url: 'lms.lms.api.get_certified_participants',
 	method: 'GET',
 	debounce: 300,
-	cache: ['certified_participants', searchQuery.value],
-	makeParams() {
+	makeParams(values) {
 		return {
 			search_query: searchQuery.value,
 		}
diff --git a/frontend/src/pages/Courses.vue b/frontend/src/pages/Courses.vue
index 538670f3..3290ec3f 100644
--- a/frontend/src/pages/Courses.vue
+++ b/frontend/src/pages/Courses.vue
@@ -125,12 +125,11 @@ const searchQuery = ref('')
 
 const courses = createResource({
 	debounce: 300,
-	makeParams() {
+	makeParams(values) {
 		return {
 			search_query: searchQuery.value,
 		}
 	},
-	cache: ['courses', searchQuery.value, user?.data?.email],
 	url: 'lms.lms.utils.get_courses',
 	auto: true,
 })