From 41b076c0dbf2dda803b411783f7290656fbd878a Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 7 Nov 2023 11:42:31 +0530 Subject: [PATCH] fix: user type filter on assignment submission --- .../lms_assignment_submission.js | 11 +++++++++-- .../lms_assignment_submission.py | 2 +- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.js b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.js index d6aec59c..8a999c77 100644 --- a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.js +++ b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.js @@ -2,6 +2,13 @@ // For license information, please see license.txt frappe.ui.form.on("LMS Assignment Submission", { - // refresh: function(frm) { - // } + onload: function (frm) { + frm.set_query("member", function (doc) { + return { + filters: { + ignore_user_type: 1, + }, + }; + }); + }, }); diff --git a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py index c0893e17..a58f2207 100644 --- a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py +++ b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py @@ -43,7 +43,7 @@ class LMSAssignmentSubmission(Document): } moderators = frappe.get_all("Has Role", {"role": "Moderator"}, pluck="parent") - print(moderators) + if custom_template: email_template = get_email_template(custom_template, args) subject = email_template.get("subject")