From 43311dfb739b68fc82296976d41967c3faaa110c Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 1 Nov 2021 14:46:16 +0530 Subject: [PATCH] fix: made course filter mandatory for course progress summary report --- .../report/course_progress_summary/course_progress_summary.js | 3 ++- school/lms/widgets/CourseCard.html | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/school/lms/report/course_progress_summary/course_progress_summary.js b/school/lms/report/course_progress_summary/course_progress_summary.js index 668e5000..3d1150a8 100644 --- a/school/lms/report/course_progress_summary/course_progress_summary.js +++ b/school/lms/report/course_progress_summary/course_progress_summary.js @@ -8,7 +8,8 @@ frappe.query_reports["Course Progress Summary"] = { "fieldname": "course", "label": __("Course"), "fieldtype": "Link", - "options": "LMS Course" + "options": "LMS Course", + "reqd": 1, } ] }; diff --git a/school/lms/widgets/CourseCard.html b/school/lms/widgets/CourseCard.html index 669afd0c..f6bcd26d 100644 --- a/school/lms/widgets/CourseCard.html +++ b/school/lms/widgets/CourseCard.html @@ -51,13 +51,13 @@ {% if course.get_students() | length %} - + {{ course.get_students() | length }} {% endif %} {% set avg_rating = course.get_average_rating() %} {% if avg_rating %} - + {{ frappe.utils.flt(avg_rating, frappe.get_system_settings("float_precision") or 3) }}