From 4a8c8185c22422bdc146e7110be0473f5de8f599 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Wed, 6 Nov 2024 19:46:35 +0530 Subject: [PATCH] fix: condition to recalculate percentage --- lms/lms/doctype/course_chapter/course_chapter.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lms/lms/doctype/course_chapter/course_chapter.py b/lms/lms/doctype/course_chapter/course_chapter.py index e8947a29..d2a669f5 100644 --- a/lms/lms/doctype/course_chapter/course_chapter.py +++ b/lms/lms/doctype/course_chapter/course_chapter.py @@ -13,10 +13,12 @@ class CourseChapter(Document): update_course_statistics() def recalculate_course_progress(self): - previous_lessons = self.get_doc_before_save().as_dict().lessons + previous_lessons = ( + self.get_doc_before_save() and self.get_doc_before_save().as_dict().lessons + ) current_lessons = self.lessons - if previous_lessons != current_lessons: + if previous_lessons and previous_lessons != current_lessons: enrolled_members = frappe.get_all( "LMS Enrollment", {"course": self.course}, ["member", "name"] )