eduvia/lms
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: choice questions validations

Browse Source
This commit is contained in:
Jannat Patel
2024-11-18 11:16:34 +05:30
parent 6a70ed18d8
commit 52bd9825d8
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/src/components/Modals/Question.vue
View File

@@ -12,9 +12,9 @@
id="existing" id="existing"
value="existing" value="existing"
v-model="questionType" v-model="questionType"
class="w-3 h-3 accent-gray-900" class="w-3 h-3 cursor-pointer"
/> />
<label for="existing"> <label for="existing" class="cursor-pointer">
{{ __('Add an existing question') }} {{ __('Add an existing question') }}
</label> </label>
</div> </div>
@@ -25,9 +25,9 @@
id="new" id="new"
value="new" value="new"
v-model="questionType" v-model="questionType"
class="w-3 h-3" class="w-3 h-3 cursor-pointer"
/> />
<label for="new"> <label for="new" class="cursor-pointer">
{{ __('Create a new question') }} {{ __('Create a new question') }}
</label> </label>
</div> </div>
@@ -127,7 +127,7 @@ const populateFields = () => {
let counter = 1 let counter = 1
fields.forEach((field) => { fields.forEach((field) => {
while (counter <= 4) { while (counter <= 4) {
question[`${field}_${counter}`] = field === 'is_correct' ? false : '' question[`${field}_${counter}`] = field === 'is_correct' ? false : null
counter++ counter++
} }
}) })

1
frontend/src/pages/QuizForm.vue
View File

@@ -141,6 +141,7 @@
v-slot="{ idx, column, item }" v-slot="{ idx, column, item }"
v-for="row in quiz.questions" v-for="row in quiz.questions"
@click="openQuestionModal(row)" @click="openQuestionModal(row)"
class="cursor-pointer"
> >
<ListRowItem :item="item"> <ListRowItem :item="item">
<div <div

6
lms/lms/doctype/lms_question/lms_question.py
View File

@@ -16,6 +16,7 @@ class LMSQuestion(Document):
def validate_correct_answers(question): def validate_correct_answers(question):
if question.type == "Choices": if question.type == "Choices":
validate_duplicate_options(question) validate_duplicate_options(question)
validate_minimum_options(question)
validate_correct_options(question) validate_correct_options(question)
elif question.type == "User Input": elif question.type == "User Input":
validate_possible_answer(question) validate_possible_answer(question)
@@ -42,6 +43,11 @@ def validate_correct_options(question):
frappe.throw(_("At least one option must be correct for this question.")) frappe.throw(_("At least one option must be correct for this question."))
def validate_minimum_options(question):
if question.type == "Choices" and (not question.option_1 or not question.option_2):
frappe.throw(_("Minimum two options are required for multiple choice questions."))
def validate_possible_answer(question): def validate_possible_answer(question):
possible_answers = [] possible_answers = []
possible_answers_fields = [ possible_answers_fields = [