From 3bea19c8adfa215a26c90a4d914101baa755810c Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 17 Apr 2025 22:31:47 +0530
Subject: [PATCH 1/2] fix: moved powered by learning to the bottom of sidebar

---
 frontend/src/components/AppSidebar.vue   | 85 ++++++++++++++----------
 frontend/src/components/UserDropdown.vue |  7 --
 2 files changed, 50 insertions(+), 42 deletions(-)

diff --git a/frontend/src/components/AppSidebar.vue b/frontend/src/components/AppSidebar.vue
index 8b18c389..50c4f318 100644
--- a/frontend/src/components/AppSidebar.vue
+++ b/frontend/src/components/AppSidebar.vue
@@ -74,43 +74,53 @@
 				:isSidebarCollapsed="sidebarStore.isSidebarCollapsed"
 				appName="learning"
 			/>
-			<SidebarLink
-				v-if="isOnboardingStepsCompleted"
-				:link="{
-					label: __('Help'),
-				}"
-				:isCollapsed="sidebarStore.isSidebarCollapsed"
-				@click="
-					() => {
-						showHelpModal = minimize ? true : !showHelpModal
-						minimize = !showHelpModal
-					}
+
+			<div
+				class="flex items-center"
+				:class="
+					sidebarStore.isSidebarCollapsed ? 'flex-col space-y-3' : 'flex-row'
 				"
 			>
-				<template #icon>
-					<span class="grid h-5 w-6 flex-shrink-0 place-items-center">
-						<CircleHelp class="h-4 w-4 stroke-1.5" />
-					</span>
-				</template>
-			</SidebarLink>
-			<SidebarLink
-				:link="{
-					label: sidebarStore.isSidebarCollapsed ? 'Expand' : 'Collapse',
-				}"
-				:isCollapsed="sidebarStore.isSidebarCollapsed"
-				@click="toggleSidebar()"
-			>
-				<template #icon>
-					<span class="grid h-5 w-6 flex-shrink-0 place-items-center">
-						<CollapseSidebar
-							class="h-4 w-4 text-ink-gray-7 duration-300 ease-in-out"
-							:class="{
-								'[transform:rotateY(180deg)]': sidebarStore.isSidebarCollapsed,
-							}"
+				<div
+					class="flex items-center flex-1"
+					:class="
+						sidebarStore.isSidebarCollapsed
+							? 'flex-col space-y-3'
+							: 'flex-row space-x-3'
+					"
+				>
+					<Tooltip :text="__('Powered by Learning')">
+						<Zap
+							class="size-4 stroke-1.5 text-gray-700 cursor-pointer"
+							@click="redirectToWebsite()"
 						/>
-					</span>
-				</template>
-			</SidebarLink>
+					</Tooltip>
+					<Tooltip :text="__('Help')">
+						<CircleHelp
+							class="size-4 stroke-1.5 text-gray-700 cursor-pointer"
+							@click="
+								() => {
+									showHelpModal = minimize ? true : !showHelpModal
+									minimize = !showHelpModal
+								}
+							"
+						/>
+					</Tooltip>
+				</div>
+				<Tooltip
+					:text="
+						sidebarStore.isSidebarCollapsed ? __('Expand') : __('Collapse')
+					"
+				>
+					<CollapseSidebar
+						class="size-4 text-gray-700 duration-300 stroke-1.5 ease-in-out cursor-pointer"
+						:class="{
+							'[transform:rotateY(180deg)]': sidebarStore.isSidebarCollapsed,
+						}"
+						@click="toggleSidebar()"
+					/>
+				</Tooltip>
+			</div>
 		</div>
 		<HelpModal
 			v-if="showOnboarding && showHelpModal"
@@ -148,7 +158,7 @@ import { usersStore } from '@/stores/user'
 import { sessionStore } from '@/stores/session'
 import { useSidebar } from '@/stores/sidebar'
 import { useSettings } from '@/stores/settings'
-import { Button, createResource } from 'frappe-ui'
+import { Button, createResource, Tooltip } from 'frappe-ui'
 import PageModal from '@/components/Modals/PageModal.vue'
 import { capture } from '@/telemetry'
 import LMSLogo from '@/components/Icons/LMSLogo.vue'
@@ -164,6 +174,7 @@ import {
 	UserPlus,
 	Users,
 	BookText,
+	Zap,
 } from 'lucide-vue-next'
 import {
 	TrialBanner,
@@ -578,4 +589,8 @@ watch(userResource, () => {
 		setUpOnboarding()
 	}
 })
+
+const redirectToWebsite = () => {
+	window.open('https://frappe.io/learning', '_blank')
+}
 </script>
diff --git a/frontend/src/components/UserDropdown.vue b/frontend/src/components/UserDropdown.vue
index 072bd942..d8fd2eaa 100644
--- a/frontend/src/components/UserDropdown.vue
+++ b/frontend/src/components/UserDropdown.vue
@@ -199,13 +199,6 @@ const userDropdownOptions = computed(() => {
 		{
 			group: '',
 			items: [
-				{
-					icon: Zap,
-					label: 'Powered by Learning',
-					onClick: () => {
-						window.open('https://frappe.io/learning', '_blank')
-					},
-				},
 				{
 					icon: LogOut,
 					label: 'Log out',

From 1a1924de3e2069f1af191ca54e1e10e4b8537f73 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 17 Apr 2025 22:32:25 +0530
Subject: [PATCH 2/2] fix: removed styles on attachments as they were
 overriding the styles on webform

---
 lms/public/css/style.css | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/lms/public/css/style.css b/lms/public/css/style.css
index 4a5bbeee..c7bf1a2b 100644
--- a/lms/public/css/style.css
+++ b/lms/public/css/style.css
@@ -1621,30 +1621,6 @@ pre {
 	border: 1px solid var(--primary-color);
 }
 
-.show-attachments {
-	padding-right: 0.5rem;
-	display: flex;
-	align-items: center;
-}
-
-.attachment-controls {
-	display: flex;
-	align-items: center;
-	width: fit-content;
-	cursor: pointer;
-}
-
-.attachments {
-	flex-direction: column;
-	padding: 0.5rem 0;
-	margin-top: 1rem;
-	position: absolute;
-	z-index: 1;
-	width: fit-content;
-	border-collapse: separate;
-	border-spacing: 1rem 0.5rem;
-}
-
 li {
 	line-height: 1.7;
 }