fix: misc batch issues

frontend/src/components/BatchFeedback.vue

@@ -78,7 +78,7 @@
 							<template #prefix>
 								<div v-if="column.key == 'member_name'">
 									<Avatar
-										class="flex items-center"
+										class="flex"
 										:image="row['member_image']"
 										:label="item"
 										size="sm"
@@ -240,6 +240,6 @@ const feedbackColumns = computed(() => {
 <style>
 .feedback-list > button > div {
 	align-items: start;
-	padding: 0.25rem 0;
+	padding: 0.15rem 0;
 }
 </style>

frontend/src/components/BatchStudents.vue

@@ -78,7 +78,7 @@
 				:options="chartOptions"
 				:series="chartData"
 				type="bar"
-				height="200"
+				:height="chartData[0].data.length * 30 + 100"
 			/>
 			<div
 				class="flex items-center justify-center text-sm text-ink-gray-7 space-x-4"
@@ -357,7 +357,7 @@ const getChartData = () => {
 		})
 
 		Object.keys(student.assessments).forEach((assessment) => {
-			if (student.assessments[assessment].result === 'Passed') {
+			if (student.assessments[assessment].result === 'Pass') {
 				categories[assessment].value += 1
 			}
 		})

frontend/src/components/Modals/AnnouncementModal.vue

@@ -67,13 +67,16 @@ const announcement = reactive({
 })
 
 const announcementResource = createResource({
-	url: 'lms.lms.api.make_announcement',
+	url: 'frappe.core.doctype.communication.email.make',
 	makeParams(values) {
 		return {
-			students: props.students,
+			recipients: props.students.join(', '),
 			cc: announcement.replyTo,
 			subject: announcement.subject,
 			content: announcement.announcement,
+			doctype: 'LMS Batch',
+			name: props.batch,
+			send_email: 1,
 		}
 	},
 })

frontend/src/components/Modals/BatchStudentProgress.vue

@@ -32,25 +32,44 @@
 								{{ __('Assessment') }}
 							</span>
 							<span>
-								{{ __('Progress') }}
+								{{ __('Percentage/Status') }}
 							</span>
 						</div>
-						<div
+						<router-link
 							v-for="assessment in Object.keys(student.assessments)"
 							class="flex items-center text-ink-gray-7 font-medium"
+							:to="{
+								name:
+									student.assessments[assessment].type == 'LMS Assignment'
+										? 'AssignmentSubmission'
+										: '',
+								params:
+									student.assessments[assessment].type == 'LMS Assignment'
+										? {
+												assignmentID:
+													student.assessments[assessment].assessment,
+												submissionName:
+													student.assessments[assessment].submission,
+										  }
+										: {},
+							}"
 						>
 							<span class="flex-1">
 								{{ assessment }}
 							</span>
-							<span v-if="isAssignment(student.assessments[assessment])">
-								<Badge :theme="getStatusTheme(student.assessments[assessment])">
-									{{ student.assessments[assessment] }}
+							<span v-if="isAssignment(student.assessments[assessment].status)">
+								<Badge
+									:theme="
+										getStatusTheme(student.assessments[assessment].status)
+									"
+								>
+									{{ student.assessments[assessment].status }}
 								</Badge>
 							</span>
 							<span v-else>
-								{{ student.assessments[assessment] }}
+								{{ student.assessments[assessment].status }}
 							</span>
-						</div>
+						</router-link>
 					</div>
 
 					<!-- Courses -->

frontend/src/pages/BatchDetail.vue

@@ -127,6 +127,11 @@ const batch = createResource({
 		batch: props.batchName,
 	},
 	auto: true,
+	onSuccess: (data) => {
+		if (!data) {
+			router.push({ name: 'Batches' })
+		}
+	},
 })
 
 const courses = createResource({