From 5bc44e6fe5313adcfed2aa06e4c5ab2af4a69f79 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Mon, 7 Apr 2025 18:15:30 +0530
Subject: [PATCH] feat: signups can now be enabled/disabled from portal
 settings

---
 .../src/components/Controls/CodeEditor.vue    |  1 -
 frontend/src/components/Modals/Settings.vue   | 23 ++++++++++++-------
 frontend/src/components/SettingFields.vue     |  2 +-
 .../doctype/lms_settings/lms_settings.json    | 17 ++++++++++----
 lms/lms/doctype/lms_settings/lms_settings.py  |  5 ++++
 lms/templates/signup-form.html                |  2 +-
 6 files changed, 35 insertions(+), 15 deletions(-)

diff --git a/frontend/src/components/Controls/CodeEditor.vue b/frontend/src/components/Controls/CodeEditor.vue
index cbb10b83..32ae86ed 100644
--- a/frontend/src/components/Controls/CodeEditor.vue
+++ b/frontend/src/components/Controls/CodeEditor.vue
@@ -146,7 +146,6 @@ function resetEditor(value: string, resetHistory = false) {
 	value = getModelValue()
 	aceEditor?.setValue(value)
 	aceEditor?.clearSelection()
-	console.log(isDark.value)
 	aceEditor?.setTheme(isDark.value ? 'ace/theme/twilight' : 'ace/theme/chrome')
 	props.autofocus && aceEditor?.focus()
 	if (resetHistory) {
diff --git a/frontend/src/components/Modals/Settings.vue b/frontend/src/components/Modals/Settings.vue
index fb9aaff7..290416a8 100644
--- a/frontend/src/components/Modals/Settings.vue
+++ b/frontend/src/components/Modals/Settings.vue
@@ -328,19 +328,26 @@ const tabsStructure = computed(() => {
 					icon: 'LogIn',
 					fields: [
 						{
-							label: 'Custom Content',
+							label: 'Identify User Persona',
+							name: 'user_category',
+							type: 'checkbox',
+							description:
+								'Enable this option to identify the user persona during signup.',
+						},
+						{
+							label: 'Disable signup',
+							name: 'disable_signup',
+							type: 'checkbox',
+							description:
+								'New users will have to be manually registered by Admins.',
+						},
+						{
+							label: 'Signup Consent HTML',
 							name: 'custom_signup_content',
 							type: 'Code',
 							mode: 'htmlmixed',
 							rows: 10,
 						},
-						{
-							label: 'Ask for Occupation',
-							name: 'user_category',
-							type: 'checkbox',
-							description:
-								'Enable this option to ask users to select their occupation during the signup process.',
-						},
 					],
 				},
 			],
diff --git a/frontend/src/components/SettingFields.vue b/frontend/src/components/SettingFields.vue
index aa032489..10882f87 100644
--- a/frontend/src/components/SettingFields.vue
+++ b/frontend/src/components/SettingFields.vue
@@ -99,7 +99,7 @@
 </template>
 <script setup>
 import { FormControl, FileUploader, Button, Switch } from 'frappe-ui'
-import { computed } from 'vue'
+import { computed, onMounted } from 'vue'
 import { getFileSize, validateFile } from '@/utils'
 import { X } from 'lucide-vue-next'
 import Link from '@/components/Controls/Link.vue'
diff --git a/lms/lms/doctype/lms_settings/lms_settings.json b/lms/lms/doctype/lms_settings/lms_settings.json
index 8f7d3be2..4c1fb733 100644
--- a/lms/lms/doctype/lms_settings/lms_settings.json
+++ b/lms/lms/doctype/lms_settings/lms_settings.json
@@ -27,8 +27,9 @@
   "signup_settings_tab",
   "signup_settings_section",
   "column_break_9",
-  "custom_signup_content",
   "user_category",
+  "disable_signup",
+  "custom_signup_content",
   "sidebar_tab",
   "items_in_sidebar_section",
   "courses",
@@ -104,7 +105,7 @@
    "default": "0",
    "fieldname": "user_category",
    "fieldtype": "Check",
-   "label": "Ask User Category during Signup"
+   "label": "Identify User Persona"
   },
   {
    "default": "0",
@@ -365,12 +366,19 @@
    "fieldtype": "Link",
    "label": "Payment Reminder Template",
    "options": "Email Template"
+  },
+  {
+   "default": "0",
+   "fieldname": "disable_signup",
+   "fieldtype": "Check",
+   "label": "Disable Signup"
   }
  ],
+ "grid_page_length": 50,
  "index_web_pages_for_search": 1,
  "issingle": 1,
  "links": [],
- "modified": "2025-02-11 11:29:43.412897",
+ "modified": "2025-04-07 18:05:52.000651",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Settings",
@@ -394,8 +402,9 @@
    "share": 1
   }
  ],
+ "row_format": "Dynamic",
  "sort_field": "modified",
  "sort_order": "DESC",
  "states": [],
  "track_changes": 1
-}
\ No newline at end of file
+}
diff --git a/lms/lms/doctype/lms_settings/lms_settings.py b/lms/lms/doctype/lms_settings/lms_settings.py
index 3307f113..7b79ef32 100644
--- a/lms/lms/doctype/lms_settings/lms_settings.py
+++ b/lms/lms/doctype/lms_settings/lms_settings.py
@@ -10,6 +10,7 @@ from frappe.utils import get_url_to_list
 class LMSSettings(Document):
 	def validate(self):
 		self.validate_google_settings()
+		self.validate_signup()
 
 	def validate_google_settings(self):
 		if self.send_calendar_invite_for_evaluations:
@@ -40,6 +41,10 @@ class LMSSettings(Document):
 					)
 				)
 
+	def validate_signup(self):
+		if self.has_value_changed("disable_signup"):
+			frappe.db.set_single_value("Website Settings", "disable_signup", self.disable_signup)
+
 
 @frappe.whitelist()
 def check_payments_app():
diff --git a/lms/templates/signup-form.html b/lms/templates/signup-form.html
index 296884d2..e78020dd 100644
--- a/lms/templates/signup-form.html
+++ b/lms/templates/signup-form.html
@@ -17,7 +17,7 @@
             <label class="form-label sr-only"> {{ _("User Category") }} </label>
             <div class="control-input-wrapper">
                 <div class="control-input flex align-center">
-                    <select type="text" id="user_category" data-fieldname="user_category" style="color: var(--text-muted)"
+                    <select type="text" id="user_category" data-fieldname="user_category" style="color: var(--text-light)"
                     class="input-with-feedback form-control ellipsis" data-fieldtype="Select" required>
                         <option value=""> {{ _("Category") }} </option>
                         <option value="Business Owner"> {{ _("Business Owner") }} </option>