From af19940fa121acc6753828b38c5e5d71bc5b6a9e Mon Sep 17 00:00:00 2001 From: Hussain Nagaria Date: Fri, 23 May 2025 14:00:11 +0530 Subject: [PATCH 1/4] fix: some code semantics --- frontend/src/components/Modals/EvaluationModal.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/Modals/EvaluationModal.vue b/frontend/src/components/Modals/EvaluationModal.vue index 8c48ccae..4fb68469 100644 --- a/frontend/src/components/Modals/EvaluationModal.vue +++ b/frontend/src/components/Modals/EvaluationModal.vue @@ -90,7 +90,7 @@ const props = defineProps({ }, }) -let evaluation = reactive({ +const evaluation = reactive({ course: '', date: '', start_time: '', @@ -139,7 +139,7 @@ function submitEvaluation(close) { close() }, onError(err) { - let message = err.messages?.[0] || err + const message = err.messages?.[0] || err let unavailabilityMessage if (typeof message === 'string') { @@ -154,7 +154,7 @@ function submitEvaluation(close) { } const getCourses = () => { - let courses = [] + const courses = [] for (const course of props.courses) { if (course.evaluator) { courses.push({ @@ -164,7 +164,7 @@ const getCourses = () => { } } - if (courses.length == 1) { + if (courses.length === 1) { evaluation.course = courses[0].value } From 4f0ac98eea7b2e0a82165cb7c54fc6f8d4398fee Mon Sep 17 00:00:00 2001 From: Hussain Nagaria Date: Fri, 23 May 2025 14:02:04 +0530 Subject: [PATCH 2/4] fix: toast used but not imported --- frontend/src/components/Modals/EvaluationModal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/Modals/EvaluationModal.vue b/frontend/src/components/Modals/EvaluationModal.vue index 4fb68469..4ec23f90 100644 --- a/frontend/src/components/Modals/EvaluationModal.vue +++ b/frontend/src/components/Modals/EvaluationModal.vue @@ -66,7 +66,7 @@