From 8fe02b83b8aa02082e99455d04f4c2babbdf1bca Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Thu, 17 Oct 2024 09:27:24 +0530 Subject: [PATCH 1/3] fix: batch enrollment after payment completion --- lms/lms/utils.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/lms/lms/utils.py b/lms/lms/utils.py index de0fdf67..7738a353 100644 --- a/lms/lms/utils.py +++ b/lms/lms/utils.py @@ -1678,7 +1678,7 @@ def update_payment_record(doctype, docname): if doctype == "LMS Course": enroll_in_course(data.payment, docname) else: - enroll_in_batch(data.payment, docname) + enroll_in_batch(docname, data.payment) except Exception as e: frappe.log_error(frappe.get_traceback(), _("Enrollment Failed")) @@ -1709,20 +1709,24 @@ def enroll_in_batch(batch, payment_name=None): ): student = frappe.new_doc("Batch Student") current_count = frappe.db.count("Batch Student", {"parent": batch}) - if payment_name: - payment = frappe.db.get_value( - "LMS Payment", payment_name, ["name", "source"], as_dict=True - ) - + student.update( { "student": frappe.session.user, - "payment": payment.name if payment_name else None, - "source": payment.source if payment_name else None, "parent": batch, "parenttype": "LMS Batch", "parentfield": "students", "idx": current_count + 1, } ) + + if payment_name: + payment = frappe.db.get_value( + "LMS Payment", payment_name, ["name", "source"], as_dict=True + ) + student.update({ + "payment": payment.name, + "source": payment.source, + }) + student.save(ignore_permissions=True) From 4d82bc86e80a3497acf1a9d76c0ec07d55d2778f Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Thu, 17 Oct 2024 10:30:06 +0530 Subject: [PATCH 2/3] style: fix spacing --- lms/lms/utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lms/lms/utils.py b/lms/lms/utils.py index 7738a353..624d4917 100644 --- a/lms/lms/utils.py +++ b/lms/lms/utils.py @@ -1728,5 +1728,6 @@ def enroll_in_batch(batch, payment_name=None): "payment": payment.name, "source": payment.source, }) + student.save(ignore_permissions=True) From 49a765a9a63083fb817c65c23c926cf64d2ac5bf Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Thu, 17 Oct 2024 10:31:56 +0530 Subject: [PATCH 3/3] style: fix spacing --- lms/lms/utils.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lms/lms/utils.py b/lms/lms/utils.py index 624d4917..406dc979 100644 --- a/lms/lms/utils.py +++ b/lms/lms/utils.py @@ -1709,7 +1709,7 @@ def enroll_in_batch(batch, payment_name=None): ): student = frappe.new_doc("Batch Student") current_count = frappe.db.count("Batch Student", {"parent": batch}) - + student.update( { "student": frappe.session.user, @@ -1724,10 +1724,11 @@ def enroll_in_batch(batch, payment_name=None): payment = frappe.db.get_value( "LMS Payment", payment_name, ["name", "source"], as_dict=True ) - student.update({ - "payment": payment.name, - "source": payment.source, - }) - + student.update( + { + "payment": payment.name, + "source": payment.source, + } + ) student.save(ignore_permissions=True)