fix: tabs to space, moved js to widget, removed unrelated changes

This commit is contained in:
pateljannat
2021-05-03 15:14:11 +05:30
parent 565787eeb6
commit 5fdecb708e
11 changed files with 175 additions and 173 deletions

View File

@@ -2,7 +2,7 @@
// For license information, please see license.txt // For license information, please see license.txt
frappe.ui.form.on('Invite Request', { frappe.ui.form.on('Invite Request', {
// refresh: function(frm) { // refresh: function(frm) {
// } // }
}); });

View File

@@ -85,4 +85,4 @@
"sort_order": "DESC", "sort_order": "DESC",
"title_field": "invite_email", "title_field": "invite_email",
"track_changes": 1 "track_changes": 1
} }

View File

@@ -10,69 +10,69 @@ import json
from frappe.utils.password import get_decrypted_password from frappe.utils.password import get_decrypted_password
class InviteRequest(Document): class InviteRequest(Document):
def on_update(self): def on_update(self):
if self.has_value_changed('status') and self.status == "Approved": if self.has_value_changed('status') and self.status == "Approved":
self.send_email() self.send_email()
def create_user(self, password): def create_user(self, password):
full_name_split = self.full_name.split(" ") full_name_split = self.full_name.split(" ")
user = frappe.get_doc({ user = frappe.get_doc({
"doctype": "User", "doctype": "User",
"email": self.signup_email, "email": self.signup_email,
"first_name": full_name_split[0], "first_name": full_name_split[0],
"last_name": full_name_split[1] if len(full_name_split) > 1 else "", "last_name": full_name_split[1] if len(full_name_split) > 1 else "",
"username": self.username, "username": self.username,
"send_welcome_email": 0, "send_welcome_email": 0,
"user_type": "Website User", "user_type": "Website User",
"new_password": password "new_password": password
}) })
user.save(ignore_permissions=True) user.save(ignore_permissions=True)
return user return user
def send_email(self): def send_email(self):
subject = _("Your request has been approved.") subject = _("Your request has been approved.")
args = { args = {
"full_name": self.full_name, "full_name": self.full_name,
"signup_form_link": "/new-sign-up?invite_code={0}".format(self.name), "signup_form_link": "/new-sign-up?invite_code={0}".format(self.name),
"site_url": frappe.utils.get_url() "site_url": frappe.utils.get_url()
} }
frappe.sendmail( frappe.sendmail(
recipients=self.invite_email, recipients=self.invite_email,
sender=frappe.db.get_single_value("LMS Settings", "email_sender"), sender=frappe.db.get_single_value("LMS Settings", "email_sender"),
subject=subject, subject=subject,
header=[subject, "green"], header=[subject, "green"],
template = "lms_invite_request_approved", template = "lms_invite_request_approved",
args=args) args=args)
@frappe.whitelist(allow_guest=True) @frappe.whitelist(allow_guest=True)
def create_invite_request(invite_email): def create_invite_request(invite_email):
try: try:
frappe.get_doc({ frappe.get_doc({
"doctype": "Invite Request", "doctype": "Invite Request",
"invite_email": invite_email "invite_email": invite_email
}).save(ignore_permissions=True) }).save(ignore_permissions=True)
return "OK" return "OK"
except frappe.UniqueValidationError: except frappe.UniqueValidationError:
frappe.throw(_("Email {0} has already been used to request an invite").format(invite_email)) frappe.throw(_("Email {0} has already been used to request an invite").format(invite_email))
@frappe.whitelist(allow_guest=True) @frappe.whitelist(allow_guest=True)
def update_invite(data): def update_invite(data):
data = frappe._dict(json.loads(data)) if type(data) == str else frappe._dict(data) data = frappe._dict(json.loads(data)) if type(data) == str else frappe._dict(data)
try: try:
doc = frappe.get_doc("Invite Request", data.invite_code) doc = frappe.get_doc("Invite Request", data.invite_code)
except frappe.DoesNotExistError: except frappe.DoesNotExistError:
frappe.throw(_("Invalid Invite Code.")) frappe.throw(_("Invalid Invite Code."))
doc.signup_email = data.signup_email doc.signup_email = data.signup_email
doc.username = data.username doc.username = data.username
doc.full_name = data.full_name doc.full_name = data.full_name
doc.invite_code = data.invite_code doc.invite_code = data.invite_code
doc.save(ignore_permissions=True) doc.save(ignore_permissions=True)
user = doc.create_user(data.password) user = doc.create_user(data.password)
if user: if user:
doc.status = "Registered" doc.status = "Registered"
doc.save(ignore_permissions=True) doc.save(ignore_permissions=True)
return "OK" return "OK"

View File

@@ -7,63 +7,63 @@ import frappe
import unittest import unittest
class TestInviteRequest(unittest.TestCase): class TestInviteRequest(unittest.TestCase):
@classmethod
def setUpClass(self):
create_invite_request("test_invite@example.com")
def test_create_invite_request(self): @classmethod
if frappe.db.exists("Invite Request", {"invite_email": "test_invite@example.com"}): def setUpClass(self):
invite = frappe.db.get_value("Invite Request", create_invite_request("test_invite@example.com")
filters={"invite_email": "test_invite@example.com"},
fieldname=["invite_email", "status", "signup_email"],
as_dict=True)
self.assertEqual(invite.status, "Pending")
self.assertEqual(invite.signup_email, None)
def test_create_invite_request_update(self): def test_create_invite_request(self):
if frappe.db.exists("Invite Request", {"invite_email": "test_invite@example.com"}): if frappe.db.exists("Invite Request", {"invite_email": "test_invite@example.com"}):
invite = frappe.db.get_value("Invite Request",
filters={"invite_email": "test_invite@example.com"},
fieldname=["invite_email", "status", "signup_email"],
as_dict=True)
self.assertEqual(invite.status, "Pending")
self.assertEqual(invite.signup_email, None)
data = { def test_create_invite_request_update(self):
"signup_email": "test_invite@example.com", if frappe.db.exists("Invite Request", {"invite_email": "test_invite@example.com"}):
"username": "test_invite",
"full_name": "Test Invite",
"password": "Test@invite",
"invite_code": frappe.db.get_value("Invite Request", {"invite_email": "test_invite@example.com"}, "name")
}
update_invite(data) data = {
invite = frappe.db.get_value("Invite Request", "signup_email": "test_invite@example.com",
filters={"invite_email": "test_invite@example.com"}, "username": "test_invite",
fieldname=["invite_email", "status", "signup_email", "full_name", "username", "invite_code", "name"], "full_name": "Test Invite",
as_dict=True) "password": "Test@invite",
self.assertEqual(invite.signup_email, "test_invite@example.com") "invite_code": frappe.db.get_value("Invite Request", {"invite_email": "test_invite@example.com"}, "name")
self.assertEqual(invite.full_name, "Test Invite") }
self.assertEqual(invite.username, "test_invite")
self.assertEqual(invite.invite_code, invite.name)
self.assertEqual(invite.status, "Registered")
user = frappe.db.get_value("User", "test_invite@example.com", update_invite(data)
fieldname=["first_name", "username", "send_welcome_email", "user_type"], invite = frappe.db.get_value("Invite Request",
as_dict=True) filters={"invite_email": "test_invite@example.com"},
self.assertTrue(user) fieldname=["invite_email", "status", "signup_email", "full_name", "username", "invite_code", "name"],
self.assertEqual(user.first_name, invite.full_name.split(" ")[0]) as_dict=True)
self.assertEqual(user.username, invite.username) self.assertEqual(invite.signup_email, "test_invite@example.com")
self.assertEqual(user.send_welcome_email, 0) self.assertEqual(invite.full_name, "Test Invite")
self.assertEqual(user.user_type, "Website User") self.assertEqual(invite.username, "test_invite")
self.assertEqual(invite.invite_code, invite.name)
self.assertEqual(invite.status, "Registered")
member = frappe.db.get_value("Community Member", {"email": "test_invite@example.com"}) user = frappe.db.get_value("User", "test_invite@example.com",
self.assertTrue(member) fieldname=["first_name", "username", "send_welcome_email", "user_type"],
as_dict=True)
self.assertTrue(user)
self.assertEqual(user.first_name, invite.full_name.split(" ")[0])
self.assertEqual(user.username, invite.username)
self.assertEqual(user.send_welcome_email, 0)
self.assertEqual(user.user_type, "Website User")
@classmethod member = frappe.db.get_value("Community Member", {"email": "test_invite@example.com"})
def tearDownClass(self): self.assertTrue(member)
if frappe.db.exists("Community Member", {"email": "test_invite@example.com"}): @classmethod
frappe.delete_doc("Community Member", {"email": "test_invite@example.com"}) def tearDownClass(self):
if frappe.db.exists("User", "test_invite@example.com"): if frappe.db.exists("Community Member", {"email": "test_invite@example.com"}):
frappe.delete_doc("User", "test_invite@example.com") frappe.delete_doc("Community Member", {"email": "test_invite@example.com"})
invite_request = frappe.db.exists("Invite Request", {"invite_email": "test_invite@example.com"}) if frappe.db.exists("User", "test_invite@example.com"):
if invite_request: frappe.delete_doc("User", "test_invite@example.com")
frappe.delete_doc("Invite Request", invite_request)
invite_request = frappe.db.exists("Invite Request", {"invite_email": "test_invite@example.com"})
if invite_request:
frappe.delete_doc("Invite Request", invite_request)

View File

@@ -1,43 +1,43 @@
frappe.ready(function () { frappe.ready(function () {
frappe.web_form.after_save = () => { frappe.web_form.after_save = () => {
let data = frappe.web_form.get_values(); let data = frappe.web_form.get_values();
frappe.call({ frappe.call({
"method": "community.lms.doctype.lms_batch_membership.lms_batch_membership.create_membership", "method": "community.lms.doctype.lms_batch_membership.lms_batch_membership.create_membership",
"args": { "args": {
"batch": data.title, "batch": data.title,
"member_type": "Mentor", "member_type": "Mentor",
"course": data.course "course": data.course
}, },
"callback": (data) => { "callback": (data) => {
if (data.message) { if (data.message) {
window.location.href = `courses/${data.message}` window.location.href = `courses/${data.message}`
} }
} }
}) })
} }
frappe.web_form.validate = () => { frappe.web_form.validate = () => {
let sysdefaults = frappe.boot.sysdefaults; let sysdefaults = frappe.boot.sysdefaults;
let time_format = sysdefaults && sysdefaults.time_format ? sysdefaults.time_format : 'HH:mm:ss'; let time_format = sysdefaults && sysdefaults.time_format ? sysdefaults.time_format : 'HH:mm:ss';
let data = frappe.web_form.get_values(); let data = frappe.web_form.get_values();
data.start_time = moment(data.start_time,time_format).format(time_format) data.start_time = moment(data.start_time,time_format).format(time_format)
data.end_time = moment(data.end_time,time_format).format(time_format) data.end_time = moment(data.end_time,time_format).format(time_format)
if (!frappe.datetime.validate(data.start_time) || !frappe.datetime.validate(data.end_time)) { if (!frappe.datetime.validate(data.start_time) || !frappe.datetime.validate(data.end_time)) {
frappe.msgprint(__('Invalid Start or End Time.')); frappe.msgprint(__('Invalid Start or End Time.'));
return false; return false;
} }
if (data.start_time > data.end_time) { if (data.start_time > data.end_time) {
frappe.msgprint(__('Start Time should be less than End Time.')); frappe.msgprint(__('Start Time should be less than End Time.'));
return false; return false;
} }
if (data.start_date < date.nowdate()) { if (data.start_date < date.nowdate()) {
frappe.msgprint(__('Start date cannot be a past date.')) frappe.msgprint(__('Start date cannot be a past date.'))
return false; return false;
} }
return true; return true;
}; };
}) })

View File

@@ -111,4 +111,4 @@
"show_in_filter": 0 "show_in_filter": 0
} }
] ]
} }

View File

@@ -3,5 +3,5 @@ from __future__ import unicode_literals
import frappe import frappe
def get_context(context): def get_context(context):
# do your magic here # do your magic here
pass pass

View File

@@ -1,4 +1,25 @@
<form id="invite-request-form"> <form id="invite-request-form">
<input class="form-control field-width mr-5" id="invite_email" type="email" placeholder="Email Address"> <input class="form-control field-width mr-5" id="invite_email" type="email" placeholder="Email Address">
<a type="submit" id="submit" class="btn btn-primary btn-lg" href="#" role="button">Request Invite</a> <a type="submit" id="submit-invite-request" class="btn btn-primary btn-lg" href="#" role="button">Request Invite</a>
</form> </form>
<script>
frappe.ready(() => {
$("#submit-invite-request").click(function () {
frappe.call({
method: "community.lms.doctype.invite_request.invite_request.create_invite_request",
args: {
invite_email: $("#invite_email").val()
},
callback: (data) => {
if (data.message == "OK") {
$("#invite-request-form").hide();
var message = `<div>
<p class="lead">Thanks for your interest in Mon School. We have recorded your interest and we will get back to you shortly.</p>
</div>`;
$(".jumbotron").append(message);
}
}
})
})
})
</script>

View File

@@ -111,11 +111,11 @@
{% endfor %} {% endfor %}
</div> </div>
<a class="btn btn-primary add-batch margin-bottom" href="/add-a-new-batch?new=1&course={{course.title}}">Add a new batch</a> <a class="btn btn-primary add-batch margin-bottom" href="/add-a-new-batch?new=1&course={{course.name}}">Add a new batch</a>
{% else %} {% else %}
<div class="mentor_message"> <div class="mentor_message">
<p> You are a mentor for this course. </p> <p> You are a mentor for this course. </p>
<a class="btn btn-primary" href="/add-a-new-batch?new=1&course={{course.title}}" >Create your first batch</a> <a class="btn btn-primary" href="/add-a-new-batch?new=1&course={{course.name}}" >Create your first batch</a>
</div> </div>
{% endif %} {% endif %}
{% endmacro %} {% endmacro %}

View File

@@ -1,19 +0,0 @@
frappe.ready(() => {
$("#submit").click(function () {
frappe.call({
method: "community.lms.doctype.invite_request.invite_request.create_invite_request",
args: {
invite_email: $("#invite_email").val()
},
callback: (data) => {
if (data.message == "OK") {
$("#invite-request-form").hide();
var message = `<div>
<p class="lead">Thanks for your interest in Mon School. We have recorded your interest and we will get back to you shortly.</p>
</div>`;
$(".jumbotron").append(message);
}
}
})
})
})

View File

@@ -1,5 +1,5 @@
import frappe import frappe
from community.lms.models import Sketch from ...lms.doctype.lms_sketch.lms_sketch import get_recent_sketches
def get_context(context): def get_context(context):
context.no_cache = 1 context.no_cache = 1
@@ -8,7 +8,7 @@ def get_context(context):
if not context.member: if not context.member:
context.template = "www/404.html" context.template = "www/404.html"
else: else:
context.sketches = Sketch.get_recent_sketches(context.member.email) context.sketches = list(filter(lambda x: x.owner == context.member.email, get_recent_sketches()))
def get_member(username): def get_member(username):
try: try: