refactor: moved community member class functions to user override

community/lms/doctype/lms_batch/lms_batch.py

@@ -42,13 +42,10 @@ class LMSBatch(Document):
 
         If member_type is specified, checks if the person is a Student/Mentor.
         """
-        member = find("Community Member", email=email)
-        if not member:
-            return
 
         filters = {
             "batch": self.name,
-            "member": member.name
+            "member": email
         }
         if member_type:
             filters['member_type'] = member_type
@@ -63,8 +60,8 @@ class LMSBatch(Document):
                     ["member"])
         member_names = [m['member'] for m in memberships]
         members = frappe.get_all(
-                    "Community Member",
-                    {"name": ["IN", member_names]},
+                    "Users",
+                    {"email": ["IN", member_names]},
                     ["email", "full_name", "username"])
         return members
 

community/lms/doctype/lms_batch_membership/lms_batch_membership.py

@@ -29,13 +29,11 @@ class LMSBatchMembership(Document):
                 frappe.throw(_("{0} is already a {1} of {2} course through {3} batch").format(member_name, membership.member_type, course, membership.batch))
 
 def create_membership(batch, member=None, member_type="Student", role="Member"):
-    if not member:
-        member = frappe.db.get_value("Community Member", {"email": frappe.session.user}, "name")
     frappe.get_doc({
         "doctype": "LMS Batch Membership",
         "batch": batch,
         "role": role,
         "member_type": member_type,
-        "member": member
+        "member": member or frappe.session.user
     }).save(ignore_permissions=True)
     return "OK"