From 63c4f708c3b3e40b43ea37aec5d6f804bffff082 Mon Sep 17 00:00:00 2001 From: Anand Chitipothu Date: Sat, 4 Dec 2021 23:03:58 +0530 Subject: [PATCH] feat: improved the subgroup page load time Using `get_cached_doc` instead of `get_doc` for loading students and mentors. Issue #271 --- school/lms/doctype/cohort_subgroup/cohort_subgroup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/school/lms/doctype/cohort_subgroup/cohort_subgroup.py b/school/lms/doctype/cohort_subgroup/cohort_subgroup.py index 6d2d1d08..814a1c70 100644 --- a/school/lms/doctype/cohort_subgroup/cohort_subgroup.py +++ b/school/lms/doctype/cohort_subgroup/cohort_subgroup.py @@ -47,7 +47,7 @@ class CohortSubgroup(Document): def get_mentors(self): emails = frappe.get_all("Cohort Mentor", filters={"subgroup": self.name}, fields=["email"], pluck='email') - return [frappe.get_doc("User", email) for email in emails] + return [frappe.get_cached_doc("User", email) for email in emails] def get_students(self): emails = frappe.get_all("LMS Batch Membership", @@ -56,7 +56,7 @@ class CohortSubgroup(Document): pluck='member', page_length=1000) - return [frappe.get_doc("User", email) for email in emails] + return [frappe.get_cached_doc("User", email) for email in emails] def is_mentor(self, email): q = {