From 50fe94e47be2a5dcb3a068a309984a933cc70583 Mon Sep 17 00:00:00 2001
From: Fahid Latheef Alungal <fahideng@gmail.com>
Date: Sun, 16 Feb 2025 16:08:35 +0530
Subject: [PATCH 1/6] fix: fix yarn dev not working due to const variable
 re-assignment
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It was causing this error

  ✘ [ERROR] Cannot assign to "isLoggedIn" because it is a constant

    src/router.js:230:2:
      230 │     isLoggedIn = false
          ╵     ~~~~~~~~~~

  The symbol "isLoggedIn" was declared a constant here:

    src/router.js:222:7:
      222 │   const { isLoggedIn } = sessionStore()
          ╵         ^
---
 frontend/src/router.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/router.js b/frontend/src/router.js
index a6d02f73..742d48d4 100644
--- a/frontend/src/router.js
+++ b/frontend/src/router.js
@@ -219,7 +219,7 @@ let router = createRouter({
 
 router.beforeEach(async (to, from, next) => {
 	const { userResource } = usersStore()
-	const { isLoggedIn } = sessionStore()
+	let { isLoggedIn } = sessionStore()
 	const { allowGuestAccess } = useSettings()
 
 	try {

From 54047e3c2c8cd47867d08ca33a908f17608d4366 Mon Sep 17 00:00:00 2001
From: Fahid Latheef Alungal <fahideng@gmail.com>
Date: Sun, 16 Feb 2025 16:10:14 +0530
Subject: [PATCH 2/6] fix: fix spelling typo Maximun Attempts -> Maximum
 Attempts

---
 frontend/src/pages/QuizForm.vue | 2 +-
 lms/locale/ar.po                | 2 +-
 lms/locale/bs.po                | 2 +-
 lms/locale/de.po                | 2 +-
 lms/locale/eo.po                | 2 +-
 lms/locale/es.po                | 2 +-
 lms/locale/fa.po                | 2 +-
 lms/locale/fr.po                | 2 +-
 lms/locale/hu.po                | 2 +-
 lms/locale/main.pot             | 2 +-
 lms/locale/pl.po                | 2 +-
 lms/locale/ru.po                | 2 +-
 lms/locale/sv.po                | 2 +-
 lms/locale/tr.po                | 2 +-
 lms/locale/zh.po                | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/frontend/src/pages/QuizForm.vue b/frontend/src/pages/QuizForm.vue
index b8f66df6..c143d2aa 100644
--- a/frontend/src/pages/QuizForm.vue
+++ b/frontend/src/pages/QuizForm.vue
@@ -55,7 +55,7 @@
 					<FormControl
 						type="number"
 						v-model="quiz.max_attempts"
-						:label="__('Maximun Attempts')"
+						:label="__('Maximum Attempts')"
 					/>
 					<FormControl
 						type="number"
diff --git a/lms/locale/ar.po b/lms/locale/ar.po
index 2c4cc89c..8170ae3a 100644
--- a/lms/locale/ar.po
+++ b/lms/locale/ar.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/bs.po b/lms/locale/bs.po
index 2476540e..5e628635 100644
--- a/lms/locale/bs.po
+++ b/lms/locale/bs.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/de.po b/lms/locale/de.po
index 91c9842f..30bf52a9 100644
--- a/lms/locale/de.po
+++ b/lms/locale/de.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr "Max. Versuche"
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/eo.po b/lms/locale/eo.po
index ed735b93..b7f51f3a 100644
--- a/lms/locale/eo.po
+++ b/lms/locale/eo.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr "crwdns150150:0crwdne150150:0"
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr "crwdns150152:0crwdne150152:0"
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/es.po b/lms/locale/es.po
index 47c52864..990f9ca9 100644
--- a/lms/locale/es.po
+++ b/lms/locale/es.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr "Intentos máximos"
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr "Intentos máximos"
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/fa.po b/lms/locale/fa.po
index 47a823bf..a53d970d 100644
--- a/lms/locale/fa.po
+++ b/lms/locale/fa.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/fr.po b/lms/locale/fr.po
index 5261d43a..fb35ea76 100644
--- a/lms/locale/fr.po
+++ b/lms/locale/fr.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/hu.po b/lms/locale/hu.po
index d3438f3d..95ac9a35 100644
--- a/lms/locale/hu.po
+++ b/lms/locale/hu.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/main.pot b/lms/locale/main.pot
index 72fe300d..2364db32 100644
--- a/lms/locale/main.pot
+++ b/lms/locale/main.pot
@@ -3029,7 +3029,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/pl.po b/lms/locale/pl.po
index c82d6ab1..765a1678 100644
--- a/lms/locale/pl.po
+++ b/lms/locale/pl.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/ru.po b/lms/locale/ru.po
index 41d0d1f5..915fcb8a 100644
--- a/lms/locale/ru.po
+++ b/lms/locale/ru.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr "Максимум попыток"
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/sv.po b/lms/locale/sv.po
index 06404351..41e7d13e 100644
--- a/lms/locale/sv.po
+++ b/lms/locale/sv.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr "Maximalt antal försök"
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr "Maximalt antal försök"
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/tr.po b/lms/locale/tr.po
index ccad300a..7a2d33b1 100644
--- a/lms/locale/tr.po
+++ b/lms/locale/tr.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr "Maksimum Deneme"
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'
diff --git a/lms/locale/zh.po b/lms/locale/zh.po
index 766432a0..23d4f542 100644
--- a/lms/locale/zh.po
+++ b/lms/locale/zh.po
@@ -3031,7 +3031,7 @@ msgid "Max Attempts"
 msgstr ""
 
 #: frontend/src/pages/QuizForm.vue:58
-msgid "Maximun Attempts"
+msgid "Maximum Attempts"
 msgstr ""
 
 #. Label of the medium (Select) field in DocType 'LMS Batch'

From aaa2eea5e638b628d9d0fba56a7254fa78c93f0e Mon Sep 17 00:00:00 2001
From: Fahid Latheef Alungal <fahideng@gmail.com>
Date: Sun, 16 Feb 2025 18:19:14 +0530
Subject: [PATCH 3/6] fix: fixed incomplete router initialization in Quiz.vue
 which was allowing user to submit quiz multiple times

---
 frontend/src/utils/quiz.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/frontend/src/utils/quiz.js b/frontend/src/utils/quiz.js
index e391bc30..4781ba70 100644
--- a/frontend/src/utils/quiz.js
+++ b/frontend/src/utils/quiz.js
@@ -4,6 +4,7 @@ import { createApp, h } from 'vue'
 import { usersStore } from '../stores/user'
 import translationPlugin from '../translation'
 import { CircleHelp } from 'lucide-vue-next'
+import router from '@/router'
 
 export class Quiz {
 	constructor({ data, api, readOnly }) {
@@ -46,6 +47,7 @@ export class Quiz {
 				quiz: quiz,
 			})
 			app.use(translationPlugin)
+			app.use(router)
 			const { userResource } = usersStore()
 			app.provide('$user', userResource)
 			app.mount(this.wrapper)

From 8b1058e5777e15520f91376b810d72840802d2c1 Mon Sep 17 00:00:00 2001
From: Fahid Latheef Alungal <fahideng@gmail.com>
Date: Sun, 16 Feb 2025 18:27:38 +0530
Subject: [PATCH 4/6] fix: fixed issue in which submissions are not reflected
 gracefully until page reload

ListView throws error if initialized without emptyState which was causing the component to not reload when number of submissions was 0.
---
 frontend/src/components/Quiz.vue | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/Quiz.vue b/frontend/src/components/Quiz.vue
index b925cb7f..149e1f4b 100644
--- a/frontend/src/components/Quiz.vue
+++ b/frontend/src/components/Quiz.vue
@@ -258,14 +258,22 @@
 			</Button>
 		</div>
 		<div
-			v-if="quiz.data.show_submission_history && attempts?.data"
+			v-if="
+				quiz.data.show_submission_history &&
+				attempts?.data &&
+				attempts.data.length > 0
+			"
 			class="mt-10"
 		>
 			<ListView
 				:columns="getSubmissionColumns()"
 				:rows="attempts?.data"
 				row-key="name"
-				:options="{ selectable: false, showTooltip: false }"
+				:options="{
+					selectable: false,
+					showTooltip: false,
+					emptyState: { title: __('No Quiz submissions found') },
+				}"
 			>
 			</ListView>
 		</div>

From e374ae3229e774f3c1bfcccd3bb7e3d303f2cdd8 Mon Sep 17 00:00:00 2001
From: Fahid Latheef Alungal <fahideng@gmail.com>
Date: Sun, 16 Feb 2025 18:28:48 +0530
Subject: [PATCH 5/6] fix: fixed spelling nextQuetion -> nextQuestion

---
 frontend/src/components/Quiz.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/Quiz.vue b/frontend/src/components/Quiz.vue
index 149e1f4b..c0de8ff5 100644
--- a/frontend/src/components/Quiz.vue
+++ b/frontend/src/components/Quiz.vue
@@ -207,7 +207,7 @@
 						</Button>
 						<Button
 							v-else-if="activeQuestion != questions.length"
-							@click="nextQuetion()"
+							@click="nextQuestion()"
 						>
 							<span>
 								{{ __('Next') }}
@@ -544,7 +544,7 @@ const addToLocalStorage = () => {
 	localStorage.setItem(quiz.data.title, JSON.stringify(quizData))
 }
 
-const nextQuetion = () => {
+const nextQuestion = () => {
 	if (!quiz.data.show_answers && questionDetails.data?.type != 'Open Ended') {
 		checkAnswer()
 	} else {

From 974f67aefee327c2a3c29219a3f9d4c5b04554c9 Mon Sep 17 00:00:00 2001
From: Fahid Latheef Alungal <fahideng@gmail.com>
Date: Sun, 16 Feb 2025 19:29:03 +0530
Subject: [PATCH 6/6] fix: validate if submission exceeds the allowed limit in
 backend

---
 frontend/src/components/Quiz.vue              | 12 ++++++++++-
 .../lms_quiz_submission.py                    | 21 +++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/Quiz.vue b/frontend/src/components/Quiz.vue
index c0de8ff5..165e666f 100644
--- a/frontend/src/components/Quiz.vue
+++ b/frontend/src/components/Quiz.vue
@@ -290,7 +290,7 @@ import {
 	FormControl,
 } from 'frappe-ui'
 import { ref, watch, reactive, inject, computed } from 'vue'
-import { createToast } from '@/utils/'
+import { createToast, showToast } from '@/utils/'
 import { CheckCircle, XCircle, MinusCircle } from 'lucide-vue-next'
 import { timeAgo } from '@/utils'
 import { useRouter } from 'vue-router'
@@ -582,6 +582,16 @@ const createSubmission = () => {
 				if (quiz.data && quiz.data.max_attempts) attempts.reload()
 				if (quiz.data.duration) clearInterval(timerInterval)
 			},
+			onError(err) {
+				const errorTitle = err?.message || ''
+				if (errorTitle.includes('MaximumAttemptsExceededError')) {
+					const errorMessage = err.messages?.[0] || err
+					showToast(__('Error'), __(errorMessage), 'x')
+					setTimeout(() => {
+						window.location.reload()
+					}, 3000)
+				}
+			},
 		}
 	)
 }
diff --git a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.py b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.py
index 0618eb2b..b643ea54 100644
--- a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.py
+++ b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.py
@@ -10,12 +10,29 @@ from frappe.desk.doctype.notification_log.notification_log import make_notificat
 
 class LMSQuizSubmission(Document):
 	def validate(self):
+		self.validate_if_max_attempts_exceeded()
 		self.validate_marks()
 		self.set_percentage()
 
 	def on_update(self):
 		self.notify_member()
 
+	def validate_if_max_attempts_exceeded(self):
+		max_attempts = frappe.db.get_value("LMS Quiz", self.quiz, ["max_attempts"])
+		if max_attempts == 0:
+			return
+
+		current_user_submission_count = frappe.db.count(
+			self.doctype, filters={"quiz": self.quiz, "member": frappe.session.user}
+		)
+		if current_user_submission_count >= max_attempts:
+			frappe.throw(
+				_("You have exceeded the maximum number of attempts ({0}) for this quiz").format(
+					max_attempts
+				),
+				MaximumAttemptsExceededError,
+			)
+
 	def validate_marks(self):
 		self.score = 0
 		for row in self.result:
@@ -52,3 +69,7 @@ class LMSQuizSubmission(Document):
 			)
 
 			make_notification_logs(notification, [self.member])
+
+
+class MaximumAttemptsExceededError(frappe.DuplicateEntryError):
+	pass