From 6f50242f5ac13c8c173fb9f1be531f813a6e3957 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Sat, 31 May 2025 11:52:25 +0530
Subject: [PATCH] fix: misc issues

---
 frontend/src/components/Settings/Settings.vue     |  4 ++--
 frontend/src/components/SidebarLink.vue           |  2 +-
 frontend/src/pages/Jobs.vue                       |  8 ++++----
 lms/lms/api.py                                    |  2 +-
 lms/lms/doctype/lms_settings/lms_settings.json    | 10 +++++++++-
 lms/patches.txt                                   |  3 ++-
 lms/patches/v2_0/move_zoom_settings.py            |  4 ++++
 lms/patches/v2_0/sidebar_for_certified_members.py | 10 ++++++++++
 8 files changed, 33 insertions(+), 10 deletions(-)
 create mode 100644 lms/patches/v2_0/sidebar_for_certified_members.py

diff --git a/frontend/src/components/Settings/Settings.vue b/frontend/src/components/Settings/Settings.vue
index b88abd0c..e06e8755 100644
--- a/frontend/src/components/Settings/Settings.vue
+++ b/frontend/src/components/Settings/Settings.vue
@@ -293,8 +293,8 @@ const tabsStructure = computed(() => {
 							type: 'checkbox',
 						},
 						{
-							label: 'Certified Participants',
-							name: 'certified_participants',
+							label: 'Certified Members',
+							name: 'certified_members',
 							type: 'checkbox',
 						},
 						{
diff --git a/frontend/src/components/SidebarLink.vue b/frontend/src/components/SidebarLink.vue
index 11777b45..2522cc40 100644
--- a/frontend/src/components/SidebarLink.vue
+++ b/frontend/src/components/SidebarLink.vue
@@ -61,7 +61,7 @@
 	</button>
 </template>
 <script setup>
-import { Tooltip, Button } from 'frappe-ui'
+import { Tooltip } from 'frappe-ui'
 import { computed } from 'vue'
 import { useRouter } from 'vue-router'
 import * as icons from 'lucide-vue-next'
diff --git a/frontend/src/pages/Jobs.vue b/frontend/src/pages/Jobs.vue
index 210590b0..dccbbe07 100644
--- a/frontend/src/pages/Jobs.vue
+++ b/frontend/src/pages/Jobs.vue
@@ -125,6 +125,9 @@ onMounted(() => {
 const jobs = createResource({
 	url: 'lms.lms.api.get_job_opportunities',
 	cache: ['jobs'],
+	onSuccess(data) {
+		jobCount.value = data.length
+	},
 })
 
 const updateJobs = () => {
@@ -168,10 +171,7 @@ const updateFilters = () => {
 const getJobCount = () => {
 	call('lms.lms.api.get_count', {
 		doctype: 'Job Opportunity',
-		filters: {
-			status: 'Open',
-			disabled: 0,
-		},
+		filters: filters.value,
 	}).then((data) => {
 		jobCount.value = data
 	})
diff --git a/lms/lms/api.py b/lms/lms/api.py
index 6731cebb..dd79b5b7 100644
--- a/lms/lms/api.py
+++ b/lms/lms/api.py
@@ -552,7 +552,7 @@ def get_sidebar_settings():
 	items = [
 		"courses",
 		"batches",
-		"certified_participants",
+		"certified_members",
 		"jobs",
 		"statistics",
 		"notifications",
diff --git a/lms/lms/doctype/lms_settings/lms_settings.json b/lms/lms/doctype/lms_settings/lms_settings.json
index f2dd3ee5..d1984e6e 100644
--- a/lms/lms/doctype/lms_settings/lms_settings.json
+++ b/lms/lms/doctype/lms_settings/lms_settings.json
@@ -35,6 +35,7 @@
   "courses",
   "batches",
   "certified_participants",
+  "certified_members",
   "column_break_exdz",
   "jobs",
   "statistics",
@@ -277,6 +278,7 @@
    "default": "1",
    "fieldname": "certified_participants",
    "fieldtype": "Check",
+   "hidden": 1,
    "label": "Certified Participants"
   },
   {
@@ -397,13 +399,19 @@
    "fieldtype": "Check",
    "label": "Persona Captured",
    "read_only": 1
+  },
+  {
+   "default": "0",
+   "fieldname": "certified_members",
+   "fieldtype": "Check",
+   "label": "Certified Members"
   }
  ],
  "grid_page_length": 50,
  "index_web_pages_for_search": 1,
  "issingle": 1,
  "links": [],
- "modified": "2025-05-14 12:43:22.749850",
+ "modified": "2025-05-30 19:02:51.381668",
  "modified_by": "sayali@frappe.io",
  "module": "LMS",
  "name": "LMS Settings",
diff --git a/lms/patches.txt b/lms/patches.txt
index 63580a31..705b09e2 100644
--- a/lms/patches.txt
+++ b/lms/patches.txt
@@ -106,4 +106,5 @@ lms.patches.v2_0.update_job_city_and_country
 lms.patches.v2_0.update_course_evaluator_data
 lms.patches.v2_0.move_zoom_settings #20-05-2025
 lms.patches.v2_0.link_zoom_account_to_live_class
-lms.patches.v2_0.link_zoom_account_to_batch
\ No newline at end of file
+lms.patches.v2_0.link_zoom_account_to_batch
+lms.patches.v2_0.sidebar_for_certified_members
\ No newline at end of file
diff --git a/lms/patches/v2_0/move_zoom_settings.py b/lms/patches/v2_0/move_zoom_settings.py
index 56693c89..99f6f6a1 100644
--- a/lms/patches/v2_0/move_zoom_settings.py
+++ b/lms/patches/v2_0/move_zoom_settings.py
@@ -7,6 +7,10 @@ def execute():
 
 def create_settings():
 	current_settings = frappe.get_single("Zoom Settings")
+
+	if not current_settings.enable:
+		return
+
 	member = current_settings.owner
 	member_name = frappe.get_value("User", member, "full_name")
 
diff --git a/lms/patches/v2_0/sidebar_for_certified_members.py b/lms/patches/v2_0/sidebar_for_certified_members.py
new file mode 100644
index 00000000..b6fb7e37
--- /dev/null
+++ b/lms/patches/v2_0/sidebar_for_certified_members.py
@@ -0,0 +1,10 @@
+import frappe
+
+
+def execute():
+	show_certified_members = frappe.db.get_single_value(
+		"LMS Settings", "certified_participants"
+	)
+
+	if show_certified_members:
+		frappe.db.set_single_value("LMS Settings", "certified_members", 1)