From 6f9f27c030cd5d6004606cdeb80bde112a499919 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 10 Jul 2025 22:21:26 +0530
Subject: [PATCH] fix: delete batch and pass fields prop to brand settings

---
 frontend/src/components/BatchOverlay.vue      | 26 ++++++++-
 .../Modals/CourseProgressSummary.vue          | 33 +++++++----
 .../src/components/Settings/BrandSettings.vue | 30 ++++++++--
 frontend/src/components/Settings/Settings.vue |  9 ++-
 frontend/src/pages/BatchForm.vue              | 56 +++++++++++++++++--
 lms/lms/api.py                                | 25 ++++++++-
 6 files changed, 152 insertions(+), 27 deletions(-)

diff --git a/frontend/src/components/BatchOverlay.vue b/frontend/src/components/BatchOverlay.vue
index 5906a25b..fdd3a893 100644
--- a/frontend/src/components/BatchOverlay.vue
+++ b/frontend/src/components/BatchOverlay.vue
@@ -65,6 +65,10 @@
 				}"
 			>
 				<Button variant="solid" class="w-full mt-4">
+					<template #prefix>
+						<Settings v-if="isModerator" class="size-4 stroke-1.5" />
+						<LogIn v-else class="size-4 stroke-1.5" />
+					</template>
 					<span>
 						{{ isModerator ? __('Manage Batch') : __('Visit Batch') }}
 					</span>
@@ -85,6 +89,9 @@
 				"
 			>
 				<Button v-if="!isStudent" class="w-full mt-4" variant="solid">
+					<template #prefix>
+						<CreditCard class="size-4 stroke-1.5" />
+					</template>
 					<span>
 						{{ __('Register Now') }}
 					</span>
@@ -100,6 +107,9 @@
 				"
 				@click="enrollInBatch()"
 			>
+				<template #prefix>
+					<GraduationCap class="size-4 stroke-1.5" />
+				</template>
 				{{ __('Enroll Now') }}
 			</Button>
 			<router-link
@@ -112,6 +122,9 @@
 				}"
 			>
 				<Button class="w-full mt-2">
+					<template #prefix>
+						<Pencil class="size-4 stroke-1.5" />
+					</template>
 					<span>
 						{{ __('Edit') }}
 					</span>
@@ -122,8 +135,17 @@
 </template>
 <script setup>
 import { inject, computed } from 'vue'
-import { Badge, Button, createResource, toast } from 'frappe-ui'
-import { BookOpen, Clock, Globe } from 'lucide-vue-next'
+import { Button, createResource, toast } from 'frappe-ui'
+import {
+	BookOpen,
+	Clock,
+	CreditCard,
+	Globe,
+	GraduationCap,
+	LogIn,
+	Pencil,
+	Settings,
+} from 'lucide-vue-next'
 import { formatNumberIntoCurrency, formatTime } from '@/utils'
 import DateRange from '@/components/Common/DateRange.vue'
 import { useRouter } from 'vue-router'
diff --git a/frontend/src/components/Modals/CourseProgressSummary.vue b/frontend/src/components/Modals/CourseProgressSummary.vue
index c87de333..99082126 100644
--- a/frontend/src/components/Modals/CourseProgressSummary.vue
+++ b/frontend/src/components/Modals/CourseProgressSummary.vue
@@ -7,17 +7,17 @@
 		}"
 	>
 		<template #body-content>
-			<div class="flex justify-between space-x-10 text-base">
+			<div class="flex justify-between space-x-10 text-base mt-10">
 				<div class="w-full">
 					<div class="flex items-center justify-between space-x-5 mb-4">
-						<div class="text-xl font-semibold text-ink-gray-6">
+						<!-- <div class="text-xl font-semibold text-ink-gray-6">
 							{{ __('{0} Members').format(memberCount) }}
-						</div>
+						</div> -->
 						<FormControl
 							v-model="searchFilter"
-							:label="__('Search by Member Name')"
+							:placeholder="__('Search by Member Name')"
 							type="text"
-							class="w-1/2"
+							class="w-full"
 						/>
 					</div>
 					<div class="max-h-[70vh] overflow-y-auto">
@@ -90,13 +90,22 @@
 					</div>
 				</div>
 				<div class="mb-4 self-start w-full space-y-5">
-					<NumberChart
-						class="border rounded-md"
-						:config="{
-							title: __('Average Progress %'),
-							value: chartDetails.data?.average_progress || 0,
-						}"
-					/>
+					<div class="flex items-center space-x-4">
+						<NumberChart
+							class="border rounded-md w-full"
+							:config="{
+								title: __('Enrollments'),
+								value: memberCount || 0,
+							}"
+						/>
+						<NumberChart
+							class="border rounded-md w-full"
+							:config="{
+								title: __('Average Progress %'),
+								value: chartDetails.data?.average_progress || 0,
+							}"
+						/>
+					</div>
 					<DonutChart
 						:config="{
 							data: chartDetails.data?.progress_distribution || [],
diff --git a/frontend/src/components/Settings/BrandSettings.vue b/frontend/src/components/Settings/BrandSettings.vue
index 2f6a69fe..98f76c6d 100644
--- a/frontend/src/components/Settings/BrandSettings.vue
+++ b/frontend/src/components/Settings/BrandSettings.vue
@@ -88,9 +88,31 @@ const update = () => {
 	)
 }
 
-watch(branding, (newData) => {
-	if (newData && !isDirty.value) {
-		isDirty.value = true
-	}
+watch(branding, (updatedDoc) => {
+	let textFields = []
+	let imageFields = []
+
+	props.fields.forEach((f) => {
+		if (f.type === 'Upload') {
+			imageFields.push(f.name)
+		} else {
+			textFields.push(f.name)
+		}
+	})
+
+	textFields.forEach((field) => {
+		if (updatedDoc.data[field] != updatedDoc.previousData[field]) {
+			isDirty.value = true
+		}
+	})
+
+	imageFields.forEach((field) => {
+		if (
+			updatedDoc.data[field] &&
+			updatedDoc.data[field].file_url != updatedDoc.previousData[field].file_url
+		) {
+			isDirty.value = true
+		}
+	})
 })
 </script>
diff --git a/frontend/src/components/Settings/Settings.vue b/frontend/src/components/Settings/Settings.vue
index 0501733e..86826bcf 100644
--- a/frontend/src/components/Settings/Settings.vue
+++ b/frontend/src/components/Settings/Settings.vue
@@ -37,8 +37,13 @@
 					<component
 						v-if="activeTab.template"
 						:is="activeTab.template"
-						:label="activeTab.label"
-						:description="activeTab.description"
+						v-bind="{
+							label: activeTab.label,
+							description: activeTab.description,
+							...(activeTab.label === 'Branding'
+								? { fields: activeTab.fields }
+								: {}),
+						}"
 					/>
 					<PaymentSettings
 						v-else-if="activeTab.label === 'Payment Gateway'"
diff --git a/frontend/src/pages/BatchForm.vue b/frontend/src/pages/BatchForm.vue
index 140147c3..ca21cf5d 100644
--- a/frontend/src/pages/BatchForm.vue
+++ b/frontend/src/pages/BatchForm.vue
@@ -4,9 +4,16 @@
 			class="sticky top-0 z-10 flex items-center justify-between border-b bg-surface-white px-3 py-2.5 sm:px-5"
 		>
 			<Breadcrumbs class="h-7" :items="breadcrumbs" />
-			<Button variant="solid" @click="saveBatch()">
-				{{ __('Save') }}
-			</Button>
+			<div class="flex items-center space-x-2">
+				<Button v-if="batchDetail.data?.name" @click="deleteBatch">
+					<template #icon>
+						<Trash2 class="size-4 stroke-1.5" />
+					</template>
+				</Button>
+				<Button variant="solid" @click="saveBatch()">
+					{{ __('Save') }}
+				</Button>
+			</div>
 		</header>
 		<div class="py-5">
 			<div class="px-20 pb-5 space-y-5 border-b mb-5">
@@ -303,10 +310,11 @@
 <script setup>
 import {
 	computed,
-	onMounted,
+	getCurrentInstance,
 	inject,
-	reactive,
+	onMounted,
 	onBeforeUnmount,
+	reactive,
 	ref,
 } from 'vue'
 import {
@@ -318,9 +326,11 @@ import {
 	createResource,
 	usePageMeta,
 	toast,
+	call,
+	Toast,
 } from 'frappe-ui'
 import { useRouter } from 'vue-router'
-import { Image } from 'lucide-vue-next'
+import { Image, Trash2 } from 'lucide-vue-next'
 import { capture } from '@/telemetry'
 import { useOnboarding } from 'frappe-ui/frappe'
 import { sessionStore } from '../stores/session'
@@ -338,6 +348,8 @@ const user = inject('$user')
 const { brand } = sessionStore()
 const { updateOnboardingStep } = useOnboarding('learning')
 const instructors = ref([])
+const app = getCurrentInstance()
+const { $dialog } = app.appContext.config.globalProperties
 
 const props = defineProps({
 	batchName: {
@@ -539,6 +551,38 @@ const editBatchDetails = () => {
 	)
 }
 
+const deleteBatch = () => {
+	$dialog({
+		title: __('Confirm your action to delete'),
+		message: __(
+			'Deleting this batch will also delete all its data including enrolled students, linked courses, assessments, feedback and discussions. Are you sure you want to continue?'
+		),
+		actions: [
+			{
+				label: __('Delete'),
+				theme: 'red',
+				variant: 'solid',
+				onClick({ close }) {
+					trashBatch(close)
+					close()
+				},
+			},
+		],
+	})
+}
+
+const trashBatch = (close) => {
+	call('lms.lms.api.delete_batch', {
+		batch: props.batchName,
+	}).then(() => {
+		toast.success(__('Batch deleted successfully'))
+		close()
+		router.push({
+			name: 'Batches',
+		})
+	})
+}
+
 const saveImage = (file) => {
 	batch.image = file
 }
diff --git a/lms/lms/api.py b/lms/lms/api.py
index f14fe99e..03c9f154 100644
--- a/lms/lms/api.py
+++ b/lms/lms/api.py
@@ -990,7 +990,30 @@ def delete_course(course):
 	frappe.delete_doc("LMS Course", course)
 
 
-def give_dicussions_permission():
+@frappe.whitelist()
+def delete_batch(batch):
+	frappe.db.delete("LMS Batch Enrollment", {"batch": batch})
+	frappe.db.delete("Batch Course", {"parent": batch, "parenttype": "LMS Batch"})
+	frappe.db.delete("LMS Assessment", {"parent": batch, "parenttype": "LMS Batch"})
+	frappe.db.delete("LMS Batch Timetable", {"parent": batch, "parenttype": "LMS Batch"})
+	frappe.db.delete("LMS Batch Feedback", {"batch": batch})
+	delete_batch_discussions(batch)
+	frappe.db.delete("LMS Batch", batch)
+
+
+def delete_batch_discussions(batch):
+	topics = frappe.get_all(
+		"Discussion Topic",
+		{"reference_doctype": "LMS Batch", "reference_docname": batch},
+		pluck="name",
+	)
+
+	for topic in topics:
+		frappe.db.delete("Discussion Reply", {"topic": topic})
+		frappe.db.delete("Discussion Topic", topic)
+
+
+def give_discussions_permission():
 	doctypes = ["Discussion Topic", "Discussion Reply"]
 	roles = ["LMS Student", "Course Creator", "Moderator", "Batch Evaluator"]
 	for doctype in doctypes: