From 75cea1ab78fdfa9a16ebe06277a5f9f60e736890 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 13 Feb 2025 17:21:14 +0530
Subject: [PATCH] fix: delete unused custom fields from web form

---
 lms/fixtures/custom_field.json                | 504 ------------------
 lms/patches.txt                               |   3 +-
 .../v2_0/delete_unused_custom_fields.py       |  13 +
 3 files changed, 15 insertions(+), 505 deletions(-)
 create mode 100644 lms/patches/v2_0/delete_unused_custom_fields.py

diff --git a/lms/fixtures/custom_field.json b/lms/fixtures/custom_field.json
index 67585780..74e660fa 100644
--- a/lms/fixtures/custom_field.json
+++ b/lms/fixtures/custom_field.json
@@ -951,62 +951,6 @@
   "unique": 0,
   "width": null
  },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": null,
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "payments_tab",
-  "fieldtype": "Tab Break",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "custom_css",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Payments",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.329032",
-  "module": null,
-  "name": "Web Form-payments_tab",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
  {
   "allow_in_quick_entry": 0,
   "allow_on_submit": 0,
@@ -1119,230 +1063,6 @@
   "unique": 0,
   "width": null
  },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": "accept_payment",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "payment_gateway",
-  "fieldtype": "Link",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "accept_payment",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Payment Gateway",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.408659",
-  "module": null,
-  "name": "Web Form-payment_gateway",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": "Payment Gateway",
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": "Buy Now",
-  "depends_on": "accept_payment",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "payment_button_label",
-  "fieldtype": "Data",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "payment_gateway",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Button Label",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.439246",
-  "module": null,
-  "name": "Web Form-payment_button_label",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": null,
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "payments_cb",
-  "fieldtype": "Column Break",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "payment_button_help",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": null,
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.491696",
-  "module": null,
-  "name": "Web Form-payments_cb",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": "eval:doc.accept_payment && !doc.amount_based_on_field",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "amount",
-  "fieldtype": "Currency",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "amount_field",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Amount",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.569591",
-  "module": null,
-  "name": "Web Form-amount",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
  {
   "allow_in_quick_entry": 0,
   "allow_on_submit": 0,
@@ -1399,174 +1119,6 @@
   "unique": 0,
   "width": null
  },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": "accept_payment",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "payment_button_help",
-  "fieldtype": "Text",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "payment_button_label",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Button Help",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.466744",
-  "module": null,
-  "name": "Web Form-payment_button_help",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": "0",
-  "depends_on": "accept_payment",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "amount_based_on_field",
-  "fieldtype": "Check",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "payments_cb",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Amount Based On Field",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.517344",
-  "module": null,
-  "name": "Web Form-amount_based_on_field",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": "eval:doc.accept_payment && doc.amount_based_on_field",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "amount_field",
-  "fieldtype": "Select",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "amount_based_on_field",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Amount Field",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.543136",
-  "module": null,
-  "name": "Web Form-amount_field",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": null,
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
  {
   "allow_in_quick_entry": 0,
   "allow_on_submit": 0,
@@ -1679,62 +1231,6 @@
   "unique": 0,
   "width": null
  },
- {
-  "allow_in_quick_entry": 0,
-  "allow_on_submit": 0,
-  "bold": 0,
-  "collapsible": 0,
-  "collapsible_depends_on": null,
-  "columns": 0,
-  "default": null,
-  "depends_on": "accept_payment",
-  "description": null,
-  "docstatus": 0,
-  "doctype": "Custom Field",
-  "dt": "Web Form",
-  "fetch_from": null,
-  "fetch_if_empty": 0,
-  "fieldname": "currency",
-  "fieldtype": "Link",
-  "hidden": 0,
-  "hide_border": 0,
-  "hide_days": 0,
-  "hide_seconds": 0,
-  "ignore_user_permissions": 0,
-  "ignore_xss_filter": 0,
-  "in_global_search": 0,
-  "in_list_view": 0,
-  "in_preview": 0,
-  "in_standard_filter": 0,
-  "insert_after": "amount",
-  "is_system_generated": 1,
-  "is_virtual": 0,
-  "label": "Currency",
-  "length": 0,
-  "link_filters": null,
-  "mandatory_depends_on": null,
-  "modified": "2024-09-19 08:35:17.595419",
-  "module": null,
-  "name": "Web Form-currency",
-  "no_copy": 0,
-  "non_negative": 0,
-  "options": "Currency",
-  "permlevel": 0,
-  "precision": "",
-  "print_hide": 0,
-  "print_hide_if_no_value": 0,
-  "print_width": null,
-  "read_only": 0,
-  "read_only_depends_on": null,
-  "report_hide": 0,
-  "reqd": 0,
-  "search_index": 0,
-  "show_dashboard": 0,
-  "sort_options": 0,
-  "translatable": 0,
-  "unique": 0,
-  "width": null
- },
  {
   "allow_in_quick_entry": 0,
   "allow_on_submit": 0,
diff --git a/lms/patches.txt b/lms/patches.txt
index 2fd46b79..5dd122a8 100644
--- a/lms/patches.txt
+++ b/lms/patches.txt
@@ -99,4 +99,5 @@ lms.patches.v2_0.update_quiz_submission_data
 lms.patches.v2_0.convert_quiz_duration_to_minutes
 lms.patches.v2_0.allow_guest_access #05-02-2025
 lms.patches.v2_0.migrate_batch_student_data #10-02-2025
-lms.patches.v2_0.delete_old_enrollment_doctypes
\ No newline at end of file
+lms.patches.v2_0.delete_old_enrollment_doctypes
+lms.patches.v2_0.delete_unused_custom_fields
\ No newline at end of file
diff --git a/lms/patches/v2_0/delete_unused_custom_fields.py b/lms/patches/v2_0/delete_unused_custom_fields.py
new file mode 100644
index 00000000..d49fe615
--- /dev/null
+++ b/lms/patches/v2_0/delete_unused_custom_fields.py
@@ -0,0 +1,13 @@
+import frappe
+
+def execute():
+    if "payments" not in frappe.get_installed_apps():
+        web_form_custom_fields = frappe.get_all("Custom Field", {
+            "dt": "Web Form"
+        }, ["name", "fieldname"])
+
+        unused_fields = ["currency", "amount_field", "amount_based_on_field", "payment_button_help", "amount", "payments_cb", "payment_button_label", "payment_gateway", "payments_tab"]
+
+        for field in web_form_custom_fields:
+            if field.fieldname in unused_fields:
+                frappe.delete_doc("Custom Field", field.name)
\ No newline at end of file