fix: edit permission and other issues

frontend/src/pages/CreateCourse.vue

@@ -126,7 +126,10 @@
 						<div class="text-lg font-semibold mt-5 mb-4">
 							{{ __('Settings') }}
 						</div>
-						<div class="flex items-center justify-between mb-4">
+						<div
+							v-if="user.data?.is_moderator"
+							class="flex items-center justify-between mb-4"
+						>
 							<FormControl
 								type="checkbox"
 								v-model="course.published"
@@ -207,6 +210,7 @@ import CourseOutline from '@/components/CourseOutline.vue'
 const user = inject('$user')
 const newTag = ref('')
 const router = useRouter()
+const instructors = ref([])
 
 const props = defineProps({
 	courseName: {
@@ -231,9 +235,14 @@ const course = reactive({
 })
 
 onMounted(() => {
-	if (!user.data?.is_moderator && !user.data?.is_instructor) {
+	if (
+		props.courseName == 'new' &&
+		!user.data?.is_moderator &&
+		!user.data?.is_instructor
+	) {
 		router.push({ name: 'Courses' })
 	}
+
 	if (props.courseName !== 'new') {
 		courseResource.reload()
 	}
@@ -245,7 +254,7 @@ const courseCreationResource = createResource({
 		return {
 			doc: {
 				doctype: 'LMS Course',
-				image: course.course_image.file_url,
+				image: course.course_image?.file_url || '',
 				...values,
 			},
 		}
@@ -260,7 +269,7 @@ const courseEditResource = createResource({
 			doctype: 'LMS Course',
 			name: values.course,
 			fieldname: {
-				image: course.course_image.file_url,
+				image: course.course_image?.file_url || '',
 				...course,
 			},
 		}
@@ -292,6 +301,8 @@ const courseResource = createResource({
 		}
 
 		if (data.image) imageResource.reload({ image: data.image })
+		instructors.value = data.instructors
+		check_permission()
 	},
 })
 
@@ -397,6 +408,21 @@ const removeImage = () => {
 	course.course_image = null
 }
 
+const check_permission = () => {
+	let user_is_instructor = false
+	if (user.data?.is_moderator) return
+
+	instructors.value.forEach((instructor) => {
+		if (!user_is_instructor && instructor.instructor == user.data?.name) {
+			user_is_instructor = true
+		}
+	})
+
+	if (!user_is_instructor) {
+		router.push({ name: 'Courses' })
+	}
+}
+
 const breadcrumbs = computed(() => {
 	let crumbs = [
 		{