From 81e287ffe5f4e588ee7bf114fd40ea138f9fd075 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 10 Feb 2025 17:31:11 +0530 Subject: [PATCH 1/2] fix: check for duplicates before creating batch enrollment in patch --- lms/patches.txt | 2 +- .../v2_0/migrate_batch_student_data.py | 21 +++++++++---------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/lms/patches.txt b/lms/patches.txt index cbe31163..d3f6ba5b 100644 --- a/lms/patches.txt +++ b/lms/patches.txt @@ -98,4 +98,4 @@ lms.patches.v2_0.update_desk_access_for_lms_roles lms.patches.v2_0.update_quiz_submission_data lms.patches.v2_0.convert_quiz_duration_to_minutes lms.patches.v2_0.allow_guest_access #05-02-2025 -lms.patches.v2_0.migrate_batch_student_data \ No newline at end of file +lms.patches.v2_0.migrate_batch_student_data #10-02-2025 \ No newline at end of file diff --git a/lms/patches/v2_0/migrate_batch_student_data.py b/lms/patches/v2_0/migrate_batch_student_data.py index 103507ab..b71dfb3d 100644 --- a/lms/patches/v2_0/migrate_batch_student_data.py +++ b/lms/patches/v2_0/migrate_batch_student_data.py @@ -16,14 +16,13 @@ def execute(): ) for student in students: - doc = frappe.new_doc("LMS Batch Enrollment") - doc.member = student.student - doc.member_name = student.student_name - doc.member_username = student.username - doc.payment = student.payment - doc.source = student.source - doc.batch = student.parent - doc.confirmation_email_sent = student.confirmation_email_sent - doc.save() - - frappe.delete_doc("DocType", "Batch Student") + if not frappe.db.exists("LMS Batch Enrollment", {"member": student.student, "batch": student.parent}): + doc = frappe.new_doc("LMS Batch Enrollment") + doc.member = student.student + doc.member_name = student.student_name + doc.member_username = student.username + doc.payment = student.payment + doc.source = student.source + doc.batch = student.parent + doc.confirmation_email_sent = student.confirmation_email_sent + doc.save() \ No newline at end of file From 8f643dae27e52f378aa36a828ac0346506db293f Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 10 Feb 2025 17:37:08 +0530 Subject: [PATCH 2/2] style: fix formatting --- lms/patches/v2_0/migrate_batch_student_data.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lms/patches/v2_0/migrate_batch_student_data.py b/lms/patches/v2_0/migrate_batch_student_data.py index b71dfb3d..4bd03728 100644 --- a/lms/patches/v2_0/migrate_batch_student_data.py +++ b/lms/patches/v2_0/migrate_batch_student_data.py @@ -16,7 +16,9 @@ def execute(): ) for student in students: - if not frappe.db.exists("LMS Batch Enrollment", {"member": student.student, "batch": student.parent}): + if not frappe.db.exists( + "LMS Batch Enrollment", {"member": student.student, "batch": student.parent} + ): doc = frappe.new_doc("LMS Batch Enrollment") doc.member = student.student doc.member_name = student.student_name @@ -25,4 +27,4 @@ def execute(): doc.source = student.source doc.batch = student.parent doc.confirmation_email_sent = student.confirmation_email_sent - doc.save() \ No newline at end of file + doc.save()