eduvia/lms
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: test for community member and lms course

Browse Source
This commit is contained in:
pateljannat
2021-04-28 17:52:12 +05:30
parent 7b142fd72d
commit 7a40b3e7a5
3 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
community/community/doctype/community_member/community_member.py
View File

@@ -32,12 +32,13 @@ class CommunityMember(Document):
return f"<CommunityMember: {self.email}>" return f"<CommunityMember: {self.email}>"
def create_member_from_user(doc, method): def create_member_from_user(doc, method):
username = doc.username
if ( doc.username and username_exists(doc.username)) or not doc.username: if ( doc.username and username_exists(doc.username)) or not doc.username:
username = create_username_from_email(doc.email) username = create_username_from_email(doc.email)
if len(doc.username) < 4: elif len(doc.username) < 4:
username = adjust_username(doc.username) username = adjust_username(doc.username)
if username_exists(username): if username_exists(username):
username = username + str(random.randint(0,9)) username = username + str(random.randint(0,9))
member = frappe.get_doc({ member = frappe.get_doc({
"doctype": "Community Member", "doctype": "Community Member",

19
community/community/doctype/community_member/test_community_member.py
View File

@@ -7,11 +7,14 @@ import frappe
import unittest import unittest
class TestCommunityMember(unittest.TestCase): class TestCommunityMember(unittest.TestCase):
def test_member_created_from_user(self): def test_member_created_from_user(self):
user = new_user("Test User", "test_user@example.com") user = new_user("Test User", "test_user@example.com")
member = frappe.get_doc("Community Member", {"email": "test_user@example.com"}) self.assertTrue(frappe.db.exists("Community Member", dict(username=user.username)))
self.assertEqual(user.full_name, member.full_name) member = frappe.get_doc("Community Member", {"email": "test_user@example.com"})
self.assertEqual(member.owner, user.email) self.assertEqual(user.full_name, member.full_name)
self.assertEqual(user.username, member.username) self.assertEqual(member.owner, user.email)
self.assertEqual(member.username, member.route) self.assertEqual(user.username, member.username)
self.assertEqual(member.username, member.route)
frappe.delete_doc("User", user.name)

3
community/lms/doctype/lms_course/test_lms_course.py
View File

@@ -11,7 +11,6 @@ class TestLMSCourse(unittest.TestCase):
frappe.db.sql('delete from `tabLMS Course Mentor Mapping`') frappe.db.sql('delete from `tabLMS Course Mentor Mapping`')
frappe.db.sql('delete from `tabLMS Course`') frappe.db.sql('delete from `tabLMS Course`')
frappe.db.sql('delete from `tabCommunity Member`') frappe.db.sql('delete from `tabCommunity Member`')
frappe.db.sql('delete from `tabUser` where email like "%@example.com"')
def new_course(self, title): def new_course(self, title):
doc = frappe.get_doc({ doc = frappe.get_doc({
@@ -27,7 +26,6 @@ class TestLMSCourse(unittest.TestCase):
assert course.slug == "test-course" assert course.slug == "test-course"
assert course.get_mentors() == [] assert course.get_mentors() == []
# disabled this test as it is failing
def _test_add_mentors(self): def _test_add_mentors(self):
course = self.new_course("Test Course") course = self.new_course("Test Course")
assert course.get_mentors() == [] assert course.get_mentors() == []
@@ -38,6 +36,7 @@ class TestLMSCourse(unittest.TestCase):
mentors = course.get_mentors() mentors = course.get_mentors()
mentors_data = [dict(email=mentor.email, batch_count=mentor.batch_count) for mentor in mentors] mentors_data = [dict(email=mentor.email, batch_count=mentor.batch_count) for mentor in mentors]
assert mentors_data == [{"email": "tester@example.com", "batch_count": 0}] assert mentors_data == [{"email": "tester@example.com", "batch_count": 0}]
frappe.delete_doc("User", user.name)
def new_user(name, email): def new_user(name, email):
doc = frappe.get_doc(dict( doc = frappe.get_doc(dict(