From cceff77bc202ea4f451bd7753ffc3e69ba029708 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 4 Mar 2025 17:24:03 +0530 Subject: [PATCH] fix: don't send payment reminder if member has already paid later --- lms/lms/doctype/lms_payment/lms_payment.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lms/lms/doctype/lms_payment/lms_payment.py b/lms/lms/doctype/lms_payment/lms_payment.py index 187c2a9a..1378f4e3 100644 --- a/lms/lms/doctype/lms_payment/lms_payment.py +++ b/lms/lms/doctype/lms_payment/lms_payment.py @@ -33,9 +33,24 @@ def send_payment_reminder(): ) for payment in incomplete_payments: + if has_paid_later(payment): + continue + send_mail(payment) +def has_paid_later(payment): + return frappe.db.exists( + "LMS Payment", + { + "member": payment.member, + "payment_received": 1, + "payment_for_document": payment.payment_for_document, + "payment_for_document_type": payment.payment_for_document_type, + }, + ) + + def send_mail(payment): subject = _("Complete Your Enrollment - Don't miss out!") template = "payment_reminder"