From 13536aac5168ba9b977daf9e6e92aaa42bde1cc8 Mon Sep 17 00:00:00 2001
From: Md Hussain Nagaria <34810212+NagariaHussain@users.noreply.github.com>
Date: Tue, 9 Apr 2024 15:33:10 +0530
Subject: [PATCH 1/3] fix: primary page title (#767)

---
 frontend/index.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/index.html b/frontend/index.html
index 699934fe..1512b016 100644
--- a/frontend/index.html
+++ b/frontend/index.html
@@ -4,7 +4,7 @@
 		<meta charset="UTF-8" />
 		<link rel="icon" href="/favicon.png" />
 		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
-		<title>Frappe UI App</title>
+		<title>Frappe Learning</title>
 		<meta name="title" content="{{ meta.title }}" />
 		<meta name="image" content="{{ meta.image }}" />
 		<meta name="description" content="{{ meta.description }}" />
@@ -30,7 +30,7 @@
 					Seo checks if a page has more than 300 words. So, here are some more words to make it more than 300 words.
 					Page descriptions are the HTML meta tags that provide a brief summary of a web page.
 					Search engines use meta descriptions to help identify the page's topic - they don't use them to rank the page, but they do use them to determine whether or not to display the page in search results.
-					Meta descriptions are important because they're often the first thing people see when they're deciding which search result to click on. 
+					Meta descriptions are important because they're often the first thing people see when they're deciding which search result to click on.
 					They're also important because they can help improve your click-through rate (CTR) from search results.
 					A good meta description can entice people to click on your page instead of someone else's.
 				</p>

From 20fab8dbd3fbd58afaed936503d88d47333f8014 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Wed, 10 Apr 2024 19:38:30 +0530
Subject: [PATCH 2/3] fix: check site conf before sending email

---
 frontend/src/components/LessonPlugins.vue     | 21 +++++++++++++------
 .../lms_job_application.py                    |  2 +-
 .../lms_assignment_submission.py              |  2 +-
 lms/lms/doctype/lms_batch/lms_batch.py        |  4 +++-
 .../lms_certificate/lms_certificate.py        |  2 +-
 5 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/frontend/src/components/LessonPlugins.vue b/frontend/src/components/LessonPlugins.vue
index 6c528c77..a7d83112 100644
--- a/frontend/src/components/LessonPlugins.vue
+++ b/frontend/src/components/LessonPlugins.vue
@@ -3,12 +3,21 @@
 		{{ __('Components') }}
 	</div>
 	<div class="mt-5">
-		<div class="">
-			<div class="text-xs text-gray-600 mb-1">
-				{{ __('Select an Editor') }}
+		<Tooltip
+			:text="
+				__(
+					'Content such as quiz, video and image will be added in the editor you select.'
+				)
+			"
+			placement="bottom"
+		>
+			<div class="">
+				<div class="text-xs text-gray-600 mb-1">
+					{{ __('Select an Editor') }}
+				</div>
+				<Select v-model="currentEditor" :options="getEditorOptions()" />
 			</div>
-			<Select v-model="currentEditor" :options="getEditorOptions()" />
-		</div>
+		</Tooltip>
 		<div class="flex mt-4">
 			<Link
 				v-model="quiz"
@@ -63,7 +72,7 @@
 </template>
 <script setup>
 import Link from '@/components/Controls/Link.vue'
-import { FileUploader, Button, Select } from 'frappe-ui'
+import { FileUploader, Button, Select, Tooltip } from 'frappe-ui'
 import { Plus, FileText } from 'lucide-vue-next'
 import { ref, watch } from 'vue'
 
diff --git a/lms/job/doctype/lms_job_application/lms_job_application.py b/lms/job/doctype/lms_job_application/lms_job_application.py
index 41066847..0329bcd9 100644
--- a/lms/job/doctype/lms_job_application/lms_job_application.py
+++ b/lms/job/doctype/lms_job_application/lms_job_application.py
@@ -14,7 +14,7 @@ class LMSJobApplication(Document):
 		outgoing_email_account = frappe.get_cached_value(
 			"Email Account", {"default_outgoing": 1, "enable_outgoing": 1}, "name"
 		)
-		if outgoing_email_account:
+		if outgoing_email_account or frappe.conf.get("mail_login"):
 			self.send_email_to_employer()
 
 	def validate_duplicate(self):
diff --git a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py
index d99ff566..492fdf4a 100644
--- a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py
+++ b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py
@@ -18,7 +18,7 @@ class LMSAssignmentSubmission(Document):
 			outgoing_email_account = frappe.get_cached_value(
 				"Email Account", {"default_outgoing": 1, "enable_outgoing": 1}, "name"
 			)
-			if outgoing_email_account:
+			if outgoing_email_account or frappe.conf.get("mail_login"):
 				self.send_mail()
 
 	def validate_duplicates(self):
diff --git a/lms/lms/doctype/lms_batch/lms_batch.py b/lms/lms/doctype/lms_batch/lms_batch.py
index 5f242e55..45342891 100644
--- a/lms/lms/doctype/lms_batch/lms_batch.py
+++ b/lms/lms/doctype/lms_batch/lms_batch.py
@@ -73,7 +73,9 @@ class LMSBatch(Document):
 			outgoing_email_account = frappe.get_cached_value(
 				"Email Account", {"default_outgoing": 1, "enable_outgoing": 1}, "name"
 			)
-			if not student.confirmation_email_sent and outgoing_email_account:
+			if not student.confirmation_email_sent and (
+				outgoing_email_account or frappe.conf.get("mail_login")
+			):
 				self.send_mail(student)
 				student.confirmation_email_sent = 1
 
diff --git a/lms/lms/doctype/lms_certificate/lms_certificate.py b/lms/lms/doctype/lms_certificate/lms_certificate.py
index 11934582..ab580416 100644
--- a/lms/lms/doctype/lms_certificate/lms_certificate.py
+++ b/lms/lms/doctype/lms_certificate/lms_certificate.py
@@ -18,7 +18,7 @@ class LMSCertificate(Document):
 			outgoing_email_account = frappe.get_cached_value(
 				"Email Account", {"default_outgoing": 1, "enable_outgoing": 1}, "name"
 			)
-			if outgoing_email_account:
+			if outgoing_email_account or frappe.conf.get("mail_login"):
 				self.send_mail()
 
 	def send_mail(self):

From a62b754d2891fb0cd8463625d09560707a71f4a8 Mon Sep 17 00:00:00 2001
From: Md Hussain Nagaria <34810212+NagariaHussain@users.noreply.github.com>
Date: Fri, 12 Apr 2024 13:52:43 +0530
Subject: [PATCH 3/3] fix: empty the container before editorjs init (#771)

---
 frontend/src/pages/Lesson.vue | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/frontend/src/pages/Lesson.vue b/frontend/src/pages/Lesson.vue
index ef1f4125..a931b02f 100644
--- a/frontend/src/pages/Lesson.vue
+++ b/frontend/src/pages/Lesson.vue
@@ -245,6 +245,8 @@ const lesson = createResource({
 })
 
 const renderEditor = (holder, content) => {
+	// empty the holder
+	document.getElementById(holder).innerHTML = ''
 	return new EditorJS({
 		holder: holder,
 		tools: getEditorTools(),