eduvia/lms
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: evaluation fields

Browse Source
This commit is contained in:
Jannat Patel
2023-12-18 20:06:43 +05:30
parent d5118cc91f
commit 881c3d943a
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lms/lms/doctype/lms_certificate_evaluation/lms_certificate_evaluation.json
View File

@@ -47,12 +47,13 @@
"fieldtype": "Rating", "fieldtype": "Rating",
"in_list_view": 1, "in_list_view": 1,
"label": "Rating", "label": "Rating",
"reqd": 1 "mandatory_depends_on": "eval:doc.status != 'Pending' && doc.status != 'In Progress'"
}, },
{ {
"fieldname": "summary", "fieldname": "summary",
"fieldtype": "Small Text", "fieldtype": "Small Text",
"label": "Summary" "label": "Summary",
"mandatory_depends_on": "eval:doc.status != 'Pending' && doc.status != 'In Progress'"
}, },
{ {
"fieldname": "date", "fieldname": "date",
@@ -106,7 +107,7 @@
], ],
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"links": [], "links": [],
"modified": "2023-09-26 19:44:43.594892", "modified": "2023-12-18 20:03:27.040073",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "LMS", "module": "LMS",
"name": "LMS Certificate Evaluation", "name": "LMS Certificate Evaluation",

7
lms/lms/doctype/lms_certificate_evaluation/lms_certificate_evaluation.py
View File

@@ -8,7 +8,12 @@ from lms.lms.utils import has_course_moderator_role
class LMSCertificateEvaluation(Document): class LMSCertificateEvaluation(Document):
pass def validate(self):
self.validate_rating()
def validate_rating(self):
if self.status not in ["Pending", "In Progress"] and self.rating == 0:
frappe.throw("Rating cannot be 0")
def has_website_permission(doc, ptype, user, verbose=False): def has_website_permission(doc, ptype, user, verbose=False):