eduvia/lms
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: evaluator name issue

Browse Source
This commit is contained in:
Jannat Patel
2024-09-19 14:19:55 +05:30
parent 3cda563583
commit 8c454a333e
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lms/lms/doctype/lms_certificate_request/lms_certificate_request.py
View File

@@ -13,6 +13,7 @@ from frappe.utils import (
get_datetime, get_datetime,
nowtime, nowtime,
get_time, get_time,
get_fullname,
) )
from lms.lms.utils import get_evaluator from lms.lms.utils import get_evaluator
import json import json
@@ -32,6 +33,7 @@ class LMSCertificateRequest(Document):
def set_evaluator(self): def set_evaluator(self):
if not self.evaluator: if not self.evaluator:
self.evaluator = get_evaluator(self.course, self.batch_name) self.evaluator = get_evaluator(self.course, self.batch_name)
self.evaluator_name = get_fullname(self.evaluator)
def validate_unavailability(self): def validate_unavailability(self):
if self.evaluator: if self.evaluator:

2
lms/patches.txt
View File

@@ -90,4 +90,4 @@ lms.patches.v1_0.set_published_on
lms.patches.v2_0.fix_progress_percentage lms.patches.v2_0.fix_progress_percentage
lms.patches.v2_0.add_discussion_topic_titles lms.patches.v2_0.add_discussion_topic_titles
lms.patches.v2_0.sidebar_settings lms.patches.v2_0.sidebar_settings
lms.patches.v2_0.delete_certificate_request_notification lms.patches.v2_0.delete_certificate_request_notification #18-09-2024

8
lms/patches/v2_0/delete_certificate_request_notification.py
View File

@@ -2,4 +2,10 @@ import frappe
def execute(): def execute():
frappe.db.delete("Notification", "Certificate Request Creation") delete_notification("Certificate Request Creation")
delete_notification("Certificate Request Reminder")
def delete_notification(notification_name):
if frappe.db.exists("Notification", notification_name):
frappe.db.delete("Notification", notification_name)