From 8e1ef1dc77e6f50c9bec7546d5835c5171631d3b Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Fri, 17 Feb 2023 10:52:50 +0530
Subject: [PATCH] fix: layout of certification request

---
 .../lms_certificate_evaluation.js               |  2 +-
 .../lms_certificate_request.js                  | 17 +++++++++++------
 .../lms_certificate_request.json                | 17 ++++++++++++++---
 3 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/lms/lms/doctype/lms_certificate_evaluation/lms_certificate_evaluation.js b/lms/lms/doctype/lms_certificate_evaluation/lms_certificate_evaluation.js
index 329f701d..5e93d55d 100644
--- a/lms/lms/doctype/lms_certificate_evaluation/lms_certificate_evaluation.js
+++ b/lms/lms/doctype/lms_certificate_evaluation/lms_certificate_evaluation.js
@@ -3,7 +3,7 @@
 
 frappe.ui.form.on("LMS Certificate Evaluation", {
 	refresh: function (frm) {
-		if (frm.doc.status == "Pass") {
+		if (!frm.is_new() && frm.doc.status == "Pass") {
 			frm.add_custom_button(__("Create LMS Certificate"), () => {
 				frappe.model.open_mapped_doc({
 					method: "lms.lms.doctype.lms_certificate_evaluation.lms_certificate_evaluation.create_lms_certificate",
diff --git a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.js b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.js
index d352c1b6..cb024880 100644
--- a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.js
+++ b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.js
@@ -3,12 +3,17 @@
 
 frappe.ui.form.on("LMS Certificate Request", {
 	refresh: function (frm) {
-		frm.add_custom_button(__("Create LMS Certificate Evaluation"), () => {
-			frappe.model.open_mapped_doc({
-				method: "lms.lms.doctype.lms_certificate_request.lms_certificate_request.create_lms_certificate_evaluation",
-				frm: frm,
-			});
-		});
+		if (!frm.is_new()) {
+			frm.add_custom_button(
+				__("Create LMS Certificate Evaluation"),
+				() => {
+					frappe.model.open_mapped_doc({
+						method: "lms.lms.doctype.lms_certificate_request.lms_certificate_request.create_lms_certificate_evaluation",
+						frm: frm,
+					});
+				}
+			);
+		}
 	},
 
 	onload: function (frm) {
diff --git a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.json b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.json
index cbe66fb9..f789c44a 100644
--- a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.json
+++ b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.json
@@ -7,12 +7,14 @@
  "engine": "InnoDB",
  "field_order": [
   "course",
-  "member",
-  "member_name",
   "evaluator",
   "column_break_4",
+  "member",
+  "member_name",
+  "section_break_lifi",
   "date",
   "day",
+  "column_break_ddyh",
   "start_time",
   "end_time"
  ],
@@ -80,11 +82,19 @@
    "fieldtype": "Data",
    "label": "Member Name",
    "read_only": 1
+  },
+  {
+   "fieldname": "section_break_lifi",
+   "fieldtype": "Section Break"
+  },
+  {
+   "fieldname": "column_break_ddyh",
+   "fieldtype": "Column Break"
   }
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2022-04-06 11:33:33.711545",
+ "modified": "2023-02-17 09:26:13.776325",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Certificate Request",
@@ -99,6 +109,7 @@
    "read": 1,
    "report": 1,
    "role": "System Manager",
+   "select": 1,
    "share": 1,
    "write": 1
   }