diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index e6d7584c..0730ff24 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -4,30 +4,45 @@ on: pull_request: workflow_dispatch: push: - branches: [ main ] + branches: [ main, develop ] jobs: - linters: - name: Semantic Commits + + commit-lint: + name: 'Semantic Commits' runs-on: ubuntu-latest if: github.event_name == 'pull_request' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 + with: + fetch-depth: 200 + - uses: actions/setup-node@v4 + with: + node-version: 18 + check-latest: true - - name: Set up Python - uses: actions/setup-python@v4 + - name: Check commit titles + run: | + npm install @commitlint/cli @commitlint/config-conventional + npx commitlint --verbose --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} + + linters: + name: Semgrep Rules + runs-on: ubuntu-latest + if: github.event_name == 'pull_request' + + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 with: python-version: '3.10' - - - name: Install and Run Pre-commit - uses: pre-commit/action@v2.0.3 + cache: pip - name: Download Semgrep rules run: git clone --depth 1 https://github.com/frappe/semgrep-rules.git frappe-semgrep-rules - - name: Download semgrep - run: pip install semgrep - - name: Run Semgrep rules - run: semgrep ci --config ./frappe-semgrep-rules/rules + run: | + pip install semgrep + semgrep ci --config ./frappe-semgrep-rules/rules --config r/python.lang.correctness diff --git a/frontend/src/components/BatchOverlay.vue b/frontend/src/components/BatchOverlay.vue index a1c7cc09..9917bc3a 100644 --- a/frontend/src/components/BatchOverlay.vue +++ b/frontend/src/components/BatchOverlay.vue @@ -1,5 +1,5 @@