fix: validate if submission exceeds the allowed limit in backend
This commit is contained in:
@@ -290,7 +290,7 @@ import {
|
|||||||
FormControl,
|
FormControl,
|
||||||
} from 'frappe-ui'
|
} from 'frappe-ui'
|
||||||
import { ref, watch, reactive, inject, computed } from 'vue'
|
import { ref, watch, reactive, inject, computed } from 'vue'
|
||||||
import { createToast } from '@/utils/'
|
import { createToast, showToast } from '@/utils/'
|
||||||
import { CheckCircle, XCircle, MinusCircle } from 'lucide-vue-next'
|
import { CheckCircle, XCircle, MinusCircle } from 'lucide-vue-next'
|
||||||
import { timeAgo } from '@/utils'
|
import { timeAgo } from '@/utils'
|
||||||
import { useRouter } from 'vue-router'
|
import { useRouter } from 'vue-router'
|
||||||
@@ -582,6 +582,16 @@ const createSubmission = () => {
|
|||||||
if (quiz.data && quiz.data.max_attempts) attempts.reload()
|
if (quiz.data && quiz.data.max_attempts) attempts.reload()
|
||||||
if (quiz.data.duration) clearInterval(timerInterval)
|
if (quiz.data.duration) clearInterval(timerInterval)
|
||||||
},
|
},
|
||||||
|
onError(err) {
|
||||||
|
const errorTitle = err?.message || ''
|
||||||
|
if (errorTitle.includes('MaximumAttemptsExceededError')) {
|
||||||
|
const errorMessage = err.messages?.[0] || err
|
||||||
|
showToast(__('Error'), __(errorMessage), 'x')
|
||||||
|
setTimeout(() => {
|
||||||
|
window.location.reload()
|
||||||
|
}, 3000)
|
||||||
|
}
|
||||||
|
},
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -10,12 +10,29 @@ from frappe.desk.doctype.notification_log.notification_log import make_notificat
|
|||||||
|
|
||||||
class LMSQuizSubmission(Document):
|
class LMSQuizSubmission(Document):
|
||||||
def validate(self):
|
def validate(self):
|
||||||
|
self.validate_if_max_attempts_exceeded()
|
||||||
self.validate_marks()
|
self.validate_marks()
|
||||||
self.set_percentage()
|
self.set_percentage()
|
||||||
|
|
||||||
def on_update(self):
|
def on_update(self):
|
||||||
self.notify_member()
|
self.notify_member()
|
||||||
|
|
||||||
|
def validate_if_max_attempts_exceeded(self):
|
||||||
|
max_attempts = frappe.db.get_value("LMS Quiz", self.quiz, ["max_attempts"])
|
||||||
|
if max_attempts == 0:
|
||||||
|
return
|
||||||
|
|
||||||
|
current_user_submission_count = frappe.db.count(
|
||||||
|
self.doctype, filters={"quiz": self.quiz, "member": frappe.session.user}
|
||||||
|
)
|
||||||
|
if current_user_submission_count >= max_attempts:
|
||||||
|
frappe.throw(
|
||||||
|
_("You have exceeded the maximum number of attempts ({0}) for this quiz").format(
|
||||||
|
max_attempts
|
||||||
|
),
|
||||||
|
MaximumAttemptsExceededError,
|
||||||
|
)
|
||||||
|
|
||||||
def validate_marks(self):
|
def validate_marks(self):
|
||||||
self.score = 0
|
self.score = 0
|
||||||
for row in self.result:
|
for row in self.result:
|
||||||
@@ -52,3 +69,7 @@ class LMSQuizSubmission(Document):
|
|||||||
)
|
)
|
||||||
|
|
||||||
make_notification_logs(notification, [self.member])
|
make_notification_logs(notification, [self.member])
|
||||||
|
|
||||||
|
|
||||||
|
class MaximumAttemptsExceededError(frappe.DuplicateEntryError):
|
||||||
|
pass
|
||||||
|
|||||||
Reference in New Issue
Block a user