Merge pull request #576 from pateljannat/evaluation-duplication

fix: eval request duplicate conditions

lms/lms/doctype/lms_certificate_request/lms_certificate_request.py

@@ -21,7 +21,8 @@ class LMSCertificateRequest(Document):
 		)
 
 		for req in existing_requests:
-			if req.date == getdate(self.date) or getdate() <= getdate(self.date):
+
+			if req.date == getdate(self.date) or getdate() <= getdate(req.date):
 				course_title = frappe.db.get_value("LMS Course", req.course, "title")
 				frappe.throw(
 					_("You already have an evaluation on {0} at {1} for the course {2}.").format(

lms/www/classes/progress.js

@@ -107,7 +107,6 @@ const submit_evaluation_form = (values) => {
 		frappe.throw(__("Please select a slot"));
 	}
 
-	this.eval_form.hide();
 	frappe.call({
 		method: "lms.lms.doctype.lms_certificate_request.lms_certificate_request.create_certificate_request",
 		args: {
@@ -119,6 +118,7 @@ const submit_evaluation_form = (values) => {
 			class_name: class_name,
 		},
 		callback: (r) => {
+			this.eval_form.hide();
 			frappe.show_alert({
 				message: __("Evaluation scheduled successfully"),
 				indicator: "green",