fix: minor UI

This commit is contained in:
Jannat Patel
2022-08-30 12:50:26 +05:30
parent 7a7bc3e0db
commit b3a9274cd3
5 changed files with 48 additions and 38 deletions

View File

@@ -1,14 +1,16 @@
{% set enrolled = get_enrolled_courses().in_progress + get_enrolled_courses().completed %} {% set enrolled = get_enrolled_courses().in_progress + get_enrolled_courses().completed %}
{% if enrolled | length %} {% if enrolled | length %}
<div class="cards-parent"> <div class="cards-parent">
{% for course in enrolled %} {% for course in enrolled %}
{{ widgets.CourseCard(course=course) }} {{ widgets.CourseCard(course=course) }}
{% endfor %} {% endfor %}
</div> </div>
{% else %} {% else %}
{% set site_name = frappe.db.get_single_value("System Settings", "app_name") %} {% set site_name = frappe.db.get_single_value("System Settings", "app_name") %}
<div class="empty-state"> <div class="empty-state">
<div class="empty-state-text"> <div class="empty-state-text text-left">
<div class="text-center"> <div class="text-center">
<div class="empty-state-heading">{{ _("You haven't enrolled for any courses") }}</div> <div class="empty-state-heading">{{ _("You haven't enrolled for any courses") }}</div>
<div class="course-meta mb-6">{{ _("Here are a few courses we recommend for you to get started with {0}").format(site_name) }}</div> <div class="course-meta mb-6">{{ _("Here are a few courses we recommend for you to get started with {0}").format(site_name) }}</div>

View File

@@ -67,7 +67,7 @@ const join_course = (e) => {
}, 3); }, 3);
setTimeout(function () { setTimeout(function () {
window.location.href = `/courses/${course}/learn/1.1`; window.location.href = `/courses/${course}/learn/1.1`;
}, 3000); }, 1000);
} }
} }
}) })

View File

@@ -48,25 +48,25 @@
<script> <script>
frappe.ready(() => { frappe.ready(() => {
$("#confirm").click((e) => { $("#confirm").click((e) => {
frappe.call({ frappe.call({
"method": "lms.lms.doctype.lms_batch_membership.lms_batch_membership.create_membership", "method": "lms.lms.doctype.lms_batch_membership.lms_batch_membership.create_membership",
"args": { "args": {
"batch": {{ batch.name }}, "batch": {{ batch.name }},
"course": {{ batch.course }} "course": {{ batch.course }}
}, },
"callback": (data) => { "callback": (data) => {
if (data.message == "OK") { if (data.message == "OK") {
frappe.msgprint({ frappe.msgprint({
message: __("You are now a member of this batch!"), message: __("You are now a member of this batch!"),
clear: true clear: true
}); });
setTimeout(function () { setTimeout(function () {
window.location.href = "/courses/{{ batch.course }}/home"; window.location.href = "/courses/{{ batch.course }}/home";
}, 2000); }, 1000);
} }
} }
}) });
}) });
}) });
</script> </script>
{% endblock %} {% endblock %}

View File

@@ -67,7 +67,7 @@
data-index="{{ lesson_index }}" data-course="{{ course.name }}" data-chapter="{{ chapter }}" data-index="{{ lesson_index }}" data-course="{{ course.name }}" data-chapter="{{ chapter }}"
{% if lesson.name %} data-lesson="{{ lesson.name }}" {% endif %} {% if lesson.name %} data-lesson="{{ lesson.name }}" {% endif %}
>{% if lesson.title %}{{ lesson.title }}{% endif %}</div> >{% if lesson.title %}{{ lesson.title }}{% endif %}</div>
<span class="lesson-progress {{ hide if get_progress(course.name, lesson.name) != 'Complete' else ''}}">{{ _("COMPLETED") }}</span> <span class="indicator-pill green {{ hide if get_progress(course.name, lesson.name) != 'Complete' else ''}}">{{ _("COMPLETED") }}</span>
<!-- Edit Button --> <!-- Edit Button -->
{% if is_instructor and not lesson.edit_mode %} {% if is_instructor and not lesson.edit_mode %}
@@ -119,9 +119,13 @@
{% endif %} {% endif %}
{% else %} {% else %}
{% set course_link = "<a class='join-batch' data-course=" + course.name | urlencode + " href=''>" + _('here') + "</a>" %}
<div class=""> <div class="">
<div class="btn btn-primary pull-right join-batch" data-course="{{ course.name | urlencode }}"> {{ _("Start Learning") }} </div> <div>
<div class=""> {{ _("This lesson is not available for preview. Please join the course to access it.") }} </div> {{ _("This lesson is not available for preview.
Please join the course to access it.
Click {0} to join the course.").format(course_link) }}
</div>
</div> </div>
{% endif %} {% endif %}
</div> </div>
@@ -140,14 +144,14 @@
<div> <div>
{% if prev_url %} {% if prev_url %}
<a class="btn btn-secondary dark-links prev" href="{{ prev_url }}"> <a class="btn btn-secondary dark-links prev" href="{{ prev_url }}">
<img class="mr-2" src="/assets/lms/icons/left-arrow.svg"> {{ _("Previous") }}
{{ _("Prev") }}
</a> </a>
{% endif %} {% endif %}
</div> </div>
{% if not is_mentor(course.name, frappe.session.user) and membership %}
{% set progress = get_progress(course.name, lesson.name) %} {% set progress = get_progress(course.name, lesson.name) %}
{% if not is_mentor(course.name, frappe.session.user) and membership %}
<div class="custom-checkbox {% if progress == 'Complete' %} hide {% endif %}"> <div class="custom-checkbox {% if progress == 'Complete' %} hide {% endif %}">
<label class="quiz-label"> <label class="quiz-label">
<input class="mark-progress" type="checkbox" checked> <input class="mark-progress" type="checkbox" checked>
@@ -155,18 +159,19 @@
<span class="small">{{ _("Mark as complete on moving to the next lesson") }}</span> <span class="small">{{ _("Mark as complete on moving to the next lesson") }}</span>
</label> </label>
</div> </div>
<div class="btn btn-default mark-progress {{ progress }} {% if progress == 'Incomplete' or progress == None %} hide {% endif %}"
data-progress="Incomplete">
{{ _("Mark as Incomplete") }}
</div>
{% endif %} {% endif %}
<div> <div>
<a class="btn btn-primary next {% if not next_url and (membership.progress|int == 100 or is_instructor) %} hide {% endif %}" {% if not is_mentor(course.name, frappe.session.user) and membership %}
{% if next_url %} data-href="{{ next_url }}" {% endif %} href=""> <div class="btn btn-default mark-progress {{ progress }} {% if progress == 'Incomplete' or progress == None %} hide {% endif %}"
{% if next_url %} {{ _("Next") }} {% else %} {{ _("Mark as Complete") }} {% endif %} data-progress="Incomplete">
<img class="ml-2" src="/assets/lms/icons/side-arrow-white.svg"> {{ _("Mark as Incomplete") }}
</div>
{% endif %}
<a class="btn btn-primary next ml-2 {% if not next_url and (membership.progress|int == 100 or is_instructor) %} hide {% endif %}"
{% if next_url %} data-href="{{ next_url }}" {% endif %} href="">
{% if next_url %} {{ _("Next") }} {% else %} {{ _("Mark as Complete") }} {% endif %}
</a> </a>
</div> </div>

View File

@@ -1,5 +1,6 @@
{% extends "templates/base.html" %} {% extends "templates/base.html" %}
{% block title %}{{ _("Dashboard")}} {% block title %}
{{ _("Dashboard")}}
{% endblock %} {% endblock %}
@@ -20,6 +21,7 @@
<li class="nav-item"> <li class="nav-item">
<a class="nav-link active" data-toggle="tab" href="#courses-enrolled"> {{ _("Courses Enrolled") }} </a> <a class="nav-link active" data-toggle="tab" href="#courses-enrolled"> {{ _("Courses Enrolled") }} </a>
</li> </li>
{% if show_creators_section %} {% if show_creators_section %}
<li class="nav-item"> <li class="nav-item">
<a class="nav-link" data-toggle="tab" href="#courses-created">{{ _("Courses Created") }} <a class="nav-link" data-toggle="tab" href="#courses-created">{{ _("Courses Created") }}
@@ -34,6 +36,7 @@
<div class="tab-pane active" id="courses-enrolled" role="tabpanel" aria-labelledby="courses-enrolled"> <div class="tab-pane active" id="courses-enrolled" role="tabpanel" aria-labelledby="courses-enrolled">
{% include "lms/lms/web_template/courses_enrolled/courses_enrolled.html" %} {% include "lms/lms/web_template/courses_enrolled/courses_enrolled.html" %}
</div> </div>
{% if show_creators_section %} {% if show_creators_section %}
<div class="tab-pane fade" id="courses-created" role="tabpanel" aria-labelledby="courses-created"> <div class="tab-pane fade" id="courses-created" role="tabpanel" aria-labelledby="courses-created">
{% include "lms/templates/courses_created.html" %} {% include "lms/templates/courses_created.html" %}