diff --git a/community/community/doctype/community_member/community_member.py b/community/community/doctype/community_member/community_member.py index dd7bed8b..0a36a91b 100644 --- a/community/community/doctype/community_member/community_member.py +++ b/community/community/doctype/community_member/community_member.py @@ -74,7 +74,7 @@ def create_member_from_user(doc, method): if ( doc.username and username_exists(doc.username)) or not doc.username: username = create_username_from_email(doc.email) - elif len(doc.username) < 4: + elif len(doc.username) < 4 and doc.send_welcome_email == 1: username = adjust_username(doc.username) if username_exists(username): diff --git a/community/lms/doctype/invite_request/invite_request.py b/community/lms/doctype/invite_request/invite_request.py index c271c740..00bc18c2 100644 --- a/community/lms/doctype/invite_request/invite_request.py +++ b/community/lms/doctype/invite_request/invite_request.py @@ -47,6 +47,9 @@ class InviteRequest(Document): @frappe.whitelist(allow_guest=True) def create_invite_request(invite_email): + if not frappe.utils.validate_email_address(invite_email): + return "invalid email" + if frappe.db.exists("User", invite_email): return "user" diff --git a/community/lms/widgets/RequestInvite.html b/community/lms/widgets/RequestInvite.html index ce3d8799..053cbcbc 100644 --- a/community/lms/widgets/RequestInvite.html +++ b/community/lms/widgets/RequestInvite.html @@ -4,7 +4,8 @@
- Request Invite + Request + Invite
@@ -18,27 +19,44 @@ invite_email: invite_email }, callback: (data) => { - $("#invite-request-form").hide(); + if (data.message == "invalid email") { + $(".email-validation") && $(".email-validation").remove(); + if (invite_email) { + var message = `
+ ${invite_email} is not a valid email address. +
`; + } + else { + var message = `
+ Please enter an email address. +
`; + } - if (data.message == "OK") { - var message = `
+ $("#invite-request-form").append(message); + } + else { + $("#invite-request-form").hide(); + + if (data.message == "OK") { + var message = `

Thanks for your interest in Mon School. We have recorded your interest and we will get back to you shortly.

`; - } + } - else if (data.message == "invite") { - var message = `
+ else if (data.message == "invite") { + var message = `

Email ${invite_email} has already been used to request an invitation.

`; - } + } - else if (data.message == "user") { - var message = `
+ else if (data.message == "user") { + var message = `

Looks like there is already an account with email ${invite_email}. Would you like to login?

`; - } + } - $(".jumbotron").append(message); + $(".jumbotron").append(message); + } } }) })