diff --git a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py index c036db06..1989f87c 100644 --- a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py +++ b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py @@ -4,6 +4,7 @@ import frappe from frappe import _ from frappe.model.document import Document +from frappe.utils import validate_url class LMSAssignmentSubmission(Document): @@ -40,9 +41,13 @@ def upload_assignment( if assignment_type == "URL" and not answer: frappe.throw(_("Please enter the URL for assignment submission.")) + if assignment_type == "File" and not assignment_attachment: frappe.throw(_("Please upload the assignment file.")) + if assignment_type == "URL" and not validate_url(answer): + frappe.throw(_("Please enter a valid URL.")) + if submission: doc = frappe.get_doc("LMS Assignment Submission", submission) else: diff --git a/lms/www/assignment_submission/assignment_submission.html b/lms/www/assignment_submission/assignment_submission.html index 9a29fae1..a645b0a0 100644 --- a/lms/www/assignment_submission/assignment_submission.html +++ b/lms/www/assignment_submission/assignment_submission.html @@ -91,7 +91,7 @@ {% else %} - {{ submission }} +