fix: renamed instructor and moderator roles

lms/lms/doctype/lms_class/lms_class.json

@@ -63,7 +63,7 @@
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2022-11-11 17:41:05.472822",
+ "modified": "2022-11-14 17:08:03.206840",
  "modified_by": "Administrator",
  "module": "LMS",
  "name": "LMS Class",
@@ -90,7 +90,7 @@
    "print": 1,
    "read": 1,
    "report": 1,
-   "role": "Course Moderator",
+   "role": "Moderator",
    "share": 1,
    "write": 1
   }

lms/lms/utils.py

@@ -486,7 +486,7 @@ def redirect_to_courses_list():
 def has_course_instructor_role(member=None):
 	return frappe.db.get_value(
 		"Has Role",
-		{"parent": member or frappe.session.user, "role": "Course Instructor"},
+		{"parent": member or frappe.session.user, "role": "Instructor"},
 		"name",
 	)
 
@@ -506,7 +506,7 @@ def can_create_courses(member=None):
 def has_course_moderator_role(member=None):
 	return frappe.db.get_value(
 		"Has Role",
-		{"parent": member or frappe.session.user, "role": "Course Moderator"},
+		{"parent": member or frappe.session.user, "role": "Moderator"},
 		"name",
 	)
 

lms/patches.txt

@@ -37,3 +37,4 @@ lms.patches.v0_0.set_courses_page_as_home
 lms.patches.v0_0.set_member_in_progress #09-11-2022
 lms.patches.v0_0.convert_progress_to_float
 lms.patches.v0_0.add_pages_to_nav #11-11-2022
+lms.patches.v0_0.change_role_names

lms/patches/v0_0/change_role_names.py

@@ -0,0 +1,5 @@
+import frappe
+
+def execute():
+	frappe.rename_doc("Role", "Course Instructor", "Instructor")
+	frappe.rename_doc("Role", "Course Moderator", "Moderator")

lms/www/profiles/profile.html

@@ -205,14 +205,14 @@
                 <div class="course-home-headings"> {{ _("Role Settings") }} </div>
                 <div class="medium">
                     <label class="role">
-                        <input type="checkbox" id="instructor" data-role="Course Instructor"
+                        <input type="checkbox" id="instructor" data-role="Instructor"
                         {% if has_course_instructor_role(member.name) %} checked {% endif %}>
-                        {{ _("Course Instructor") }}
+                        {{ _("Instructor") }}
                     </label>
                     <label class="role">
-                        <input type="checkbox" id="moderator" data-role="Course Moderator"
+                        <input type="checkbox" id="moderator" data-role="Moderator"
                             {% if has_course_moderator_role(member.name) %} checked {% endif %}>
-                        {{ _("Course Moderator") }}
+                        {{ _("Moderator") }}
                     </label>
                 </div>
             </div>