From 6f96da74c7b6fd0de0b09cb6c9dd992d91c2fd8a Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Tue, 2 Nov 2021 18:27:52 +0530
Subject: [PATCH 1/3] empty state for discussion

---
 .../lms/web_template/courses_enrolled/courses_enrolled.html   | 2 +-
 school/www/batch/learn.html                                   | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/school/lms/web_template/courses_enrolled/courses_enrolled.html b/school/lms/web_template/courses_enrolled/courses_enrolled.html
index 6f05187d..b0dc295e 100644
--- a/school/lms/web_template/courses_enrolled/courses_enrolled.html
+++ b/school/lms/web_template/courses_enrolled/courses_enrolled.html
@@ -16,7 +16,7 @@
   {% set site_name = frappe.db.get_single_value("System Settings", "app_name") %}
   <div class="empty-state">
     <div class="course-home-headings text-center mb-0" style="color: inherit;">You haven't enrolled for any courses</div>
-    <p class="text-center mb-8">Here are a few courses we recommend for you to get started with {{ site_name }}</p>
+    <p class="small text-center mb-8">Here are a few courses we recommend for you to get started with {{ site_name }}</p>
     {% set recommended_courses = [course1, course2, course3] %}
     <div class="cards-parent">
     {% for recommended_course in recommended_courses %}
diff --git a/school/www/batch/learn.html b/school/www/batch/learn.html
index 1adf85bd..ad1bca49 100644
--- a/school/www/batch/learn.html
+++ b/school/www/batch/learn.html
@@ -113,9 +113,11 @@
 {% set condition = is_instructor if is_instructor else membership %}
 {% set doctype, docname = "Course Lesson", lesson.name %}
 {% set title = "Questions" %}
-{% set cta_title = "New Question" %}
+{% set cta_title = "Ask a Question" %}
 {% set button_name = "Start Learning" %}
 {% set redirect_to = "/courses/" + course.name %}
+{% set empty_state_title = "Have a doubt?" %}
+{% set empty_state_subtitle = "Post it here, our mentors will help you out." %}
 
 {% include "frappe/templates/discussions/discussions_section.html" %}
 {% endmacro %}

From 4db51bff7972fd5cd43311b26407b70eb2b45273 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 4 Nov 2021 22:03:26 +0530
Subject: [PATCH 2/3] style: empty state for reviews

---
 school/lms/widgets/Reviews.html | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/school/lms/widgets/Reviews.html b/school/lms/widgets/Reviews.html
index b0aecb4c..c31cc0a0 100644
--- a/school/lms/widgets/Reviews.html
+++ b/school/lms/widgets/Reviews.html
@@ -37,18 +37,19 @@
   </div>
 
   {% else %}
-  <div class="common-card-style thread-card">
-    <div class="w-25 text-center" style="margin: 0 auto;">
-      <span class="font-weight-bold"> No Reviews </span>
-      <div class="small">
-        There are no reviews for this course.
-      </div>
-      {% if course.is_eligible_to_review(membership) %}
+  <div class="empty-state text-center">
+    <svg class="icon icon-xl"><use href="#icon-small-message"></use></svg>
+    <div class="course-home-headings mt-4 mb-0" style="color: inherit;"> {{ _("Review the course") }} </div>
+    <div class="small mb-6"> {{ _("Help us improve our course material.") }} </div>
+    {% if course.is_eligible_to_review(membership) %}
       <span class="review-link button is-secondary ml-auto mr-auto mt-3">
         Write a review
       </span>
-      {% endif %}
-    </div>
+    {% elif frappe.session.user == "Guest" %}
+    <div class="button is-secondary ml-auto mr-auto mt-3"> {{ _("Login") }} </div>
+    {% elif not membership %}
+    <div class="button is-secondary join-batch ml-auto mr-auto mt-3" data-course="{{ course.name | urlencode }}"> {{ _("Start Learning") }} </div>
+    {% endif %}
   </div>
   {% endif %}
 </div>

From f8788dc32cdc403692494111c4b5f27f88fc5cdd Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Mon, 8 Nov 2021 16:49:31 +0530
Subject: [PATCH 3/3] fix: empty state logo and link style

---
 school/lms/widgets/Reviews.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/school/lms/widgets/Reviews.html b/school/lms/widgets/Reviews.html
index c31cc0a0..89264fe8 100644
--- a/school/lms/widgets/Reviews.html
+++ b/school/lms/widgets/Reviews.html
@@ -38,7 +38,7 @@
 
   {% else %}
   <div class="empty-state text-center">
-    <svg class="icon icon-xl"><use href="#icon-small-message"></use></svg>
+    <img class="icon icon-xl" src="/assets/frappe/icons/timeless/message.svg">
     <div class="course-home-headings mt-4 mb-0" style="color: inherit;"> {{ _("Review the course") }} </div>
     <div class="small mb-6"> {{ _("Help us improve our course material.") }} </div>
     {% if course.is_eligible_to_review(membership) %}
@@ -46,7 +46,7 @@
         Write a review
       </span>
     {% elif frappe.session.user == "Guest" %}
-    <div class="button is-secondary ml-auto mr-auto mt-3"> {{ _("Login") }} </div>
+    <a class="button is-secondary dark-links ml-auto mr-auto mt-3" href="/login?redirect-to=/courses/{{ course.name }}"> {{ _("Login") }} </a>
     {% elif not membership %}
     <div class="button is-secondary join-batch ml-auto mr-auto mt-3" data-course="{{ course.name | urlencode }}"> {{ _("Start Learning") }} </div>
     {% endif %}