From eff9e553a1276b8a2782ef38dd60974375804028 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Wed, 23 Mar 2022 19:10:02 +0530 Subject: [PATCH] fix: course home card ui --- .../doctype/lms_settings/lms_settings.json | 12 +++---- lms/public/css/style.css | 22 ++++++------- lms/public/icons/chevron-right.svg | 2 +- lms/www/batch/learn.html | 2 +- lms/www/courses/course.html | 32 ------------------- 5 files changed, 19 insertions(+), 51 deletions(-) diff --git a/lms/lms/doctype/lms_settings/lms_settings.json b/lms/lms/doctype/lms_settings/lms_settings.json index 2fa1f3f5..bcd59c9b 100644 --- a/lms/lms/doctype/lms_settings/lms_settings.json +++ b/lms/lms/doctype/lms_settings/lms_settings.json @@ -7,9 +7,9 @@ "field_order": [ "show_search", "portal_course_creation", - "search_placeholder", - "column_break_2", "force_profile_completion", + "column_break_2", + "search_placeholder", "livecode_url", "signup_settings_section", "terms_of_use", @@ -114,8 +114,8 @@ "label": "Enable Course Creation from Portal" }, { - "fieldname": "column_break_9", - "fieldtype": "Column Break" + "fieldname": "column_break_9", + "fieldtype": "Column Break" }, { "default": "0", @@ -135,7 +135,7 @@ "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2022-03-10 18:45:58.372370", + "modified": "2022-03-23 16:07:29.491432", "modified_by": "Administrator", "module": "LMS", "name": "LMS Settings", @@ -156,4 +156,4 @@ "sort_order": "DESC", "states": [], "track_changes": 1 -} +} \ No newline at end of file diff --git a/lms/public/css/style.css b/lms/public/css/style.css index e6d5ba9a..946bbca9 100644 --- a/lms/public/css/style.css +++ b/lms/public/css/style.css @@ -275,7 +275,7 @@ input[type=checkbox] { .course-card-wide { background-color: white; - padding: 0 1rem 1rem; + padding: 0 1.25rem 1.25rem; border-radius: var(--border-radius); width: 50%; box-shadow: var(--shadow-base); @@ -305,10 +305,9 @@ input[type=checkbox] { .course-card-wide-title { font-weight: bold; - font-size: 36px; + font-size: var(--text-3xl); line-height: 44px; color: var(--gray-900); - margin-bottom: 0.75rem; } .button { @@ -584,7 +583,11 @@ input[type=checkbox] { } .lesson-content-card { - margin-top: 2rem; + margin-top: 1rem; +} + +.lesson-page { + background-color: #FFFFFF; } .lesson-content-card .alert-dismissible .close { @@ -843,6 +846,10 @@ pre { font-size: 1rem; } +.markdown-source p:last-child { + margin-bottom: 0; +} + .avatar img { object-fit: cover; } @@ -1162,13 +1169,6 @@ pre { color: var(--gray-900); } -.course-intructor-rating-section { - display: flex; - align-items: center; - justify-content: space-between; - margin-top: 2rem; -} - .seperator { margin: 0 1rem; } diff --git a/lms/public/icons/chevron-right.svg b/lms/public/icons/chevron-right.svg index 28890edf..e66ce425 100644 --- a/lms/public/icons/chevron-right.svg +++ b/lms/public/icons/chevron-right.svg @@ -1,3 +1,3 @@ - + diff --git a/lms/www/batch/learn.html b/lms/www/batch/learn.html index 51251270..f3747a9c 100644 --- a/lms/www/batch/learn.html +++ b/lms/www/batch/learn.html @@ -13,7 +13,7 @@ {% endblock %} {% block content %} -
+
{{ BreadCrumb(course, lesson) }}
diff --git a/lms/www/courses/course.html b/lms/www/courses/course.html index aff55911..1b6825fa 100644 --- a/lms/www/courses/course.html +++ b/lms/www/courses/course.html @@ -66,38 +66,6 @@ {{ course.short_introduction }}
-
- -
- - - - {{ get_students(course.name) | length }} {{ _("Enrolled") }} -
- - {% if get_lessons(course.name) | length %} -
- - - - {{ get_lessons(course.name) | length }} {{ _("Lessons") }} -
- {% endif %} - - {% set avg_rating = get_average_rating(course.name) %} - {% if avg_rating %} -
- {% for i in [1, 2, 3, 4, 5] %} - - - - {% endfor %} - {{ avg_rating }} {{ _(" Rating ") }} -
- {% endif %} - -
- {% if membership %} {% set progress = frappe.utils.cint(membership.progress) %}