fix: assessment validation

This commit is contained in:
Jannat Patel
2023-06-27 12:17:00 +05:30
parent 0e1b91f1ec
commit f3830bfdd5
2 changed files with 18 additions and 13 deletions

View File

@@ -2,13 +2,12 @@
# For license information, please see license.txt # For license information, please see license.txt
import frappe import frappe
from frappe.model.document import Document
from frappe import _
from frappe.utils import cint, format_date, format_datetime
import requests import requests
import base64 import base64
import json import json
from lms.lms.utils import has_course_moderator_role from frappe import _
from frappe.model.document import Document
from frappe.utils import cint, format_date, format_datetime
class LMSClass(Document): class LMSClass(Document):
@@ -41,16 +40,16 @@ class LMSClass(Document):
def validate_duplicate_assessments(self): def validate_duplicate_assessments(self):
assessments = [row.assessment_name for row in self.assessment] assessments = [row.assessment_name for row in self.assessment]
duplicates = { for assessment in self.assessment:
assessment for assessment in assessments if assessments.count(assessment) > 1 if assessments.count(assessment.assessment_name) > 1:
} title = frappe.db.get_value(
if len(duplicates): assessment.assessment_type, assessment.assessment_name, "title"
title = frappe.db.get_value("LMS Assessment", next(iter(duplicates)), "title") )
frappe.throw( frappe.throw(
_("Assessment {0} has already been added to this class.").format( _("Assessment {0} has already been added to this class.").format(
frappe.bold(next(iter(duplicates))) frappe.bold(title)
)
) )
)
def validate_membership(self): def validate_membership(self):
for course in self.courses: for course in self.courses:

View File

@@ -2205,3 +2205,9 @@ select {
.btn-remove-course:hover { .btn-remove-course:hover {
opacity: 1; opacity: 1;
} }
.rows .grid-row .data-row,
.rows .grid-row .grid-footer-toolbar,
.grid-form-heading {
cursor: none;
}