diff --git a/school/lms/doctype/lms_course/lms_course.py b/school/lms/doctype/lms_course/lms_course.py index 9562445c..31ed35e0 100644 --- a/school/lms/doctype/lms_course/lms_course.py +++ b/school/lms/doctype/lms_course/lms_course.py @@ -312,8 +312,15 @@ class LMSCourse(Document): }, ["review", "rating", "owner"], order_by= "creation desc") - + out_of_ratings = frappe.db.get_all("DocField", + { + "parent": "LMS Course Review", + "fieldtype": "Rating" + }, + ["options"]) + out_of_ratings = (len(out_of_ratings) and out_of_ratings[0].options) or 5 for review in reviews: + review.rating = review.rating * out_of_ratings review.owner_details = frappe.get_doc("User", review.owner) return reviews diff --git a/school/lms/doctype/lms_course_review/lms_course_review.py b/school/lms/doctype/lms_course_review/lms_course_review.py index 2c4199a4..ffe100b9 100644 --- a/school/lms/doctype/lms_course_review/lms_course_review.py +++ b/school/lms/doctype/lms_course_review/lms_course_review.py @@ -3,12 +3,21 @@ import frappe from frappe.model.document import Document +from frappe.utils import cint class LMSCourseReview(Document): pass @frappe.whitelist() def submit_review(rating, review, course): + out_of_ratings = frappe.db.get_all("DocField", + { + "parent": "LMS Course Review", + "fieldtype": "Rating" + }, + ["options"]) + out_of_ratings = (len(out_of_ratings) and out_of_ratings[0].options) or 5 + rating = cint(rating)/out_of_ratings frappe.get_doc({ "doctype": "LMS Course Review", "rating": rating, diff --git a/school/www/courses/course.js b/school/www/courses/course.js index 4a5c3c81..3f228e25 100644 --- a/school/www/courses/course.js +++ b/school/www/courses/course.js @@ -192,10 +192,7 @@ var submit_review = (e) => { callback: (data) => { if (data.message == "OK") { $(".review-modal").modal("hide"); - frappe.msgprint("Thanks for providing your feedback!"); - setTimeout(() => { - window.location.reload(); - }, 2000); + window.location.reload(); } } })