Compare commits

..

2 Commits

Author SHA1 Message Date
Jannat Patel
2271eb270e Merge pull request #1667 from harshpwctech/develop
refactor: Announcement mail being sent to students in BCC
2025-08-01 17:32:41 +05:30
CA Harsh Agrawal
7e5b2e4e79 refactor: Announcement mail being sent to students in BCC 2025-08-01 17:02:48 +05:30
2 changed files with 16 additions and 12 deletions

View File

@@ -25,6 +25,7 @@
<div class=""> <div class="">
<div class="mb-1.5 text-sm text-ink-gray-5"> <div class="mb-1.5 text-sm text-ink-gray-5">
{{ __('Reply To') }} {{ __('Reply To') }}
<span class="text-ink-red-3">*</span>
</div> </div>
<Input type="text" v-model="announcement.replyTo" /> <Input type="text" v-model="announcement.replyTo" />
</div> </div>
@@ -70,8 +71,8 @@ const announcementResource = createResource({
url: 'frappe.core.doctype.communication.email.make', url: 'frappe.core.doctype.communication.email.make',
makeParams(values) { makeParams(values) {
return { return {
recipients: props.students.join(', '), recipients: announcement.replyTo,
cc: announcement.replyTo, bcc: props.students.join(', '),
subject: announcement.subject, subject: announcement.subject,
content: announcement.announcement, content: announcement.announcement,
doctype: 'LMS Batch', doctype: 'LMS Batch',
@@ -95,6 +96,9 @@ const makeAnnouncement = (close) => {
if (!announcement.announcement) { if (!announcement.announcement) {
return __('Announcement is required') return __('Announcement is required')
} }
if (!announcement.replyTo) {
return __('Reply To is required')
}
}, },
onSuccess() { onSuccess() {
close() close()

View File

@@ -3,7 +3,7 @@ msgstr ""
"Project-Id-Version: frappe\n" "Project-Id-Version: frappe\n"
"Report-Msgid-Bugs-To: jannat@frappe.io\n" "Report-Msgid-Bugs-To: jannat@frappe.io\n"
"POT-Creation-Date: 2025-07-25 16:04+0000\n" "POT-Creation-Date: 2025-07-25 16:04+0000\n"
"PO-Revision-Date: 2025-08-02 23:05\n" "PO-Revision-Date: 2025-07-29 22:53\n"
"Last-Translator: jannat@frappe.io\n" "Last-Translator: jannat@frappe.io\n"
"Language-Team: Indonesian\n" "Language-Team: Indonesian\n"
"MIME-Version: 1.0\n" "MIME-Version: 1.0\n"
@@ -140,7 +140,7 @@ msgstr ""
#: frontend/src/pages/ProgramForm.vue:30 frontend/src/pages/ProgramForm.vue:92 #: frontend/src/pages/ProgramForm.vue:30 frontend/src/pages/ProgramForm.vue:92
#: frontend/src/pages/ProgramForm.vue:137 #: frontend/src/pages/ProgramForm.vue:137
msgid "Add" msgid "Add"
msgstr "Tambah" msgstr "Tambahkan"
#: frontend/src/components/CourseOutline.vue:18 #: frontend/src/components/CourseOutline.vue:18
#: frontend/src/components/CreateOutline.vue:18 #: frontend/src/components/CreateOutline.vue:18
@@ -265,11 +265,11 @@ msgstr "Alamat"
#: frontend/src/pages/Billing.vue:74 #: frontend/src/pages/Billing.vue:74
msgid "Address Line 1" msgid "Address Line 1"
msgstr "Baris Alamat 1" msgstr "Alamat Baris 1"
#: frontend/src/pages/Billing.vue:78 #: frontend/src/pages/Billing.vue:78
msgid "Address Line 2" msgid "Address Line 2"
msgstr "Baris Alamat 2" msgstr "Alamat Baris 2"
#. Option for the 'Role' (Select) field in DocType 'Cohort Staff' #. Option for the 'Role' (Select) field in DocType 'Cohort Staff'
#. Option for the 'Required Role' (Select) field in DocType 'Cohort Web Page' #. Option for the 'Required Role' (Select) field in DocType 'Cohort Web Page'
@@ -342,7 +342,7 @@ msgstr ""
#: lms/lms/doctype/lms_course/lms_course.json #: lms/lms/doctype/lms_course/lms_course.json
#: lms/lms/doctype/lms_payment/lms_payment.json #: lms/lms/doctype/lms_payment/lms_payment.json
msgid "Amount" msgid "Amount"
msgstr "Jumlah" msgstr "Total"
#. Label of the amount_usd (Currency) field in DocType 'LMS Batch' #. Label of the amount_usd (Currency) field in DocType 'LMS Batch'
#. Label of the amount_usd (Currency) field in DocType 'LMS Course' #. Label of the amount_usd (Currency) field in DocType 'LMS Course'
@@ -684,7 +684,7 @@ msgstr ""
#: lms/lms/doctype/lms_certificate_request/lms_certificate_request.json #: lms/lms/doctype/lms_certificate_request/lms_certificate_request.json
#: lms/lms/doctype/lms_live_class/lms_live_class.json #: lms/lms/doctype/lms_live_class/lms_live_class.json
msgid "Batch" msgid "Batch"
msgstr "Batch" msgstr "Kumpulan"
#. Label of the batch_confirmation_template (Link) field in DocType 'LMS #. Label of the batch_confirmation_template (Link) field in DocType 'LMS
#. Settings' #. Settings'
@@ -1318,7 +1318,7 @@ msgstr ""
#: lms/lms/doctype/lms_course_progress/lms_course_progress.json #: lms/lms/doctype/lms_course_progress/lms_course_progress.json
#: lms/lms/widgets/CourseCard.html:75 lms/templates/reviews.html:48 #: lms/lms/widgets/CourseCard.html:75 lms/templates/reviews.html:48
msgid "Complete" msgid "Complete"
msgstr "Selesai" msgstr "Lengkap"
#: lms/templates/emails/lms_invite_request_approved.html:7 #: lms/templates/emails/lms_invite_request_approved.html:7
msgid "Complete Sign Up" msgid "Complete Sign Up"
@@ -1769,7 +1769,7 @@ msgstr ""
#: lms/lms/doctype/lms_course/lms_course.json #: lms/lms/doctype/lms_course/lms_course.json
#: lms/lms/doctype/lms_payment/lms_payment.json #: lms/lms/doctype/lms_payment/lms_payment.json
msgid "Currency" msgid "Currency"
msgstr "Mata Uang" msgstr "Mata uang"
#. Label of the current_lesson (Link) field in DocType 'LMS Enrollment' #. Label of the current_lesson (Link) field in DocType 'LMS Enrollment'
#: lms/lms/doctype/lms_enrollment/lms_enrollment.json #: lms/lms/doctype/lms_enrollment/lms_enrollment.json
@@ -1849,7 +1849,7 @@ msgstr "Hari"
#: lms/templates/emails/mentor_request_creation_email.html:2 #: lms/templates/emails/mentor_request_creation_email.html:2
#: lms/templates/emails/mentor_request_status_update_email.html:2 #: lms/templates/emails/mentor_request_status_update_email.html:2
msgid "Dear" msgid "Dear"
msgstr "Yth." msgstr "Kepada Yth."
#: lms/templates/emails/batch_confirmation.html:2 #: lms/templates/emails/batch_confirmation.html:2
#: lms/templates/emails/batch_start_reminder.html:2 #: lms/templates/emails/batch_start_reminder.html:2
@@ -2188,7 +2188,7 @@ msgstr ""
#: frontend/src/pages/BatchForm.vue:89 lms/lms/doctype/cohort/cohort.json #: frontend/src/pages/BatchForm.vue:89 lms/lms/doctype/cohort/cohort.json
#: lms/lms/doctype/lms_batch/lms_batch.json #: lms/lms/doctype/lms_batch/lms_batch.json
msgid "End Date" msgid "End Date"
msgstr "Tanggal Akhir" msgstr "Tanggal Berakhir"
#. Label of the end_date (Date) field in DocType 'Education Detail' #. Label of the end_date (Date) field in DocType 'Education Detail'
#: lms/lms/doctype/education_detail/education_detail.json #: lms/lms/doctype/education_detail/education_detail.json